From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id D23DC3861834 for ; Tue, 20 Jul 2021 08:56:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D23DC3861834 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16K8jOmg131639; Tue, 20 Jul 2021 04:56:39 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39wu8j8aqw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 04:56:39 -0400 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16K8l0MU141735; Tue, 20 Jul 2021 04:56:39 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 39wu8j8apj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 04:56:38 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16K8lmYD029044; Tue, 20 Jul 2021 08:56:36 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06fra.de.ibm.com with ESMTP id 39upfh8p1x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 08:56:36 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16K8sAvB29491546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Jul 2021 08:54:10 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E742211C069; Tue, 20 Jul 2021 08:56:33 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2AF6511C070; Tue, 20 Jul 2021 08:56:31 +0000 (GMT) Received: from KewenLins-MacBook-Pro.local (unknown [9.197.247.15]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 20 Jul 2021 08:56:30 +0000 (GMT) Subject: Re: [RFC/PATCH] Use range-based for loops for traversing loops To: Andrew Pinski Cc: GCC Patches , Jakub Jelinek , Jonathan Wakely , Segher Boessenkool , Richard Sandiford , Trevor Saunders References: <0a8b77ba-1d54-1eff-b54d-d2cb1e769e09@linux.ibm.com> From: "Kewen.Lin" Message-ID: <8d71c3ed-6350-eeca-aac0-01e481e1fe9c@linux.ibm.com> Date: Tue, 20 Jul 2021 16:56:29 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: x5c6umw7PuEcrJpHsCzhW7xkRnkN0rOo X-Proofpoint-GUID: DuyRCKgVc8RG2HBRgYF0CH39qmMAhKcG Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-20_04:2021-07-19, 2021-07-20 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107200051 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 08:56:46 -0000 on 2021/7/19 下午2:26, Andrew Pinski wrote: > On Sun, Jul 18, 2021 at 11:21 PM Kewen.Lin via Gcc-patches > wrote: >> >> Hi, >> >> This patch follows Martin's suggestion here[1], to support >> range-based for loops for traversing loops, analogously to >> the patch for vec[2]. >> >> Bootstrapped and regtested on powerpc64le-linux-gnu P9, >> x86_64-redhat-linux and aarch64-linux-gnu, also >> bootstrapped on ppc64le P9 with bootstrap-O3 config. >> >> Any comments are appreciated. > > +1 from me (note I did not review the patch but I like the idea). > Thanks Andrew! It's actually Martin's idea. :) BR, Kewen > Thanks, > Andrew > >> >> BR, >> Kewen >> >> [1] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573424.html >> [2] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572315.html >> ----- >> gcc/ChangeLog: >> >> * cfgloop.h (class loop_iterator): Rename to ... >> (class loops_list): ... this. >> (loop_iterator::next): Rename to ... >> (loops_list::iterator::fill_curr_loop): ... this and adjust. >> (loop_iterator::loop_iterator): Rename to ... >> (loops_list::loops_list): ... this and adjust. >> (FOR_EACH_LOOP): Rename to ... >> (ALL_LOOPS): ... this. >> (FOR_EACH_LOOP_FN): Rename to ... >> (ALL_LOOPS_FN): this. >> (loops_list::iterator): New class. >> (loops_list::begin): New function. >> (loops_list::end): Likewise. >> * cfgloop.c (flow_loops_dump): Adjust FOR_EACH_LOOP* with ALL_LOOPS*. >> (sort_sibling_loops): Likewise. >> (disambiguate_loops_with_multiple_latches): Likewise. >> (verify_loop_structure): Likewise. >> * cfgloopmanip.c (create_preheaders): Likewise. >> (force_single_succ_latches): Likewise. >> * config/aarch64/falkor-tag-collision-avoidance.c >> (execute_tag_collision_avoidance): Likewise. >> * config/mn10300/mn10300.c (mn10300_scan_for_setlb_lcc): Likewise. >> * config/s390/s390.c (s390_adjust_loops): Likewise. >> * doc/loop.texi: Likewise. >> * gimple-loop-interchange.cc (pass_linterchange::execute): Likewise. >> * gimple-loop-jam.c (tree_loop_unroll_and_jam): Likewise. >> * gimple-loop-versioning.cc (loop_versioning::analyze_blocks): Likewise. >> (loop_versioning::make_versioning_decisions): Likewise. >> * gimple-ssa-split-paths.c (split_paths): Likewise. >> * graphite-isl-ast-to-gimple.c (graphite_regenerate_ast_isl): Likewise. >> * graphite.c (canonicalize_loop_form): Likewise. >> (graphite_transform_loops): Likewise. >> * ipa-fnsummary.c (analyze_function_body): Likewise. >> * ipa-pure-const.c (analyze_function): Likewise. >> * loop-doloop.c (doloop_optimize_loops): Likewise. >> * loop-init.c (loop_optimizer_finalize): Likewise. >> (fix_loop_structure): Likewise. >> * loop-invariant.c (calculate_loop_reg_pressure): Likewise. >> (move_loop_invariants): Likewise. >> * loop-unroll.c (decide_unrolling): Likewise. >> (unroll_loops): Likewise. >> * modulo-sched.c (sms_schedule): Likewise. >> * predict.c (predict_loops): Likewise. >> (pass_profile::execute): Likewise. >> * profile.c (branch_prob): Likewise. >> * sel-sched-ir.c (sel_finish_pipelining): Likewise. >> (sel_find_rgns): Likewise. >> * tree-cfg.c (replace_loop_annotate): Likewise. >> (replace_uses_by): Likewise. >> (move_sese_region_to_fn): Likewise. >> * tree-if-conv.c (pass_if_conversion::execute): Likewise. >> * tree-loop-distribution.c (loop_distribution::execute): Likewise. >> * tree-parloops.c (parallelize_loops): Likewise. >> * tree-predcom.c (tree_predictive_commoning): Likewise. >> * tree-scalar-evolution.c (scev_initialize): Likewise. >> (scev_reset): Likewise. >> * tree-ssa-dce.c (find_obviously_necessary_stmts): Likewise. >> * tree-ssa-live.c (remove_unused_locals): Likewise. >> * tree-ssa-loop-ch.c (ch_base::copy_headers): Likewise. >> * tree-ssa-loop-im.c (analyze_memory_references): Likewise. >> (tree_ssa_lim_initialize): Likewise. >> * tree-ssa-loop-ivcanon.c (canonicalize_induction_variables): Likewise. >> * tree-ssa-loop-ivopts.c (tree_ssa_iv_optimize): Likewise. >> * tree-ssa-loop-manip.c (get_loops_exits): Likewise. >> * tree-ssa-loop-niter.c (estimate_numbers_of_iterations): Likewise. >> (free_numbers_of_iterations_estimates): Likewise. >> * tree-ssa-loop-prefetch.c (tree_ssa_prefetch_arrays): Likewise. >> * tree-ssa-loop-split.c (tree_ssa_split_loops): Likewise. >> * tree-ssa-loop-unswitch.c (tree_ssa_unswitch_loops): Likewise. >> * tree-ssa-loop.c (gate_oacc_kernels): Likewise. >> (pass_scev_cprop::execute): Likewise. >> * tree-ssa-propagate.c (clean_up_loop_closed_phi): Likewise. >> * tree-ssa-sccvn.c (do_rpo_vn): Likewise. >> * tree-ssa-threadupdate.c >> (jump_thread_path_registry::thread_through_all_blocks): Likewise. >> * tree-vectorizer.c (vectorize_loops): Likewise. >> * tree-vrp.c (vrp_asserts::find_assert_locations): Likewise.