Re: PING^5: [PATCH] mips: Fix up mips_atomic_assign_expand_fenv [PR94780]

[Xi Ruoyao <xry111@mengyan1223.wang>]

On Fri, 2021-07-30 at 09:11 +0100, Richard Sandiford wrote:
> Xi Ruoyao <xry111@mengyan1223.wang> writes:
> > Ping again.
> > 
> > On Wed, 2021-06-23 at 11:11 +0800, Xi Ruoyao wrote:
> > > Commit message shamelessly copied from 1777beb6b129 by jakub:
> > > 
> > > This function, because it is sometimes called even outside of
> > > function
> > > bodies, uses create_tmp_var_raw rather than create_tmp_var.  But
> > > in
> > > order
> > > for that to work, when first referenced, the VAR_DECLs need to
> > > appear
> > > in a
> > > TARGET_EXPR so that during gimplification the var gets the right
> > > DECL_CONTEXT and is added to local decls.
> > > 
> > > Bootstrapped & regtested on mips64el-linux-gnu.  Ok for trunk and
> > > backport
> > > to 11, 10, and 9?
> 
> OK for all, thanks.
> 
> Similar comments to the previous message about the appropriateness
> of me reviewing the patch, but like you say, this is doing for MIPS
> what we've already had to do for other targets.

Thanks for reviewing.

Will bootstrap and test it again, and commit if there is no regressions.
-- 
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University