From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id DF3D3383F40B; Fri, 18 Jun 2021 15:15:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF3D3383F40B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: DQ21dPLG99tI3pqIVmekTTgNmSyGAbd0bbhXgVt4nWD24D+vbPJtq5zrIaqYYxfsguNe7yp9ng jE91NWBxVZSSVEq0EevtbpWap7rkgHHcuDfJWtEgJZfVdIZeSVCsXSgKAo3NCSLmTwG/7vYBUJ yb8fcwePPvWf6vWdPY12fJ6CPCdol255FnrvRDA2OPssPyVCp4BoUsJXiEa8Dohq2VMIRvTrJs Q4WMFyruS9+JsTKTxjb7hyOVPkYd/9RKXE7U8tJH6EfNHnwA7KqzP85WS1DeIL0KYJu7mKSfBZ X9w= X-IronPort-AV: E=Sophos;i="5.83,284,1616486400"; d="scan'208";a="62748966" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 18 Jun 2021 07:15:08 -0800 IronPort-SDR: uDt0qg9b4ex6nbWqfKWW5E4mQyKG+o+bS+/mpiITOh9LXkMOvUy4grSULoSO8gNTun7EerWWfJ J3fT+ya/+oZH3IFYlZHq5SpsodfEd9cdrA8K+EjD3KXM9JnLENNN9TeqsJgE6V6jMFE+Xfxvnp gsYwYKHinYY8UjlDbQsz0EEBpKqDeV0tJ5oRXZxb9emaceEn7rkO/24ws+230vXHijdWVIOMKD 1lptBrc/UxITl/A3d7qEg5gvh892mq6KfEEEQCJLH8bI+u000LiWpEDRFbx/ydkr4FGUtSgikv h78= Subject: Re: [PATCH 1/5] amdgcn: Use unsigned types for udivsi3/umodsi3 libgcc helper args/return To: Julian Brown , CC: , Tobias Burnus , Jakub Jelinek , Thomas Schwinge References: From: Andrew Stubbs Message-ID: <8d9f22cc-80ad-6cb7-8ca5-f801cefef598@codesourcery.com> Date: Fri, 18 Jun 2021 16:15:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-02.mgc.mentorg.com (139.181.222.2) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 15:15:10 -0000 On 18/06/2021 15:19, Julian Brown wrote: > This patch changes the argument and return types for the libgcc __udivsi3 > and __umodsi3 helper functions for GCN to USItype instead of SItype. > This is probably just cosmetic in practice. > > I can probably self-approve this, but I'll give Andrew Stubbs a chance > to comment. > > Thanks, > > Julian > > 2021-06-18 Julian Brown > > libgcc/ > * config/gcn/lib2-divmod.c (__udivsi3, __umodsi3): Change argument and > return types to USItype. > * config/gcn/lib2-gcn.h (__udivsi3, __umodsi3): Update prototypes. > --- > libgcc/config/gcn/lib2-divmod.c | 8 ++++---- > libgcc/config/gcn/lib2-gcn.h | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libgcc/config/gcn/lib2-divmod.c b/libgcc/config/gcn/lib2-divmod.c > index 0d6ca44f521..7c72e24e0c3 100644 > --- a/libgcc/config/gcn/lib2-divmod.c > +++ b/libgcc/config/gcn/lib2-divmod.c > @@ -102,15 +102,15 @@ __modsi3 (SItype a, SItype b) > } > > > -SItype > -__udivsi3 (SItype a, SItype b) > +USItype > +__udivsi3 (USItype a, USItype b) > { > return udivmodsi4 (a, b, 0); > } > > > -SItype > -__umodsi3 (SItype a, SItype b) > +USItype > +__umodsi3 (USItype a, USItype b) > { > return udivmodsi4 (a, b, 1); > } > diff --git a/libgcc/config/gcn/lib2-gcn.h b/libgcc/config/gcn/lib2-gcn.h > index 11476c4cda8..9223d73b8e7 100644 > --- a/libgcc/config/gcn/lib2-gcn.h > +++ b/libgcc/config/gcn/lib2-gcn.h > @@ -38,8 +38,8 @@ typedef int word_type __attribute__ ((mode (__word__))); > /* Exported functions. */ > extern SItype __divsi3 (SItype, SItype); > extern SItype __modsi3 (SItype, SItype); > -extern SItype __udivsi3 (SItype, SItype); > -extern SItype __umodsi3 (SItype, SItype); > +extern USItype __udivsi3 (USItype, USItype); > +extern USItype __umodsi3 (USItype, USItype); > extern HItype __divhi3 (HItype, HItype); > extern HItype __modhi3 (HItype, HItype); > extern UHItype __udivhi3 (UHItype, UHItype); OK, this seems to match what some other targets have. Except NIOS2 though, which is probably where this file was copied from. Andrew