From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AE60B3858C27 for ; Thu, 17 Aug 2023 17:40:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE60B3858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692294008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=cZyGFzUntOLOOYjxYpTc2xVA7gKc8KcUwnyPdNBSGrU=; b=HJQuJH9dlodedCfvehOEkrHqhAbMejfDMG0G5Glajivesn9PtqIn5NbfCW7+rwK6R9hGbS vwJorp1I07MmIRSEyv2yTDyvE8AEm+CN05VRc3re/em/jMR1R1QcyTBm5WgLElC5IHOzJv snqwppCFpB6tnlMUz/0DFh5ynbqhW8k= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-4WTTNbobNueRgAutYaTQtA-1; Thu, 17 Aug 2023 13:40:06 -0400 X-MC-Unique: 4WTTNbobNueRgAutYaTQtA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-76c973b8973so7999185a.1 for ; Thu, 17 Aug 2023 10:40:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692294005; x=1692898805; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aCI6Su6fCtCLGzdtu+x+2TypP3zIDISPQ9+Jmi71KWk=; b=QB25QJTHp2dwz6YvRtaWgqWOF/YD1HO6RrLuqO/aq8G76w4CbsjoiGZ3qEqNppZa7P fGZr7WYBSPpMH7tvI4CJ2LCBvROydpjB3mVZkZzHGfg4bL15bLx/iT8wkxJkPU+tklUz M3SQ+U/TO5ZfQiqReyzRTnJ6n7AyBxT/VTt/VZHYSA2M3nlZfMODv0hBfqx8VGYTlUH8 WseVWVQUEuY7bOUVENhsXGKCRNfDHfWZtXvutqhj+guW3//Za8ntF6qNAugYNys0A8tn s4FDpBYvW2xH8Zxy/0ywE+K305V6VP7ndKcS//Pq5gcVJ+35peQo3rZc5PHAlMLd+cod mfTA== X-Gm-Message-State: AOJu0YwM4+d9Tc/8oeZK+Ml1I1o4qa9XGgjwyePmbvz0K6YkdouHfzrO iYWdPTYe0/gxEQO/YSCaJOIbzeh+SYove6yZ9wlggVxKdaMFdLtKcAlTydqTw/tEgBTLlNfeA1B E0VVAKWBITk3Q/nlN0TJLqjfhLhpKOGtrdXJXHDmmUheaefkF6rQzxMFQXPv1e06PQIoyruWkwR QVeg== X-Received: by 2002:a05:620a:4414:b0:76c:5715:b45f with SMTP id v20-20020a05620a441400b0076c5715b45fmr434239qkp.14.1692294005266; Thu, 17 Aug 2023 10:40:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHu7QuxUuiqlOlznZfUCziGoqfcibyeuxbT97ZMLlyAkNub9jpHM5SqsfEGI6xwUiQiHbexUQ== X-Received: by 2002:a05:620a:4414:b0:76c:5715:b45f with SMTP id v20-20020a05620a441400b0076c5715b45fmr434211qkp.14.1692294004743; Thu, 17 Aug 2023 10:40:04 -0700 (PDT) Received: from [10.19.97.94] ([69.17.166.84]) by smtp.gmail.com with ESMTPSA id a8-20020a05620a102800b00767d4a3f4d9sm5303644qkk.29.2023.08.17.10.40.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Aug 2023 10:40:04 -0700 (PDT) Message-ID: <8da8804e-be70-a023-253c-317327ff955d@redhat.com> Date: Thu, 17 Aug 2023 13:40:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: gcc-patches Cc: "hernandez, aldy" From: Andrew MacLeod Subject: [COMMITTED] PR tree-optimization/111009 - Fix range-ops operator_addr. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------ymifPRRp8SYZALdvCCwM5pUd" Content-Language: en-US X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------ymifPRRp8SYZALdvCCwM5pUd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit operator_addr was simply calling fold_range() to implement op1_range, but it turns out op1_range needs to be more restrictive. take for example  from the PR :    _13 = &dso->maj when folding,  getting a value of 0 for op1 means dso->maj resolved to a value of [0,0].  fold_using_range::range_of_address will have processed the symbolics, or at least we know that op1 is 0.  Likewise if it is non-zero, we can also conclude the LHS is non-zero. however, when working from the LHS, we cannot make the same conclusions.  GORI has no concept of symblics, so knowing the expressions is [0,0]  = &  we cannot conclude the op1 is also 0.. in particular &dso->maj wouldnt be unless dso was zero and maj was also a zero offset. Likewise if the LHS is [1,1] we cant be sure op1 is nonzero unless we know the type cannot wrap. This patch simply implements op1_range with these rules instead of calling fold_range. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew --------------ymifPRRp8SYZALdvCCwM5pUd Content-Type: text/plain; charset=UTF-8; name="009" Content-Disposition: attachment; filename="009" Content-Transfer-Encoding: base64 RnJvbSBkYzQ4ZDFkMWQ0NDU4NzczZjg5ZjIxYjJmMDE5ZjY2ZGRmODhmMmU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4K RGF0ZTogVGh1LCAxNyBBdWcgMjAyMyAxMToxMzoxNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCByYW5nZS1vcHMgb3BlcmF0b3JfYWRkci4KCkxhY2sgb2Ygc3ltYm9saWMgaW5mb3JtYXRpb24g cHJldmVudHMgb3AxX3JhbmdlIGZyb20gYmVpZyBhYmxlIHRvIGRyYXcKdGhlIHNhbWUgY29uY2x1 c2lvbnMgYXMgZm9sZF9yYW5nZSBjYW4uCgoJUFIgdHJlZS1vcHRpbWl6YXRpb24vMTExMDA5Cgln Y2MvCgkqIHJhbmdlLW9wLmNjIChvcGVyYXRvcl9hZGRyX2V4cHI6Om9wMV9yYW5nZSk6IEJlIG1v cmUgcmVzdHJpY3RpdmUuCgoJZ2NjL3Rlc3RzdWl0ZS8KCSogZ2NjLmRnL3ByMTExMDA5LmM6IE5l dy4KLS0tCiBnY2MvcmFuZ2Utb3AuY2MgICAgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKy0K IGdjYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMTExMDA5LmMgfCAzOCArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNDkgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGdjYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMTExMDA5 LmMKCmRpZmYgLS1naXQgYS9nY2MvcmFuZ2Utb3AuY2MgYi9nY2MvcmFuZ2Utb3AuY2MKaW5kZXgg MDg2YzZjMTk3MzUuLjI2OGY2YjZmMDI1IDEwMDY0NAotLS0gYS9nY2MvcmFuZ2Utb3AuY2MKKysr IGIvZ2NjL3JhbmdlLW9wLmNjCkBAIC00MzI1LDcgKzQzMjUsMTcgQEAgb3BlcmF0b3JfYWRkcl9l eHByOjpvcDFfcmFuZ2UgKGlyYW5nZSAmciwgdHJlZSB0eXBlLAogCQkJICAgICAgIGNvbnN0IGly YW5nZSAmb3AyLAogCQkJICAgICAgIHJlbGF0aW9uX3RyaW8pIGNvbnN0CiB7Ci0gIHJldHVybiBv cGVyYXRvcl9hZGRyX2V4cHI6OmZvbGRfcmFuZ2UgKHIsIHR5cGUsIGxocywgb3AyKTsKKyAgIGlm IChlbXB0eV9yYW5nZV92YXJ5aW5nIChyLCB0eXBlLCBsaHMsIG9wMikpCisgICAgcmV0dXJuIHRy dWU7CisKKyAgLy8gUmV0dXJuIGEgbm9uLW51bGwgcG9pbnRlciBvZiB0aGUgTEhTIHR5cGUgKHBh c3NlZCBpbiBvcDIpLCBidXQgb25seQorICAvLyBpZiB3ZSBjYW50IG92ZXJmbG93LCBlaXRoZXJ3 aXNlIGEgbm8temVybyBvZmZzZXQgY291bGQgd3JhcCB0byB6ZXJvLgorICAvLyBTZWUgUFIgMTEx MDA5LgorICBpZiAoIWNvbnRhaW5zX3plcm9fcCAobGhzKSAmJiBUWVBFX09WRVJGTE9XX1VOREVG SU5FRCAodHlwZSkpCisgICAgciA9IHJhbmdlX25vbnplcm8gKHR5cGUpOworICBlbHNlCisgICAg ci5zZXRfdmFyeWluZyAodHlwZSk7CisgIHJldHVybiB0cnVlOwogfQogDAogLy8gSW5pdGlhbGl6 ZSBhbnkgaW50ZWdyYWwgb3BlcmF0b3JzIHRvIHRoZSBwcmltYXJ5IHRhYmxlCmRpZmYgLS1naXQg YS9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjExMTAwOS5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcv cHIxMTEwMDkuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uM2FjY2Q5 YWMwNjMKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy5kZy9wcjExMTAwOS5j CkBAIC0wLDAgKzEsMzggQEAKKy8qIFBSIHRyZWUtb3B0aW1pemF0aW9uLzExMTAwOSAqLworLyog eyBkZy1kbyBydW4gfSAqLworLyogeyBkZy1vcHRpb25zICItTzMgLWZuby1zdHJpY3Qtb3ZlcmZs b3ciIH0gKi8KKworc3RydWN0IGRzbyB7Cisgc3RydWN0IGRzbyAqIG5leHQ7CisgaW50IG1hajsK K307CisKK19fYXR0cmlidXRlX18oKG5vaXBhKSkgc3RhdGljIHZvaWQgX19kc29faWRfX2NtcF8o dm9pZCkge30KKworX19hdHRyaWJ1dGVfXygobm9pcGEpKQorc3RhdGljIGludCBidWcoc3RydWN0 IGRzbyAqIGQsIHN0cnVjdCBkc28gKmRzbykKK3sKKyBzdHJ1Y3QgZHNvICoqcCA9ICZkOworIHN0 cnVjdCBkc28gKmN1cnIgPSAwOworCisgd2hpbGUgKCpwKSB7CisgIGN1cnIgPSAqcDsKKyAgLy8g cHJldmVudCBudWxsIGRlcmVmIGJlbG93CisgIGlmICghZHNvKSByZXR1cm4gMTsKKyAgaWYgKGRz byA9PSBjdXJyKSByZXR1cm4gMTsKKworICBpbnQgKmEgPSAmZHNvLT5tYWo7CisgIC8vIG51bGwg ZGVyZWYKKyAgaWYgKCEoYSAmJiAqYSkpIF9fZHNvX2lkX19jbXBfKCk7CisKKyAgcCA9ICZjdXJy LT5uZXh0OworIH0KKyByZXR1cm4gMDsKK30KKworX19hdHRyaWJ1dGVfXygobm9pcGEpKQoraW50 IG1haW4odm9pZCkgeworICAgIHN0cnVjdCBkc28gZCA9IHsgMCwgMCwgfTsKKyAgICBidWcoJmQs IDApOworfQorCi0tIAoyLjQxLjAKCg== --------------ymifPRRp8SYZALdvCCwM5pUd--