From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75164 invoked by alias); 3 Jun 2019 17:35:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 75155 invoked by uid 89); 3 Jun 2019 17:35:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=variety, seriously, INT_MAX, int_max X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 17:35:52 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E3929C1EB1F1; Mon, 3 Jun 2019 17:35:50 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-57.rdu2.redhat.com [10.10.112.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C9B12E053; Mon, 3 Jun 2019 17:35:50 +0000 (UTC) From: Jeff Law Subject: Re: [PATCH] PR88777, Out-of-range offsets building glibc test-tgmath2.c To: Alan Modra Cc: gcc-patches@gcc.gnu.org, Richard Sandiford References: <20190110071913.GQ3170@bubble.grove.modra.org> <68c7aad4-ac0f-71ec-1ec4-b8a1e942a618@redhat.com> <20190111234457.GC11037@bubble.grove.modra.org> Openpgp: preference=signencrypt Message-ID: <8db4e1fb-02dc-5503-affb-75d6d02360d8@redhat.com> Date: Mon, 03 Jun 2019 17:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190111234457.GC11037@bubble.grove.modra.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00109.txt.bz2 On 1/11/19 4:44 PM, Alan Modra wrote: > On Fri, Jan 11, 2019 at 11:42:31AM -0700, Jeff Law wrote: >> On 1/10/19 12:19 AM, Alan Modra wrote: >>> bb-reorder is quite seriously broken if get_attr_min_length should >>> return INT_MAX, which it does for hppa on branches with r267666. >> Presumably you're referring to the overflows and such? > > Yes. Even get_uncond_jump_length would have been INT_MAX. All of > the predicates deciding on whether to copy or reorder blocks were > therefore broken. > > The following is fairly obvious and would stop some of the silliness, > but I guess now is not the time to propose this sort of patch. > > * bb-reorder.c (copy_bb_p): Don't overflow size calculation. > (get_uncond_jump_length): Assert length less than INT_MAX and > non-negative. Now seems like a good time to revisit. I ran this through the usual bootstrap and regression text on x86_64. It's also built and tested on a good variety of the embedded targets. Can't really test the PA right now due to what I believe is a qemu bug. David is still doing bootstraps on real hardware through, so if it causes a problem on the PA I'm sure he'll chime in at some point. I'm going to go ahead and install this on the trunk. jeff