From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 74807385840B for ; Tue, 23 Apr 2024 23:07:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74807385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 74807385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713913643; cv=none; b=NrTZkMtCJEyH6S8jq0+5jBzYMGqu1FsltXaP85YeO+skbr81+JNCyHThYali4Ffp+NFg5vbDW0EhsoWf2pLMHJP9JoNd3qxy0+O2hIrXK381qczySJL3NtvJjAVayZSqqgr8X1TGZxzZCYMBv6psxToJepghYpbMK4+p9bbRwno= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713913643; c=relaxed/simple; bh=aV0T+RHWYGQGPVrU/cUl8lJNmhGotlXZo/p0M9yO5tE=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=SIjI11Mw++SkAFOGwTOR5EyQPqKWC4bXZicKIiv57rwCgALzPxbmoHmC9UVRxsFf7eeVKAvQUH5oZuKsJnDmw8ABoMMUWxv9o8FavR6E+wcwp75kxPj9A1KtPJG/wJdRgkX91JSwypY/7eR2yYQoomp2t3MAsJ3Wm+sNZnZgdcY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713913641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cCida7qmHJyn35paRAwYMWdRwSvtnspF71B9Bh7C6cc=; b=JUnuz3o5u+LPL/WOAttWHGxsuwxTHa0r5GtwQoUT9g6NrZKnR45pjGe50VVhCd/EtwrR0h RoNMpdjC1pYBezZhyLd7bnVnBiEYnSBScUctb/tEvCvIS/aMaby4nJLzlKV/VJ1l4rcIYT wkUgKxCKujtW32EROLPiT6oppFv87AA= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-OFd-q2N-NiG_fluaoakDOw-1; Tue, 23 Apr 2024 19:07:19 -0400 X-MC-Unique: OFd-q2N-NiG_fluaoakDOw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-61aecbcb990so114820807b3.1 for ; Tue, 23 Apr 2024 16:07:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713913639; x=1714518439; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cCida7qmHJyn35paRAwYMWdRwSvtnspF71B9Bh7C6cc=; b=vnZ20W/k1OW59pj2E1/lKDl9HxhiliCwBr0dmdk2ZtkESGDSTszg/3+0Ys3Pj5aaJy qFhdILL0vkOSSeioqOvx/9Yn8p/t7dusP/N+LcDBuJ1bOw2mYLyJb6Puk8sykWQPCN7i 3LTHiIDH94j86Vpq4hntZ7URzBRb94n0rTXO/2Z0fW8dr7ue8XO1jNvsZtIAl0Klo7nZ /CQud13gLXnt4NLzrnFAKG7OxmCMpozbktP3IaEiOvxYpjjsX6bZHssp89WZXo42gnxK NVUTBnl5t5T0xN+81SHnaYKQ56cUKRtJpFt8XPa+D5WKt2alEM1tTyzzkoBxAAKJvy6D 6Kcw== X-Forwarded-Encrypted: i=1; AJvYcCUIjKR4CU4XCteeqghXj3NmKD1raSZNB3Vn+KKNe+RZRTONR/ppZJco9K9Yxy8xRlmjhnHM2ZAewimfdNbfJ89OHtMA+iNXAg== X-Gm-Message-State: AOJu0YzS5+4YWmWJNBb5lhLri6mLFEkG2tV+g4OgAWswCSUPdsBeLZSC Z7RGyrZUDRYQs2ur3qvSpEBreH/ZOZPkkjv9T3SqnnbdlBaiYJLEqUSvxvqzV2/hqnzMUhM0Opd FX2R8Ok1YUms4fOu0quAvs3BgTUX7ZzK88/KE0L0kad7w5EOH3QhouO8= X-Received: by 2002:a05:690c:c84:b0:61a:c439:9b36 with SMTP id cm4-20020a05690c0c8400b0061ac4399b36mr1018211ywb.4.1713913639205; Tue, 23 Apr 2024 16:07:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcr/78/IXa1EVcyToARUhhL1gIGR0Hm2n6m2x+zuyEhyvhKdCpxtX9rlm4iZeyRppcbsQaHw== X-Received: by 2002:a05:690c:c84:b0:61a:c439:9b36 with SMTP id cm4-20020a05690c0c8400b0061ac4399b36mr1018196ywb.4.1713913638886; Tue, 23 Apr 2024 16:07:18 -0700 (PDT) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id u5-20020ac80505000000b00437a02f67c5sm5417716qtg.49.2024.04.23.16.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 16:07:18 -0700 (PDT) Message-ID: <8ddbfe0ab367bd1c7dd8d47fe894028f84ed5fe9.camel@redhat.com> Subject: Re: [PATCH] DOCUMENTATION_ROOT_URL vs. release branches [PR114738] From: David Malcolm To: Jakub Jelinek Cc: Mark Wielaard , gcc-patches@gcc.gnu.org Date: Tue, 23 Apr 2024 19:07:17 -0400 In-Reply-To: References: User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2024-04-23 at 17:45 +0200, Jakub Jelinek wrote: > On Tue, Apr 23, 2024 at 11:40:55AM -0400, David Malcolm wrote: > > > So, I think at least for the MAJOR.MINOR.0 releases we want to > > > use > > > URLs like above rather than the trunk ones and we can use the > > > same > > > process > > > of updating *.opt.urls as well for that. > >=20 > > Would it make sense to instead update the default value in > > gcc/configure.ac for DOCUMENTATION_ROOT_URL when branching or > > releasing, from https://gcc.gnu.org/onlinedocs/=C2=A0to > > https://gcc.gnu.org/onlinedocs/gcc-MAJOR-MINOR.0/ > >=20 > > ? > >=20 > > Before this patch the DOCUMENTATION_ROOT_URL expresses the location > > of > > a built texinfo html tree of docs, and the url suffixes express the > > path within that tree. > >=20 > > As the patch is written, if a distributor overrides --with- > > documentation-root-url=3D at configure time, then they need to mirror > > the > > structure of our website on their website, which seems like a > > burden. >=20 > Sure, that is doable (of course, it shouldn't be done by updating > gcc/configure.ac but by adjusting the default in there based on > gcc_version, > I'll post a patch tomorrow). That sounds like a better approach; thanks. >=20 > Still, what do you think we should do on the release branches > (recommend to > developers and check with the post-commit CI)? My hope is that the URL suffixes don't change: we shouldn't be adding new command-line options on the release branches, and I'd hope that texinfo doesn't change the generated anchors from run to run. > No regeneration of *.urls except before doing a new release > candidate, > or a different make goal that would grab html files from the web and > regenerate against that? That sounds overcomplicated.=20 If the anchors do change, it's fairly trivial to run "make regenerate- opt-urls" locally, isn't it? As mentioned above, I like the idea of having the DOCUMENTATION_ROOT_URL express the location of a tree of docs built with texinfo, and for the url suffixes to be relative to that. We can update the default in gcc/configure.ac for released branches, and drop the logic from your previous patch. So if a distributor wants to upload their docs for a particular version to their own location, they're responsible for providing a suitable value for --with- documentation-root-url=3D at configure time. Or am I missing something here? Dave