From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 714E13858CDB for ; Fri, 14 Jul 2023 07:27:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 714E13858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.01,204,1684828800"; d="diff'?scan'208";a="13328328" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 13 Jul 2023 23:27:21 -0800 IronPort-SDR: wPUMqhbWJN3hzOdIen0xAk0uLeRBlIqsN8ytOwYBAWVrucp9A83OPmlF7cNLLAW2hfESbd9kuU F0JV8jBkj3xyQjZRQxdcBHzt2Rt1lXTv9ioyGdodusjb9RI7hKy+ZyQck/U86d9mlrerqdNWtJ heQI49Zyc9pyunfY1o70kAmyAwko5xNcREUAeh01ZN1phHzLYhSU3+eW6boNlQIoLvnV9sJJPl Cf6tc+pniZxcUxPaLtIOrC6lCI+s7AYMCpqSuzivMrk4ePPwCYilj92n6Xd4cPSRuK8G0HP9Mq Y+A= Content-Type: multipart/mixed; boundary="------------nzrTr7B0m2hU2OPU1PtdS7Gj" Message-ID: <8e3f9f96-2f1f-2630-74bd-75fa18ae841c@codesourcery.com> Date: Fri, 14 Jul 2023 09:27:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [Patch] libgomp: Use libnuma for OpenMP's partition=nearest allocation trait Content-Language: en-US To: Prathamesh Kulkarni CC: gcc-patches , Jakub Jelinek References: <34fce57b-69a0-a9fd-f8ff-671ee7f94227@codesourcery.com> <5b66591e-6af2-7219-acfc-640aeffad0b0@codesourcery.com> From: Tobias Burnus In-Reply-To: X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------nzrTr7B0m2hU2OPU1PtdS7Gj Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Hi Prathamesh, On 13.07.23 18:13, Prathamesh Kulkarni wrote: > The newly added tests in above commit -- alloc-11.c and alloc-12.c > seem to fail during execution on armv8l-unknown-linux-gnueabihf: thanks for the report and sorry for the breakage. While being aware that libnuma is potentially not available, the code actually did not properly test for it. (That 200+ packages require libnuma on this system, did not help with testing it without, though.) I have committed the attached obvious patch as r14-2514-g407d68daed00e0, which hopefully fixes all issues. Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------nzrTr7B0m2hU2OPU1PtdS7Gj Content-Type: text/x-patch; charset="UTF-8"; name="committed.diff" Content-Disposition: attachment; filename="committed.diff" Content-Transfer-Encoding: base64 Y29tbWl0IDQwN2Q2OGRhZWQwMGUwNDBhN2Q5NTQ1YjJhMThhYTI3YmY5M2ExMDYKQXV0aG9y OiBUb2JpYXMgQnVybnVzIDx0b2JpYXNAY29kZXNvdXJjZXJ5LmNvbT4KRGF0ZTogICBGcmkg SnVsIDE0IDA5OjE0OjM3IDIwMjMgKzAyMDAKCiAgICBsaWJnb21wOiBGaXggYWxsb2NhdG9y IGhhbmRsaW5nIGZvciBMaW51eCB3aGVuIGxpYm51bWEgaXMgbm90IGF2YWlsYWJsZQogICAg CiAgICBGb2xsb3cgdXAgdG8gcjE0LTI0NjItZzQ1MGIwNWNlNTRkM2YwLiAgVGhlIGNhc2Ug dGhhdCBsaWJudW1hIHdhcyBub3QKICAgIGF2YWlsYWJsZSBhdCBydW50aW1lIHdhcyBub3Qg cHJvcGVybHkgaGFuZGxlZDsgbm93IGl0IGZhbGxzIGJhY2sgdG8KICAgIHRoZSBub3JtYWwg bWFsbG9jLgogICAgCiAgICBsaWJnb21wLwogICAgCiAgICAgICAgICAgICogYWxsb2NhdG9y LmMgKG9tcF9pbml0X2FsbG9jYXRvcik6IENoZWNrIHdoZXRoZXIgc3ltYm9sIGZyb20KICAg ICAgICAgICAgZGxvcGVuZWQgbGlibnVtYSBpcyBhdmFpbGFibGUgYmVmb3JlIHVzaW5nIGxp Ym51bWEgZm9yCiAgICAgICAgICAgIGFsbG9jYXRpb25zLgotLS0KIGxpYmdvbXAvYWxsb2Nh dG9yLmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpYmdvbXAvYWxsb2NhdG9yLmMgYi9saWJnb21wL2Fs bG9jYXRvci5jCmluZGV4IGIzMTg3YWIyOTExLi45MGYyZGNiNjBkNiAxMDA2NDQKLS0tIGEv bGliZ29tcC9hbGxvY2F0b3IuYworKysgYi9saWJnb21wL2FsbG9jYXRvci5jCkBAIC0zNzcs OCArMzc3LDkgQEAgb21wX2luaXRfYWxsb2NhdG9yIChvbXBfbWVtc3BhY2VfaGFuZGxlX3Qg bWVtc3BhY2UsIGludCBudHJhaXRzLAogI2lmZGVmIExJQkdPTVBfVVNFX0xJQk5VTUEKICAg aWYgKGRhdGEubWVta2luZCA9PSBHT01QX01FTUtJTkRfTk9ORSAmJiBkYXRhLnBhcnRpdGlv biA9PSBvbXBfYXR2X25lYXJlc3QpCiAgICAgewotICAgICAgZGF0YS5tZW1raW5kID0gR09N UF9NRU1LSU5EX0xJQk5VTUE7CiAgICAgICBsaWJudW1hX2RhdGEgPSBnb21wX2dldF9saWJu dW1hICgpOworICAgICAgaWYgKGxpYm51bWFfZGF0YS0+bnVtYV9hbGxvY19sb2NhbCAhPSBO VUxMKQorCWRhdGEubWVta2luZCA9IEdPTVBfTUVNS0lORF9MSUJOVU1BOwogICAgIH0KICNl bmRpZgogCg== --------------nzrTr7B0m2hU2OPU1PtdS7Gj--