From: Jeff Law <law@redhat.com>
To: "Maciej W. Rozycki" <macro@imgtec.com>, gcc-patches@gcc.gnu.org
Cc: Bernd Edlinger <bernd.edlinger@hotmail.de>
Subject: Re: [PATCH] Indicate minimum in-tree MPFR version handled
Date: Tue, 16 Aug 2016 16:49:00 -0000 [thread overview]
Message-ID: <8e7e1800-67ee-9a32-d384-8fa63b019f9f@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1608112247430.4471@tp.orcam.me.uk>
On 08/11/2016 05:20 PM, Maciej W. Rozycki wrote:
> Hi,
>
> Commit 235763 removed support for versions of MPFR below 3.1.0 which have
> a flat directory structure, however it did not introduce any safety check
> for such an unhandled library version present in the tree. Consequently
> the system-installed version is silently chosen, which if too old, causes
> a confusing configuration failure in mpc/ stating a misleading version
> requirement:
>
> checking for MPFR... yes
> checking for recent GMP... yes
> checking for recent MPFR... no
> configure: error: MPFR version >= 2.4.2 required
> make[1]: *** [configure-mpc] Error 1
>
> I propose the check below to make people's life just a little bit easier
> and indicate right away that an incorrect version of MPFR has been found
> in the source tree. This is especially helpful when you just sync your
> build tree from upstream and may easily miss the updated requirement. I
> carefully chose to use "handled" rather than "supported" in the message as
> the commit referred clearly indicates you are on your own with versions of
> the libraries different from those stated in `download_prerequisites'.
>
> 2016-08-12 Maciej W. Rozycki <macro@imgtec.com>
>
> * configure.ac: Check for the minimum in-tree MPFR version
> handled.
> * configure: Regenerate.
>
> OK to apply?
OK.
jeff
next prev parent reply other threads:[~2016-08-16 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 23:21 Maciej W. Rozycki
2016-08-12 5:21 ` Bernd Edlinger
2016-09-12 14:37 ` Maciej W. Rozycki
2016-08-16 16:49 ` Jeff Law [this message]
2016-09-12 14:10 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7e1800-67ee-9a32-d384-8fa63b019f9f@redhat.com \
--to=law@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=macro@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).