From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id E6748388C02B for ; Thu, 17 Sep 2020 21:33:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E6748388C02B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-VLMFLFxONyOLf1gpgwkCvQ-1; Thu, 17 Sep 2020 17:33:24 -0400 X-MC-Unique: VLMFLFxONyOLf1gpgwkCvQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B2E93186DD2A; Thu, 17 Sep 2020 21:33:23 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-142.phx2.redhat.com [10.3.112.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77EB268D60; Thu, 17 Sep 2020 21:33:23 +0000 (UTC) Subject: Re: [PATCH] libiberty/pex-win32.c: Initialize orig_err To: Christophe Lyon , gcc-patches@gcc.gnu.org References: <1600075768-21285-1-git-send-email-christophe.lyon@linaro.org> From: Jeff Law Message-ID: <8e8cd5c9-2b66-0c3c-cf18-9b33db495547@redhat.com> Date: Thu, 17 Sep 2020 15:33:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1600075768-21285-1-git-send-email-christophe.lyon@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------8DEE060D075C0BA4EDD06F4A" Content-Language: en-US X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 21:33:29 -0000 This is a multi-part message in MIME format. --------------8DEE060D075C0BA4EDD06F4A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/14/20 3:29 AM, Christophe Lyon via Gcc-patches wrote: > Initializing orig_err avoids a warning: "may be used uninitialized". > > 2020-09-14 Torbj=C3=B6rn SVENSSON > =09Christophe Lyon > > =09libiberty/ > =09* pex-win32 (pex_win32_exec_child): Initialize orig_err. Rather than just blindly initializing orig_err, we'd actually prefer to have a compilable testcase and analyze why we're getting the warning.=C2=A0= A false positive -Wuninitialized warning is often a missed optimization under the hood. jeff --------------8DEE060D075C0BA4EDD06F4A Content-Type: application/pgp-keys; name="pEpkey.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="pEpkey.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- mQENBFkbIO8BCACVIqDhDVh9ur8C+zNV1J/cXfwvVDAUcphDEFl4jyHqZORK4Pd3 Db8oWqLmQ8lOCr/VOS7lrCtdpVMQkLGOGA16oJ8g7hzhnojpjY09UjsoUiG7oKac uxj8skfp6SIx93Zl+iNYPRa4S+za6nY8qiVjyUuiyX04ZPZMrKp2c2sGi+HnBKUZ XGhrz/Jdzdox3tjajWZnObyynhEN6hn9L3KawTtGPE/R6A/1RhHTD9FQmIWIeucp aY5c6GNKXTFpj2VYx57LY5hve1R5vhrJIZcgwZAiOtmik5lVi96glY5h6bugRwpe xjhwORTLPBCkwiYotSxX99mWd6EHL576i5CNABEBAAG0GUplZmYgTGF3IDxsYXdA cmVkaGF0LmNvbT6JAU4EEwEIADgWIQR+niGjtnP5P/8PpRq8fP682pgzWwUCWRsg 7wIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRC8fP682pgzW5QGB/9VATJm x5235RB+8jiDYGXQf3vd9gBfPy/l1tsaK400eFAevDzfGvKmeCKe+uGnlrH3vyT8 rg9zqH+s5a1Y+lDXPOpJAFmmzbOLU4FW4ucbawmtYvBL65PqpQneCTYnC802/OAc xjm/OnemHlgeK6WicNsBTPwYN/0araDFUejyYBIFi9CNqqflwk5Z3brKbQ9bAYIk ysVLC/c3njKPmM0cWPFHG91ubLbWCHwTIK0+mAL714eTD74dXzOjO2ZDBPLGlFN/ kO3+YjaO6UOD2O8acvAMCivTkWLr7JwRgLIQDN2DkhQDd3LTPqQE/yOcMcXBTO+f xm8KG0iKQBqWMyGJuQENBFkbIO8BCACyqbOsv7XegSeea8XORt5zMaBVWKoSyhmm cCmlxZFS2cuYOBt79MO13lZE2DlO3Lv5IKikj/D4ketGVO4+h5psEMH5Yz5P8bx0 TmgwbK1GxPZrzeXozUFJDvvCDbIlT0v0pwUXuK3hg8Ieo2h5uTed/cn1OjySXW5B qLxN0cyr5hL+J6dcsHvKLT/N3nTgCQhoJXK2MrEMhAGgF3jKpMn3CoS4i/ZbNI2M QR6LWHwdZ95f0fI8NzHSfVzeLtzCKQec7nr9fgd6Ylk1ZpGWQUPlQmKjzYgeCeTK NO04cwt20WIrQWeWiZFPA0U86NDBdSBrYp4kG3dfIXE+wSSvE7qPABEBAAGJATYE GAEIACAWIQR+niGjtnP5P/8PpRq8fP682pgzWwUCWRsg7wIbDAAKCRC8fP682pgz W3REB/9cT7iKRPg/OK9bpLlllIEDM90IaKC79DQrv+fRudOR78cdV4XUwPSFnyHU sP3VJ4lDy5FhiKCwGie0BK53EsxgMrLy1L8hboFdTE4Vi0xzCheMaMVp4hATDU29 k1cuxu1VPpCa8E3mYeHjNV7ip0HN5L4Drfs8lRPJE/oM1vGs9DgQFZrCPPNRNGKC 97BH+DHccesEJr7tSsQrkPkt0z/FTKr5wIM02vSxOJjgmcVbGB7dc2j/Sx8loXmu KnuKtM35668kUG8jeJvSQk3o/VHpD27bhl0rR68R2jN6G6kQegMVb6dPu1Ius8rB E5rFw88J4JEb5q4hMNClWWUFHIdP =3DIDHe -----END PGP PUBLIC KEY BLOCK----- --------------8DEE060D075C0BA4EDD06F4A--