From: HAO CHEN GUI <guihaoc@linux.ibm.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Bill Schmidt <wschmidt@linux.ibm.com>
Subject: [PATCH, rs6000] fix execution failure of parity_1.f90 on P10 [PR100952]
Date: Tue, 6 Jul 2021 11:01:28 +0800 [thread overview]
Message-ID: <8e90535a-4b51-832b-29d5-df3c68e1a5e9@linux.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
Hi,
The patch fixed the wrong "if" fall through in "cstore<mode>4"
expand, which causes comparison pattern expanded twice on P10.
The attachments are the patch diff and change log file.
Bootstrapped and tested on powerpc64le-linux with no regressions.
Is this okay for trunk? Any recommendations? Thanks a lot.
[-- Attachment #2: ChangeLog1 --]
[-- Type: text/plain, Size: 86 bytes --]
PR target/100952
* config/rs6000/rs6000.md (cstore<mode>4): Fix wrong fall through.
[-- Attachment #3: patch1.diff --]
[-- Type: text/plain, Size: 577 bytes --]
diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 3f59b544f6a..3ae7aa29c1d 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -11627,7 +11627,7 @@ (define_expand "cstore<mode>4"
/* Expanding EQ and NE directly to some machine instructions does not help
but does hurt combine. So don't. */
- if (GET_CODE (operands[1]) == EQ)
+ else if (GET_CODE (operands[1]) == EQ)
emit_insn (gen_eq<mode>3 (operands[0], operands[2], operands[3]));
else if (<MODE>mode == Pmode
&& GET_CODE (operands[1]) == NE)
next reply other threads:[~2021-07-06 3:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 3:01 HAO CHEN GUI [this message]
2021-07-13 1:38 ` HAO CHEN GUI
2021-07-19 2:39 ` Ping " HAO CHEN GUI
2021-07-21 22:19 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e90535a-4b51-832b-29d5-df3c68e1a5e9@linux.ibm.com \
--to=guihaoc@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).