* [patch] gcn: Add missing space to ASM_SPEC in gcn-hsa.h
@ 2024-01-25 12:44 Tobias Burnus
2024-01-25 14:34 ` Andrew Stubbs
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Burnus @ 2024-01-25 12:44 UTC (permalink / raw)
To: gcc-patches, Andrew Stubbs
[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]
This patch avoids assembler warnings for gfx908 and gfx90a such as
'-xnack-mattr=-sramecc' is not a recognized feature for this target(ignoring feature)
as we pass -mattr=-xnack-mattr=-sramecc to the llvm-mc assembler.
Solution: Add a space before the second '-mattr='.
OK for mainline?
Tobias
[-- Attachment #2: fix-gcn-hsa.diff --]
[-- Type: text/x-patch, Size: 702 bytes --]
gcn: Add missing space to ASM_SPEC in gcn-hsa.h
gcc/
* config/gcn/gcn-hsa.h (ASM_SPEC): Add space after -mxnack= argument.
diff --git a/gcc/config/gcn/gcn-hsa.h b/gcc/config/gcn/gcn-hsa.h
index bf7079fbbc6..f5de0d2969f 100644
--- a/gcc/config/gcn/gcn-hsa.h
+++ b/gcc/config/gcn/gcn-hsa.h
@@ -89,7 +89,7 @@ extern unsigned int gcn_local_sym_hash (const char *name);
#define ASM_SPEC "-triple=amdgcn--amdhsa " \
"%{march=*:-mcpu=%*} " \
"%{!march=*|march=fiji:--amdhsa-code-object-version=3} " \
- "%{" NO_XNACK XNACKOPT "}" \
+ "%{" NO_XNACK XNACKOPT "} " \
"%{" NO_SRAM_ECC SRAMOPT "} " \
"%{march=gfx1030|march=gfx1100:-mattr=+wavefrontsize64} " \
"-filetype=obj"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] gcn: Add missing space to ASM_SPEC in gcn-hsa.h
2024-01-25 12:44 [patch] gcn: Add missing space to ASM_SPEC in gcn-hsa.h Tobias Burnus
@ 2024-01-25 14:34 ` Andrew Stubbs
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Stubbs @ 2024-01-25 14:34 UTC (permalink / raw)
To: Tobias Burnus, gcc-patches
On 25/01/2024 12:44, Tobias Burnus wrote:
> This patch avoids assembler warnings for gfx908 and gfx90a such as
> '-xnack-mattr=-sramecc' is not a recognized feature for this target(ignoring feature)
> as we pass -mattr=-xnack-mattr=-sramecc to the llvm-mc assembler.
>
> Solution: Add a space before the second '-mattr='.
>
> OK for mainline?
OK.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-25 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-25 12:44 [patch] gcn: Add missing space to ASM_SPEC in gcn-hsa.h Tobias Burnus
2024-01-25 14:34 ` Andrew Stubbs
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).