public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] testsuite: Skip intrinsics test if arm
Date: Thu, 12 Jan 2023 15:03:31 +0000	[thread overview]
Message-ID: <8ebf2146-bdef-1208-a32b-c89bcf0e16ee@foss.arm.com> (raw)
In-Reply-To: <20220919161657.4103924-1-torbjorn.svensson@foss.st.com>



On 19/09/2022 17:16, Torbjörn SVENSSON via Gcc-patches wrote:
> In the test case, it's clearly written that intrinsics is not
> implemented on arm*. A simple xfail does not help since there are
> link error and that would cause an UNRESOLVED testcase rather than
> XFAIL.
> By chaning to dg-skip-if, the entire test case is omitted.
> 
> gcc/testsuite/ChangeLog:
> 
> 	* gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Replace
> 	dg-xfail-if with gd-skip-if.

Sorry for the delay reviewing this, I missed it at the time.

My problem with your suggested solution is that if these intrinsics are 
ever added this test will not automatically pick this up as it will have 
been disabled.  I presume from the comment (and the body of the test 
that contains an #ifdef for aarch64) that this is expected to be a 
temporary issue rather than something permanent.

So IMO I think it is correct to leave this as unresolved because the 
test cannot be built due to an issue with the compiler.

R.

> 
> Co-Authored-By: Yvan ROUX  <yvan.roux@foss.st.com>
> Signed-off-by: Torbjörn SVENSSON  <torbjorn.svensson@foss.st.com>
> ---
>   gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> index 92a139bc523..f933102be47 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c
> @@ -1,6 +1,6 @@
>   /* We haven't implemented these intrinsics for arm yet.  */
> -/* { dg-xfail-if "" { arm*-*-* } } */
>   /* { dg-do run } */
> +/* { dg-skip-if "unsupported" { arm*-*-* } } */
>   /* { dg-options "-O3" } */
>   
>   #include <arm_neon.h>

  reply	other threads:[~2023-01-12 15:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 16:16 Torbjörn SVENSSON
2023-01-12 15:03 ` Richard Earnshaw [this message]
2023-01-15 17:06   ` Torbjorn SVENSSON
2023-01-17 17:07     ` Richard Earnshaw
2022-09-27 14:40 Torbjörn SVENSSON
2022-09-28  8:51 ` Kyrylo Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ebf2146-bdef-1208-a32b-c89bcf0e16ee@foss.arm.com \
    --to=richard.earnshaw@foss.arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=torbjorn.svensson@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).