From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 4ECF23858C66 for ; Thu, 12 Jan 2023 15:03:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4ECF23858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 125F213D5; Thu, 12 Jan 2023 07:04:15 -0800 (PST) Received: from [10.57.37.91] (unknown [10.57.37.91]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6DBB73F587; Thu, 12 Jan 2023 07:03:32 -0800 (PST) Message-ID: <8ebf2146-bdef-1208-a32b-c89bcf0e16ee@foss.arm.com> Date: Thu, 12 Jan 2023 15:03:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] testsuite: Skip intrinsics test if arm Content-Language: en-GB To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gcc-patches@gcc.gnu.org References: <20220919161657.4103924-1-torbjorn.svensson@foss.st.com> From: Richard Earnshaw In-Reply-To: <20220919161657.4103924-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3495.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19/09/2022 17:16, Torbjörn SVENSSON via Gcc-patches wrote: > In the test case, it's clearly written that intrinsics is not > implemented on arm*. A simple xfail does not help since there are > link error and that would cause an UNRESOLVED testcase rather than > XFAIL. > By chaning to dg-skip-if, the entire test case is omitted. > > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Replace > dg-xfail-if with gd-skip-if. Sorry for the delay reviewing this, I missed it at the time. My problem with your suggested solution is that if these intrinsics are ever added this test will not automatically pick this up as it will have been disabled. I presume from the comment (and the body of the test that contains an #ifdef for aarch64) that this is expected to be a temporary issue rather than something permanent. So IMO I think it is correct to leave this as unresolved because the test cannot be built due to an issue with the compiler. R. > > Co-Authored-By: Yvan ROUX > Signed-off-by: Torbjörn SVENSSON > --- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > index 92a139bc523..f933102be47 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > -/* { dg-xfail-if "" { arm*-*-* } } */ > /* { dg-do run } */ > +/* { dg-skip-if "unsupported" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > #include