From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 949393858415 for ; Fri, 11 Aug 2023 15:32:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 949393858415 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691767946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MCuyqH2EQtLYyTelVAexvqtNZtF2VJTPm1P8a46ptCU=; b=g2zAuIqMALw6EotLX6ssWF6QnviA3U/HvqfQt0TQnqof0BwRCVXfmWaHhON53uEH5gel2f jZmmCDYV6MU14vv/99WlF8w0jIw/HkrrgeZUImrKpknoxrXgquo+IbgDFna3608nkUKrD+ 14sz6cGLuQUdpB6mnh6i2Y0MvsCg6g4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-532-JO760tR5PYeitEax4No_fQ-1; Fri, 11 Aug 2023 11:32:24 -0400 X-MC-Unique: JO760tR5PYeitEax4No_fQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-63d1bd6dfebso27574326d6.1 for ; Fri, 11 Aug 2023 08:32:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691767941; x=1692372741; h=in-reply-to:from:to:references:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=adMWJf2zZfG9DnQjo9LLX77TYRhSaEf/f4a6L2CjL6A=; b=YffR4653jG6YxFTGJZC04ikofr1eUG7uX9vFWldJTFI94RicVMDtVOl+ukD44o+q+0 1rFy7jU/U0CKutsuLxvuShNa+tykbbVMZ28DmLPhTapTzkcJnKFu1vt8mLVdLC+8HX/f urNVsp3wADBadgCLquAs9UP7izqEcIZLcJKNMoeXLJYca1MKd/C4A2noqz0IzeCy47rT +jrD/Fbd4U5Jb0etRasDy6NO4HK9KdIX8zBxGDYtCm/es1Pt/X/MqoWqpBIJ9Nz8fPFh BkdecWhI6coHzBiHpcNTiYt6TacPWyMPwCBuUiKRB1k+ueN5GBkGpxvnPqX8SfMPreRT BRXw== X-Gm-Message-State: AOJu0YxNbsDB7zDClpAmOWfUt0cybafxAUsjZxiNQjlQvArOaaFkwyG5 solbedQm7KK3HgunI8BbUhJSi4iiPDPwemHFPPBK+E3egt+mMIuCYowNNMnLRSX8lkRaSmuOpgo YGqIqyeObKVYZGXtTt+/D2pm1kqn+V8ixtsI19N8NcBsaSJVvBdC97vAS//NwSepxE51qdkZSun 2nqg== X-Received: by 2002:a05:620a:394a:b0:76c:a8a2:aad2 with SMTP id qs10-20020a05620a394a00b0076ca8a2aad2mr2249433qkn.34.1691767941339; Fri, 11 Aug 2023 08:32:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGn+AP1TfDSldmZYiN099knGnd0PTC742hAESdQ2H/O/T2FN9KBEMzPAz3WTZhgZbCzHmEAAw== X-Received: by 2002:a05:620a:394a:b0:76c:a8a2:aad2 with SMTP id qs10-20020a05620a394a00b0076ca8a2aad2mr2249412qkn.34.1691767940999; Fri, 11 Aug 2023 08:32:20 -0700 (PDT) Received: from [192.168.1.88] (192-0-143-139.cpe.teksavvy.com. [192.0.143.139]) by smtp.gmail.com with ESMTPSA id h3-20020a37c443000000b0076825e43d98sm1249124qkm.125.2023.08.11.08.32.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Aug 2023 08:32:20 -0700 (PDT) Message-ID: <8eda93dc-9cf8-c221-0f37-4cd604cc8808@redhat.com> Date: Fri, 11 Aug 2023 11:32:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: [pushed][LRA]: Implement output stack pointer reloads References: To: "gcc-patches@gcc.gnu.org" From: Vladimir Makarov In-Reply-To: X-Forwarded-Message-Id: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------ujP5VyVakSovim4wDucAxDFV" Content-Language: en-US X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------ujP5VyVakSovim4wDucAxDFV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sorry, I had some problems with email.  Therefore there are email duplication and they were sent to gcc@gcc.gnu.org instead of gcc-patches@gcc.gnu.org On 8/9/23 16:54, Vladimir Makarov wrote: > > On 8/9/23 07:15, SenthilKumar.Selvaraj@microchip.com wrote: >> Hi, >> >>    After turning on FP -> SP elimination after Vlad fixed >>    an elimination issue in >> https://gcc.gnu.org/git?p=gcc.git;a=commit;h=2971ff7b1d564ac04b537d907c70e6093af70832, >>    I'm now running into reload failure if arithmetic is done on SP. >> > I think we can permit to stack pointer output reloads.  The only thing > we need to update sp offset accurately for the original and reload > insns.  I'll try to make the patch on this week. > > The following patch fixes the problem.  The patch was successfully bootstrapped and tested on x86_64, aarch64, and ppc64le. The test case is actually one from GCC test suite. --------------ujP5VyVakSovim4wDucAxDFV Content-Type: text/x-patch; charset=UTF-8; name="lra-output-stack-pointer-reload.patch" Content-Disposition: attachment; filename="lra-output-stack-pointer-reload.patch" Content-Transfer-Encoding: base64 Y29tbWl0IGMwMTIxMDgzZDA3ZmZkNGE4NDI0ZjRiZTUwZGU3NjlkOWFkMDM4NmQKQXV0aG9yOiBW bGFkaW1pciBOLiBNYWthcm92IDx2bWFrYXJvdkByZWRoYXQuY29tPgpEYXRlOiAgIEZyaSBBdWcg MTEgMDc6NTc6MzcgMjAyMyAtMDQwMAoKICAgIFtMUkFdOiBJbXBsZW1lbnQgb3V0cHV0IHN0YWNr IHBvaW50ZXIgcmVsb2FkcwogICAgCiAgICBMUkEgcHJvaGliaXRlZCBvdXRwdXQgc3RhY2sgcG9p bnRlciByZWxvYWRzIGJ1dCBpdCByZXN1bHRlZCBpbiBMUkEKICAgIGZhaWx1cmUgZm9yIEFWUiB0 YXJnZXQgd2hpY2ggaGFzIG5vIGFyaXRobWV0aWMgaW5zbnMgd29ya2luZyB3aXRoIHRoZQogICAg c3RhY2sgcG9pbnRlciByZWdpc3Rlci4gIEdpdmVuIHBhdGNoIGltcGxlbWVudHMgdGhlIG91dHB1 dCBzdGFjawogICAgcG9pbnRlciByZWxvYWRzLgogICAgCiAgICBnY2MvQ2hhbmdlTG9nOgogICAg CiAgICAgICAgICAgICogbHJhLWNvbnN0cmFpbnRzLmNjIChnb2FsX2FsdF9vdXRfc3BfcmVsb2Fk X3ApOiBOZXcgZmxhZy4KICAgICAgICAgICAgKHByb2Nlc3NfYWx0X29wZXJhbmRzKTogU2V0IHRo ZSBmbGFnLgogICAgICAgICAgICAoY3Vycl9pbnNuX3RyYW5zZm9ybSk6IE1vZGlmeSBzdGFjayBw b2ludGVyIG9mZnNldHMgaWYgb3V0cHV0CiAgICAgICAgICAgIHN0YWNrIHBvaW50ZXIgcmVsb2Fk IGlzIGdlbmVyYXRlZC4KCmRpZmYgLS1naXQgYS9nY2MvbHJhLWNvbnN0cmFpbnRzLmNjIGIvZ2Nj L2xyYS1jb25zdHJhaW50cy5jYwppbmRleCAwOWZmNmRlMTY1Ny4uMjYyMzk5MDg3NDcgMTAwNjQ0 Ci0tLSBhL2djYy9scmEtY29uc3RyYWludHMuY2MKKysrIGIvZ2NjL2xyYS1jb25zdHJhaW50cy5j YwpAQCAtMTQ2Niw2ICsxNDY2LDggQEAgc3RhdGljIGludCBnb2FsX2FsdF9kb250X2luaGVyaXRf b3BzW01BWF9SRUNPR19PUEVSQU5EU107CiBzdGF0aWMgYm9vbCBnb2FsX2FsdF9zd2FwcGVkOwog LyogVGhlIGNob3NlbiBpbnNuIGFsdGVybmF0aXZlLgkgKi8KIHN0YXRpYyBpbnQgZ29hbF9hbHRf bnVtYmVyOworLyogVHJ1ZSBpZiBvdXRwdXQgcmVsb2FkIG9mIHRoZSBzdGFjayBwb2ludGVyIHNo b3VsZCBiZSBnZW5lcmF0ZWQuICAqLworc3RhdGljIGJvb2wgZ29hbF9hbHRfb3V0X3NwX3JlbG9h ZF9wOwogCiAvKiBUcnVlIGlmIHRoZSBjb3JyZXNwb25kaW5nIG9wZXJhbmQgaXMgdGhlIHJlc3Vs dCBvZiBhbiBlcXVpdmFsZW5jZQogICAgc3Vic3RpdHV0aW9uLiAgKi8KQEAgLTIxMjgsNiArMjEz MCw5IEBAIHByb2Nlc3NfYWx0X29wZXJhbmRzIChpbnQgb25seV9hbHRlcm5hdGl2ZSkKICAgaW50 IGN1cnJfYWx0X2RvbnRfaW5oZXJpdF9vcHNfbnVtOwogICAvKiBOdW1iZXJzIG9mIG9wZXJhbmRz IHdob3NlIHJlbG9hZCBwc2V1ZG9zIHNob3VsZCBub3QgYmUgaW5oZXJpdGVkLgkqLwogICBpbnQg Y3Vycl9hbHRfZG9udF9pbmhlcml0X29wc1tNQVhfUkVDT0dfT1BFUkFORFNdOworICAvKiBUcnVl IGlmIG91dHB1dCBzdGFjayBwb2ludGVyIHJlbG9hZCBzaG91bGQgYmUgZ2VuZXJhdGVkIGZvciB0 aGUgY3VycmVudAorICAgICBhbHRlcm5hdGl2ZS4gICovCisgIGJvb2wgY3Vycl9hbHRfb3V0X3Nw X3JlbG9hZF9wOwogICBydHggb3A7CiAgIC8qIFRoZSByZWdpc3RlciB3aGVuIHRoZSBvcGVyYW5k IGlzIGEgc3VicmVnIG9mIHJlZ2lzdGVyLCBvdGhlcndpc2UgdGhlCiAgICAgIG9wZXJhbmQgaXRz ZWxmLiAgKi8KQEAgLTIyMTEsNyArMjIxNiw4IEBAIHByb2Nlc3NfYWx0X29wZXJhbmRzIChpbnQg b25seV9hbHRlcm5hdGl2ZSkKIAl9CiAgICAgICByZWplY3QgKz0gc3RhdGljX3JlamVjdDsKICAg ICAgIGVhcmx5X2Nsb2JiZXJlZF9yZWdzX251bSA9IDA7Ci0KKyAgICAgIGN1cnJfYWx0X291dF9z cF9yZWxvYWRfcCA9IGZhbHNlOworICAgICAgCiAgICAgICBmb3IgKG5vcCA9IDA7IG5vcCA8IG5f b3BlcmFuZHM7IG5vcCsrKQogCXsKIAkgIGNvbnN0IGNoYXIgKnA7CkBAIC0yNjgyLDEyICsyNjg4 LDEwIEBAIHByb2Nlc3NfYWx0X29wZXJhbmRzIChpbnQgb25seV9hbHRlcm5hdGl2ZSkKIAkgICAg ICBib29sIG5vX3JlZ3NfcDsKIAogCSAgICAgIHJlamVjdCArPSBvcF9yZWplY3Q7Ci0JICAgICAg LyogTmV2ZXIgZG8gb3V0cHV0IHJlbG9hZCBvZiBzdGFjayBwb2ludGVyLiAgSXQgbWFrZXMKLQkJ IGltcG9zc2libGUgdG8gZG8gZWxpbWluYXRpb24gd2hlbiBTUCBpcyBjaGFuZ2VkIGluCi0JCSBS VEwuICAqLwotCSAgICAgIGlmIChvcCA9PSBzdGFja19wb2ludGVyX3J0eCAmJiAhIGZyYW1lX3Bv aW50ZXJfbmVlZGVkCisJICAgICAgLyogTWFyayBvdXRwdXQgcmVsb2FkIG9mIHRoZSBzdGFjayBw b2ludGVyLiAgKi8KKwkgICAgICBpZiAob3AgPT0gc3RhY2tfcG9pbnRlcl9ydHgKIAkJICAmJiBj dXJyX3N0YXRpY19pZC0+b3BlcmFuZFtub3BdLnR5cGUgIT0gT1BfSU4pCi0JCWdvdG8gZmFpbDsK KwkJY3Vycl9hbHRfb3V0X3NwX3JlbG9hZF9wID0gdHJ1ZTsKIAogCSAgICAgIC8qIElmIHRoaXMg YWx0ZXJuYXRpdmUgYXNrcyBmb3IgYSBzcGVjaWZpYyByZWcgY2xhc3MsIHNlZSBpZiB0aGVyZQog CQkgaXMgYXQgbGVhc3Qgb25lIGFsbG9jYXRhYmxlIHJlZ2lzdGVyIGluIHRoYXQgY2xhc3MuICAq LwpAQCAtMzMxNyw2ICszMzIxLDcgQEAgcHJvY2Vzc19hbHRfb3BlcmFuZHMgKGludCBvbmx5X2Fs dGVybmF0aXZlKQogCSAgZm9yIChub3AgPSAwOyBub3AgPCBjdXJyX2FsdF9kb250X2luaGVyaXRf b3BzX251bTsgbm9wKyspCiAJICAgIGdvYWxfYWx0X2RvbnRfaW5oZXJpdF9vcHNbbm9wXSA9IGN1 cnJfYWx0X2RvbnRfaW5oZXJpdF9vcHNbbm9wXTsKIAkgIGdvYWxfYWx0X3N3YXBwZWQgPSBjdXJy X3N3YXBwZWQ7CisJICBnb2FsX2FsdF9vdXRfc3BfcmVsb2FkX3AgPSBjdXJyX2FsdF9vdXRfc3Bf cmVsb2FkX3A7CiAJICBiZXN0X292ZXJhbGwgPSBvdmVyYWxsOwogCSAgYmVzdF9sb3NlcnMgPSBs b3NlcnM7CiAJICBiZXN0X3JlbG9hZF9ucmVncyA9IHJlbG9hZF9ucmVnczsKQEAgLTQ4MzYsNiAr NDg0MSwyNyBAQCBjdXJyX2luc25fdHJhbnNmb3JtIChib29sIGNoZWNrX29ubHlfcCkKIAlscmFf YXNtX2luc25fZXJyb3IgKGN1cnJfaW5zbik7CiAgICAgfQogICBscmFfcHJvY2Vzc19uZXdfaW5z bnMgKGN1cnJfaW5zbiwgYmVmb3JlLCBhZnRlciwgIkluc2VydGluZyBpbnNuIHJlbG9hZCIpOwor ICBpZiAoZ29hbF9hbHRfb3V0X3NwX3JlbG9hZF9wKQorICAgIHsKKyAgICAgIC8qIFdlIGhhdmUg YW4gb3V0cHV0IHN0YWNrIHBvaW50ZXIgcmVsb2FkIC0tIHVwZGF0ZSBzcCBvZmZzZXQ6ICovCisg ICAgICBydHggc2V0OworICAgICAgYm9vbCBkb25lX3AgPSBmYWxzZTsKKyAgICAgIHBvbHlfaW50 NjQgc3Bfb2Zmc2V0ID0gY3Vycl9pZC0+c3Bfb2Zmc2V0OworICAgICAgZm9yIChydHhfaW5zbiAq aW5zbiA9IGFmdGVyOyBpbnNuICE9IE5VTExfUlRYOyBpbnNuID0gTkVYVF9JTlNOIChpbnNuKSkK KwlpZiAoKHNldCA9IHNpbmdsZV9zZXQgKGluc24pKSAhPSBOVUxMX1JUWAorCSAgICAmJiBTRVRf REVTVCAoc2V0KSA9PSBzdGFja19wb2ludGVyX3J0eCkKKwkgIHsKKwkgICAgbHJhX2Fzc2VydCAo IWRvbmVfcCk7CisJICAgIGN1cnJfaWQtPnNwX29mZnNldCA9IDA7CisJICAgIGxyYV9pbnNuX3Jl Y29nX2RhdGFfdCBpZCA9IGxyYV9nZXRfaW5zbl9yZWNvZ19kYXRhIChpbnNuKTsKKwkgICAgaWQt PnNwX29mZnNldCA9IHNwX29mZnNldDsKKwkgICAgaWYgKGxyYV9kdW1wX2ZpbGUgIT0gTlVMTCkK KwkgICAgICBmcHJpbnRmIChscmFfZHVtcF9maWxlLAorCQkgICAgICAgIiAgICAgICAgICAgIE1v dmluZyBzcCBvZmZzZXQgZnJvbSBpbnNuICV1IHRvICV1XG4iLAorCQkgICAgICAgSU5TTl9VSUQg KGN1cnJfaW5zbiksIElOU05fVUlEIChpbnNuKSk7CisJICB9CisgICAgICBscmFfYXNzZXJ0ICgh ZG9uZV9wKTsKKyAgICB9CiAgIHJldHVybiBjaGFuZ2VfcDsKIH0KIAo= --------------ujP5VyVakSovim4wDucAxDFV--