From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 69EAD3858D1E for ; Sat, 11 Mar 2023 17:29:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69EAD3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62b.google.com with SMTP id x11so8757121pln.12 for ; Sat, 11 Mar 2023 09:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678555742; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V6HB80b3OlIF8iJOVtf2Fa6wkXPIPEl2QESX8cCHtQQ=; b=DHPD0i2BqFmyI8rjXX7RKsmyG6lTMVaoqSGinpxZOr+g2UYQziLoBRyCnHDiDCuw+A XJLXL4kJfNAm0TeV+dubwY6na/Q6LRsK3wY3pJp3MMhSJnfknYdVU4jiQghnkav4nXgM 03n03MaB/HnWQJJ0meUBMdoFA/zii6jr3/oeW0D019MgnsfCX4D7HqWnu8YVLpe06fW6 9+BXEX1/jka4vlShXGy2hbbVRKrxB9OAmKzI6ghuDnkKtwaX/mz5vzaKqSk/TZDzNTEK HEGobaxsxPCatkt6Y6dWX6SLrO4Q9KlFe2hmMm3RGrkZORp1TiH9bwpQ6bfn6DiwgiGm PfRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678555742; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V6HB80b3OlIF8iJOVtf2Fa6wkXPIPEl2QESX8cCHtQQ=; b=axMycefSR91SkXUv5Gfr3ZroHruRLQZjZtIK8xENawH9Tz31WJMHhOTKcrMkPdiX3X 6w34luBxGXqgA9NiBdMIhOXKU3lKNtgUTlyJhjLUzOnOCRURrKbB2xsMYxijaQumJ8L3 hA3LSf/XhlMXUX+LjTrZEk3Z5nsGTIojR1HERtN98gBFSmTRYclfl9TVEubCGWgoyF2n kNSo9D18IAst83p2sjpYX70YlP4c5lg4vK4Wam7om4Hpy0NYpJ1PzOCmOzZn64iic6rS C30Y4N3pkLsQaC03TrCHrDcf4kCyOQrLJhdtIoOtjx6VsOxXhPRQEeh08BEh+UTMa1gp kuIg== X-Gm-Message-State: AO0yUKVyORHWv3ujOPPzN3bARTSxCIeQc8QNq9eoodl4xVaatXfDrAwT NyAVXIhqmLfdMGX1VGUH1B8= X-Google-Smtp-Source: AK7set86vaC8DwAGW0lC6qcDLAo8S0Cegom3Wr7dYhV+7IfUTOKxgMEnfPbz/joB2VfpTN9kjHL6Iw== X-Received: by 2002:a17:903:1249:b0:19a:ad90:4223 with SMTP id u9-20020a170903124900b0019aad904223mr33133428plh.48.1678555742211; Sat, 11 Mar 2023 09:29:02 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id e8-20020a170902b78800b00198f9fa23a3sm1742809pls.287.2023.03.11.09.29.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 09:29:01 -0800 (PST) Message-ID: <8edbefac-5151-9ee8-4f86-439503c3d962@gmail.com> Date: Sat, 11 Mar 2023 10:29:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [Patch] More LLP64 fixes and __PIC__ values fixes for PE targets Content-Language: en-US To: Jonathan Yong <10walls@gmail.com>, Gcc Patch List References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/14/23 03:42, Jonathan Yong via Gcc-patches wrote: > Attached patches OK? > > 0002-gcc-testsuite-gcc.dg-fix-pic-test-case-for-PE-target.patch > > From 616e43ac41879040e73a266065874148553cddcc Mon Sep 17 00:00:00 2001 > From: Jonathan Yong<10walls@gmail.com> > Date: Tue, 14 Feb 2023 10:37:03 +0000 > Subject: [PATCH 2/2] gcc/testsuite/gcc.dg: fix pic test case for PE targets > > gcc/testsuite/ChangeLog: > > * pic-2.c: fix expected __PIC__ value. > * pic-3.c: ditto. > * pic-4.c: ditto. Please adjust your ChangeLog entries slightly, in particular, please capitalize the first letter in each ChangeLog entry. ie, fix->Fix, ditto->Ditto. Presumably the windows platforms are not always PIC and thus should not be handled in a manner similar to MIPS? Assuming that's the case, then this patch is OK with the trivial ChangeLog fixes. > > > 0001-gcc-testsuite-gcc.dg-fix-LLP64-targets.patch > > From a1fafc5a3c70684e843f5f0b6cf392ce349cb6b0 Mon Sep 17 00:00:00 2001 > From: Jonathan Yong<10walls@gmail.com> > Date: Tue, 14 Feb 2023 10:29:05 +0000 > Subject: [PATCH 1/2] gcc/testsuite/gcc.dg: fix LLP64 targets > > gcc/testsuite/ChangeLog: > > * gcc.dg/builtins-69.c: Use (long )*regex pattern to > allow long long instead of just long. > * gcc.dg/pr80163.c: use __INTPTR_TYPE__ for LLP64 tagets. OK with the trivial ChangeLog fix use->Use for the change to pr80163.c. jeff