From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Peter Bergner <bergner@linux.ibm.com>,
will schmidt <will_schmidt@vnet.ibm.com>
Cc: David Edelsohn <dje.gcc@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] rs6000: Adjust mov optabs for opaque modes [PR103353]
Date: Thu, 7 Apr 2022 17:42:08 +0800 [thread overview]
Message-ID: <8ede4a33-7955-f4e3-20ca-709988629a98@linux.ibm.com> (raw)
In-Reply-To: <757a2cba-ed78-369c-4ff8-53201e47a824@linux.ibm.com>
on 2022/4/2 5:52 AM, Peter Bergner wrote:
> On 4/1/22 3:50 PM, will schmidt wrote:
>> Is there a testcase, new or existing, that illustrates this error path?
>
> Well, the already existsing test case pr101849.c is where the issue was seen,
> but only when compiled by hand outside of the test harness and using only the
> -maltivec option and not the -mcpu=power10 that the test case uses.
>
> That said, I agree, pr101849.c should probably be copied into another test case
> file (pr103353.c) that uses options that trigger the issue so we can be sure the
> fix won't regress.
>
> Peter
>
>
Thanks for the comments, Will and Peter!
I thought of adding one case before but gave up as the case still emits error messages
which can be fragile and are not test points and I didn't find any similar test cases
for similar scenarios in powerpc test suite. Your suggestions make me consider it
seriously again. The patch v2 was just posted with one test case:
https://gcc.gnu.org/pipermail/gcc-patches/2022-April/592916.html.
Hope it looks better to you, thanks again!
BR,
Kewen
prev parent reply other threads:[~2022-04-07 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 8:38 Kewen.Lin
2022-03-15 11:36 ` PING^1 " Kewen.Lin
2022-04-01 20:50 ` will schmidt
2022-04-01 21:52 ` Peter Bergner
2022-04-07 9:42 ` Kewen.Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ede4a33-7955-f4e3-20ca-709988629a98@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).