From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 813393858C50 for ; Thu, 7 Apr 2022 09:42:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 813393858C50 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 2378LgjS013925; Thu, 7 Apr 2022 09:42:18 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f9vcghffp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Apr 2022 09:42:18 +0000 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 2378mZRM010767; Thu, 7 Apr 2022 09:42:17 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 3f9vcghff0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Apr 2022 09:42:17 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2379RKYO004974; Thu, 7 Apr 2022 09:42:15 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 3f6e491j0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Apr 2022 09:42:15 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2379TtnZ52953450 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Apr 2022 09:29:55 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDC7B42041; Thu, 7 Apr 2022 09:42:12 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CC7B14203F; Thu, 7 Apr 2022 09:42:10 +0000 (GMT) Received: from [9.200.47.76] (unknown [9.200.47.76]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 7 Apr 2022 09:42:10 +0000 (GMT) Message-ID: <8ede4a33-7955-f4e3-20ca-709988629a98@linux.ibm.com> Date: Thu, 7 Apr 2022 17:42:08 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000: Adjust mov optabs for opaque modes [PR103353] Content-Language: en-US To: Peter Bergner , will schmidt Cc: David Edelsohn , Segher Boessenkool , GCC Patches References: <26dce79a-be26-95b0-c14d-51852811969a@linux.ibm.com> <1965a581def625fdd99654f70359a558ddd63db9.camel@vnet.ibm.com> <757a2cba-ed78-369c-4ff8-53201e47a824@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <757a2cba-ed78-369c-4ff8-53201e47a824@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mvdRatyvlgXGty5X32INXo7rjzHG_IZZ X-Proofpoint-GUID: 9Vs2jg_ttPi2BlblWrb46hrwrC9mP9W_ Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-04-06_13,2022-04-06_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204070048 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 09:42:21 -0000 on 2022/4/2 5:52 AM, Peter Bergner wrote: > On 4/1/22 3:50 PM, will schmidt wrote: >> Is there a testcase, new or existing, that illustrates this error path? > > Well, the already existsing test case pr101849.c is where the issue was seen, > but only when compiled by hand outside of the test harness and using only the > -maltivec option and not the -mcpu=power10 that the test case uses. > > That said, I agree, pr101849.c should probably be copied into another test case > file (pr103353.c) that uses options that trigger the issue so we can be sure the > fix won't regress. > > Peter > > Thanks for the comments, Will and Peter! I thought of adding one case before but gave up as the case still emits error messages which can be fragile and are not test points and I didn't find any similar test cases for similar scenarios in powerpc test suite. Your suggestions make me consider it seriously again. The patch v2 was just posted with one test case: https://gcc.gnu.org/pipermail/gcc-patches/2022-April/592916.html. Hope it looks better to you, thanks again! BR, Kewen