From: Jeff Law <law@redhat.com>
To: Martin Sebor <msebor@gmail.com>, Joseph Myers <joseph@codesourcery.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c/71552 - Confusing error for incorrect struct initialization
Date: Wed, 06 Jul 2016 21:55:00 -0000 [thread overview]
Message-ID: <8eeb090d-cfb5-736d-c628-597a619128f6@redhat.com> (raw)
In-Reply-To: <57759F77.1030700@gmail.com>
On 06/30/2016 04:38 PM, Martin Sebor wrote:
> On 06/20/2016 08:52 AM, Joseph Myers wrote:
>> On Sat, 18 Jun 2016, Martin Sebor wrote:
>>
>>> The attached patch slightly changes the order in which initializers
>>> are checked for type compatibility to issue the same error for static
>>> initializers of incompatible types as for automatic objects, rather
>>> than rejecting the former for their lack of constness first.
>>
>> OK, presuming the patch has passed the usual testing.
>
> Thanks. I committed it in r237829. The reporter wants to know
> if the patch can also be backported to 5 and or 6. Should I go
> ahead?
My inclination would be no -- it's not a regression or incorrect code
generation.
jeff
next prev parent reply other threads:[~2016-07-06 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 21:47 Martin Sebor
2016-06-20 14:52 ` Joseph Myers
2016-06-30 22:55 ` Martin Sebor
2016-07-06 21:55 ` Jeff Law [this message]
2016-07-06 22:23 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eeb090d-cfb5-736d-c628-597a619128f6@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).