From: "Andris Pavēnis" <andris.pavenis@iki.fi>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH][Ada] Fix syntax errors in expect.c
Date: Sat, 19 Aug 2023 11:01:18 +0300 [thread overview]
Message-ID: <8f08933c-d988-c806-6a75-c8a12574c268@iki.fi> (raw)
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
Noticed trivial syntax errors in gcc/ada/expect.c when tried to compile gcc 13.2 as cross-compiler
for target i686-pc-msdosdjgpp.
Errors were there since
Tiedostossa, joka sisällytettiin kohdasta expect.c:54:
expect.c:Funktio ”__gnat_waitpid”:
expect.c:353:13:virhe: expected ”(” before numeric constant
353 | } else if WIFSTOPPED(status) {
| ^~~~~~~~~~
expect.c:358:1:varoitus: ei-void-tyyppisen funktion loppu saavutettu [-Wreturn-type]
358 | }
| ^
make[5]: *** [../gcc-interface/Makefile:297: expect.o] Error 1
Errors were there since commit 9e6274e0a3b60e77a42784c3fb6ef2aa3cfc071a(Wed Dec 15 19:26:50 2021
+0600)
Fixing these errors (attached patch for master branch) was not sufficient for building Ada
cross-compiler, but it fixed compiler errors.
This would perhaps qualify for trivial change, but it seems that I no more have write access (I got
it in 2015, but have not used it for a long time. Perhaps I do not really need it)
Andris
[-- Attachment #2: expect.c.patch --]
[-- Type: text/x-patch, Size: 749 bytes --]
commit 64c48aa99656e06d5728bf5837da3bbc50ae4cc5
Author: Andris Pavēnis <andris.pavenis@fmi.fi>
Date: Sat Aug 19 10:40:22 2023 +0300
Fix syntax error
gcc/ada/expect.c(__gnat_waitpid):
fix syntax errors
diff --git a/gcc/ada/expect.c b/gcc/ada/expect.c
index e6899632bc9..7333c11d954 100644
--- a/gcc/ada/expect.c
+++ b/gcc/ada/expect.c
@@ -346,11 +346,11 @@ __gnat_waitpid (int pid)
return -1;
}
- if WIFEXITED (status) {
+ if (WIFEXITED (status)) {
status = WEXITSTATUS (status);
- } else if WIFSIGNALED (status) {
+ } else if (WIFSIGNALED (status)) {
status = WTERMSIG (status);
- } else if WIFSTOPPED (status) {
+ } else if (WIFSTOPPED (status)) {
status = WSTOPSIG (status);
}
next reply other threads:[~2023-08-19 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 8:01 Andris Pavēnis [this message]
2023-09-01 13:41 ` Arnaud Charlet
2023-11-10 16:10 ` Marc Poulhiès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f08933c-d988-c806-6a75-c8a12574c268@iki.fi \
--to=andris.pavenis@iki.fi \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).