From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 41AD43857835 for ; Tue, 14 Mar 2023 16:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41AD43857835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,260,1673942400"; d="scan'208";a="104334402" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 14 Mar 2023 08:43:34 -0800 IronPort-SDR: Vwcg1Q26hW1ImXPKH/H5OvjJKdOGuumZ6iuf+ueDpDpaMVSU9nqIEWA/Wsfcp3Jr9ohbED93Mq 1tnh2cZVcWf9c3IAWUdMEZ1q8zoxoBvAcJJhK9m3yAlDAdS41hTGX3mHS2E9atr0F5+rK49WL7 GvUVSz8dxaXZFqjV3x4+vA3eAdqGtlxiev96tDbhMkzcB9BBcAG1bjEg9vZ4dFDMljzIcztJFr RMjedM0kgkNgJIoEoMJPGo4Vs/zPqKDrUf/iJzM5iIO8eDgqLFYEe94PrBG/4ZCZyc4Qm2CE8i bs8= Message-ID: <8f327803-e875-d498-f535-844bad013c4f@codesourcery.com> Date: Tue, 14 Mar 2023 10:43:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] doc: md.texi (Insn Splitting): Tweak wording for readability. Content-Language: en-US To: Hans-Peter Nilsson CC: , References: <20230314012536.2789120417@pchp3.se.axis.com> <20230314160443.AC7E420417@pchp3.se.axis.com> From: Sandra Loosemore In-Reply-To: <20230314160443.AC7E420417@pchp3.se.axis.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-15.mgc.mentorg.com (147.34.90.215) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,MEDICAL_SUBJECT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/14/23 10:04, Hans-Peter Nilsson via Gcc-patches wrote: > Thank you for the review! Updated version below with your > suggestions. This looks fine to me, from a writing perspective at least. > When spot-checking the pdf I noticed a strange > split of the page after the next after the section I > changed: last on page 484 "17.17 Including Patterns in > Machine Descriptions", there's a "(include" last on the page > and "pathname)" on top of page 485. I'm afraid this patch > triggered that. IMHO it'd be wrong to diddle with > formatting of *that* in *this* patch, instead leaving it to > a follow-up-patch. I think the obvious fix is to *not* > split up (include pathname)" because that just looks odd > even without the page end in-between. Right? Yes. I was skimming through the PDF of the GCC user manual myself last week, and noticed a *lot* of problems with both extraneous line breaks and lines that are too long and get cut off on the right in preformatted text pieces (including the option tables). I'm sure the internals manual is even worse because it's gotten much less clean-up effort than the user-facing documentation. FWIW, I consider fixes to whitespace, adding missing markup like @code, etc to be "obvious" changes in the same category as fixing typos. There's no need to ask for review of such changes, just go ahead and push them and post the patch of what you did. -Sandra