From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 8CF233858D28 for ; Thu, 2 Dec 2021 11:45:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CF233858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 315C4212CC; Thu, 2 Dec 2021 11:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1638445555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3R1RhOS9Rr89ZTjQrq1UyNhunLqLeweKrmaH16OPkms=; b=WzRcKTk/OLWOtDSF98LWdVxbrZZ81nYMzyd74tuFm25zz0TYq13Vd0SHx1aen5vqpMgadR Z1UrC/YUq6k1CH1X/AKNCYHZqoWzL7rJIXKtHNDuExAjs3hDoBSNE06RgThuZ63Bdp9iQ1 pdPmLmZpwcJWlykmV73a22ve/qK++V8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1638445555; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3R1RhOS9Rr89ZTjQrq1UyNhunLqLeweKrmaH16OPkms=; b=kamMCYMK+e4uh/k/rvZ419TP4VspNSgsmSFCxHG6iDnKKUYwGLvg7iYSTGyJfLADx72siD +ZomGMjaNJVNlVDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 119C313D73; Thu, 2 Dec 2021 11:45:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iGNJA/OxqGHWCgAAMHmgww (envelope-from ); Thu, 02 Dec 2021 11:45:55 +0000 Message-ID: <8f32d550-124c-9ed6-0ba1-a190a3f46ef0@suse.cz> Date: Thu, 2 Dec 2021 12:45:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH] Loop unswitching: support gswitch statements. Content-Language: en-US To: Andrew MacLeod , Richard Biener Cc: GCC Patches , Aldy Hernandez References: <0db1d9e8-f097-e766-a9fa-1a98c47b8115@suse.cz> <3a07ef98-d05f-dc07-2e36-a2b4ffd52936@suse.cz> <7bcc368c-3f26-4503-aec1-a3d6378e33ec@suse.cz> <561a3ffd-8973-d771-418f-76c484085cc5@suse.cz> <20265d97-6350-c234-695d-bc18e2e617b4@suse.cz> <1169b649-e3e2-36c9-f964-0b0ecd2530fa@suse.cz> <33509887-dfa3-6bb0-6fbe-cec8873f651f@suse.cz> <1423649f-7ef6-7408-36dc-4865f458b45e@redhat.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <1423649f-7ef6-7408-36dc-4865f458b45e@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 11:45:58 -0000 On 12/1/21 19:21, Andrew MacLeod wrote: > On 12/1/21 09:48, Martin Liška wrote: >> On 12/1/21 15:34, Richard Biener wrote: >>> On Wed, Dec 1, 2021 at 3:25 PM Martin Liška wrote: >>>> >>>> On 12/1/21 15:19, Richard Biener wrote: >>>>> which is compute the range of 'lhs' on edge_true into predicate->true_range, >>>>> assign that same range to ->false_range and then invert it to get the >>>>> range on the false_edge.  What I am saying is that for better precision >>>>> you should do >>>>> >>>>>        ranger->range_on_edge (predicate->false_range, edge_false, lhs); >>>>> >>>>> rather than prematurely optimize this to the inversion of the true range >>>>> since yes, ranger is CFG sensitive and only the_last_ predicate on a >>>>> long CFG path is actually inverted. >>>>> >>>>> What am I missing? >>>> >>>> I might be misunderstood, but I think it's the problem defined here: >>>> https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584605.html >>>> >>>> where I used the ranger->range_on_edge on the false_edge. >>> >>> Ah, OK.  But then even the true_edge range is possibly wrong, no? >> >> You are of course correct, I've just proved that in debugger :// >> >>> Consider >>> >>>    for (;;) >>>       { >>>           if (a < 100) >>>             if (a > 50)  // unswitch on this >>>               /* .. */ >>>           if (a < 120) >>>               /* ... */ >>>       } >>> >>> then you record [51, 99] for true_range of the a > 50 predicate and thus >>> simplification will simplify the if (a < 120) check, no? >> >> Yep. >> >>> >>> You can only record the range from the (CFG independent) a > 50 check, >>> thus [51, +INF] but of course at simplification time you can also use >>> the CFG context at each simplification location. >> >> @Andrew: How can I easily get irange based just on a stmt? Something like fold_range >> with int_range_max as the 3rd argument? >> > Sorry, I miss these things if I'm not directly CC'd a lot :-) > > So you just want to know the basic range the stmt generates without context?    Sure, what you say would be fine, but your want to initialize it to the type range: Yes, I want to know range of LHS in a gcond statement and the same for cases in a gswitch statement. > > int_range_max range (TREE_TYPE (name)); > > you can also simply trigger it using the current SSA_NAME_RANGE_INFO global  values query instead of the default current contextual one... which , if there isnt a global range, will automatically use the range of the type of the argument.. so maybe just try > > fold_range (r, stmt, get_global_range_query ()) Doing predicate->true_range = int_range_max (TREE_TYPE (lhs)); fold_range (predicate->true_range, stmt, get_global_range_query ()); predicate->true_range.debug(); gives me _Bool VARYING. Martin > > Andrew > > > >