From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id CFB923858C36; Fri, 2 Jun 2023 07:33:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CFB923858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-30ae5f2ac94so1704549f8f.1; Fri, 02 Jun 2023 00:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685691214; x=1688283214; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=b9KWHUW+tYZUmE/VpmfySEJeYLwBh7UWU2DOqEi4iOE=; b=cOAcX+TmvFY1cigdd4rJ/gGwsrQpYA5kOeIk7W009fEL51TdV3HbW1Ke1ntfbM295G KLzLscFKM+Y8A6Uc31dc9QtljBwdCZbX7IIc+B/FuI5sCC3ngYzf/HXiEmwDSvd0rjXX 1YdRaT+pIofjJ7sUyqKwOVOcXbx3abhHen6vBuLs/t2nGrN55VFtGvNABcAHElCyFuL9 pMVvjypRcP+tjeQekJZtpMNsrL5Z4fPRw7tDbYGlRUMfMmeFFKohf4LpYpjBQ+DY5fGJ kBm6I4YJHEuqTLQdfiuy3vzz8RDzXpfOLmIG+CPRJCsTSjvH7G2iqDJb22CfOmnJNG82 Kldg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685691214; x=1688283214; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b9KWHUW+tYZUmE/VpmfySEJeYLwBh7UWU2DOqEi4iOE=; b=aYFi0lAy30jZ0p+zbQHEnUelqlTSIbrm5bdc1mABAe7uoDnrinOMN9i6HJlI7RDk+O 8EBFTsjz3XqGdn/+/8q5nMNpMD2/Rd55+k3eqD2uoUHSP9hdglBoF3PvelQK+N9eTL+D W7kZZTdHtiVv1J5d8+S1t8HLmWeBGodnc5aAhTvDyim+RyTQSAC1Ir0Kq37XW4G3O/+5 NMwqBfNLT9gdLdG5V1eoR414GCmJIxBSoUAF2Pqd6M7mXSCI15sPbJ3MQboW/paC7Vvm dxsuvv3NIDNSNbV6tSqStaSHnCHOpAWv/lfjnlIeM4iOcT6rPpWoq3GRtWqTtJNifTGb SYTQ== X-Gm-Message-State: AC+VfDxgVY77cDfutNtvCzkmjXsaVVxkMZgks+BVcAdjVwpiMfcOLGKC uZbOmrj/BGFYiIYeqiuz0H4= X-Google-Smtp-Source: ACHHUZ5DIpnNOqMJDst/oB2GR3ArGuKPGwwCqy1w8YcwGe9KO0XXqtDwW+HC6sD/QQv380+fUQVYeA== X-Received: by 2002:adf:e448:0:b0:309:3a60:d791 with SMTP id t8-20020adfe448000000b003093a60d791mr3771513wrm.54.1685691213608; Fri, 02 Jun 2023 00:33:33 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:e11e:e61e:7eb2:4b4? ([2a01:e0a:1dc:b1c0:e11e:e61e:7eb2:4b4]) by smtp.gmail.com with ESMTPSA id n8-20020a5d4c48000000b00301a351a8d6sm822288wrt.84.2023.06.02.00.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 00:33:32 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------8cCdZ01emMLakHvmxI3aPcwD" Message-ID: <8f43b613-f185-8e46-8fc6-02bc286125b5@gmail.com> Date: Fri, 2 Jun 2023 09:33:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] Move std::search into algobase.h To: Jonathan Wakely Cc: Jonathan Wakely , Rainer Orth , Jonathan Wakely via Gcc-patches , libstdc++ References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------8cCdZ01emMLakHvmxI3aPcwD Content-Type: multipart/alternative; boundary="------------OdfIZASmlY6vTkRSuPoNPMQ6" --------------OdfIZASmlY6vTkRSuPoNPMQ6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I haven't been able to reproduce so far. Here is however a patch that I think will fix the problem. At least failing tests are UNRESOLVED on my system.     libstdc++: Fix broken _GLIBCXX_PARALLEL mode     Add missing include in .     Detect availability of in tests needing it to make them UNSUPPORTED     rather than PASS when header is missing.     libstdc++-v3/ChangeLog:             * include/parallel/algobase.h: Include .             * testsuite/lib/libstdc++.exp (check_effective_target_omp): New.             * testsuite/17_intro/headers/c++2011/parallel_mode.cc:             Add { dg-require-effective-target omp }.             * testsuite/17_intro/headers/c++2014/parallel_mode.cc: Likewise.             * testsuite/17_intro/headers/c++2017/parallel_mode.cc: Likewise. Ok to commit ? On 01/06/2023 23:57, Jonathan Wakely wrote: > > > On Thu, 1 Jun 2023, 21:37 François Dumont via Libstdc++, > > wrote: > > It's of course not as easy as I thought. > > I would never have detected this problem on my system because I'm > missing omp.h. > > I've implemented and added a: > > // { dg-require-effective-target omp } > > so that now those tests are UNRESOLVED rather than PASS. > > Now I've install OMP and try to rebuild lib to reproduce the failure. > > > You shouldn't need to install anything, just build gcc and don't > configure it with --disable-libgomp > I haven't used --disable-libgomp. But maybe when I run configure the 1st time it tried to detect OMP install and failed to find it as I just installed it. I'll tried to rebuild everything to see if I can eventually have those tests PASS. François --------------OdfIZASmlY6vTkRSuPoNPMQ6-- --------------8cCdZ01emMLakHvmxI3aPcwD Content-Type: text/x-patch; charset=UTF-8; name="parallel_mode.patch" Content-Disposition: attachment; filename="parallel_mode.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12My9pbmNsdWRlL3BhcmFsbGVsL2Fs Z29iYXNlLmggYi9saWJzdGRjKystdjMvaW5jbHVkZS9wYXJhbGxlbC9hbGdv YmFzZS5oCmluZGV4IDRlNGNjMGZhMGYyLi45ZTViODY1NThlNCAxMDA2NDQK LS0tIGEvbGlic3RkYysrLXYzL2luY2x1ZGUvcGFyYWxsZWwvYWxnb2Jhc2Uu aAorKysgYi9saWJzdGRjKystdjMvaW5jbHVkZS9wYXJhbGxlbC9hbGdvYmFz ZS5oCkBAIC00MSw2ICs0MSw3IEBACiAjaW5jbHVkZSA8cGFyYWxsZWwvYWxn b3JpdGhtZndkLmg+CiAjaW5jbHVkZSA8cGFyYWxsZWwvZmluZC5oPgogI2lu Y2x1ZGUgPHBhcmFsbGVsL2ZpbmRfc2VsZWN0b3JzLmg+CisjaW5jbHVkZSA8 cGFyYWxsZWwvc2VhcmNoLmg+CiAKIG5hbWVzcGFjZSBzdGQgX0dMSUJDWFhf VklTSUJJTElUWShkZWZhdWx0KQogewpkaWZmIC0tZ2l0IGEvbGlic3RkYysr LXYzL3Rlc3RzdWl0ZS8xN19pbnRyby9oZWFkZXJzL2MrKzIwMTEvcGFyYWxs ZWxfbW9kZS5jYyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMTdfaW50cm8v aGVhZGVycy9jKysyMDExL3BhcmFsbGVsX21vZGUuY2MKaW5kZXggY2NhZDc2 OTQwODMuLjdlNWMyOTk5YzdhIDEwMDY0NAotLS0gYS9saWJzdGRjKystdjMv dGVzdHN1aXRlLzE3X2ludHJvL2hlYWRlcnMvYysrMjAxMS9wYXJhbGxlbF9t b2RlLmNjCisrKyBiL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMTdfaW50cm8v aGVhZGVycy9jKysyMDExL3BhcmFsbGVsX21vZGUuY2MKQEAgLTE4LDYgKzE4 LDcgQEAKIC8vIHsgZGctb3B0aW9ucyAiLXN0ZD1nbnUrKzExIiB9CiAvLyB7 IGRnLWRvIGNvbXBpbGUgeyB0YXJnZXQgYysrMTEgfSB9CiAvLyB7IGRnLXJl cXVpcmUtbm9ybWFsLW1vZGUgIiIgfQorLy8geyBkZy1yZXF1aXJlLWVmZmVj dGl2ZS10YXJnZXQgb21wIH0KIAogI2lmIF9faGFzX2luY2x1ZGUoPG9tcC5o PikKICMgZGVmaW5lIF9HTElCQ1hYX1BBUkFMTEVMIDEKZGlmZiAtLWdpdCBh L2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMTdfaW50cm8vaGVhZGVycy9jKysy MDE0L3BhcmFsbGVsX21vZGUuY2MgYi9saWJzdGRjKystdjMvdGVzdHN1aXRl LzE3X2ludHJvL2hlYWRlcnMvYysrMjAxNC9wYXJhbGxlbF9tb2RlLmNjCmlu ZGV4IDYwNGRiZGE3YzMyLi5iYzgyOGRlMGVkNiAxMDA2NDQKLS0tIGEvbGli c3RkYysrLXYzL3Rlc3RzdWl0ZS8xN19pbnRyby9oZWFkZXJzL2MrKzIwMTQv cGFyYWxsZWxfbW9kZS5jYworKysgYi9saWJzdGRjKystdjMvdGVzdHN1aXRl LzE3X2ludHJvL2hlYWRlcnMvYysrMjAxNC9wYXJhbGxlbF9tb2RlLmNjCkBA IC0xOCw2ICsxOCw3IEBACiAvLyB7IGRnLW9wdGlvbnMgIi1zdGQ9Z251Kysx NCIgfQogLy8geyBkZy1kbyBjb21waWxlIHsgdGFyZ2V0IGMrKzE0IH0gfQog Ly8geyBkZy1yZXF1aXJlLW5vcm1hbC1tb2RlICIiIH0KKy8vIHsgZGctcmVx dWlyZS1lZmZlY3RpdmUtdGFyZ2V0IG9tcCB9CiAKICNpZiBfX2hhc19pbmNs dWRlKDxvbXAuaD4pCiAjIGRlZmluZSBfR0xJQkNYWF9QQVJBTExFTCAxCmRp ZmYgLS1naXQgYS9saWJzdGRjKystdjMvdGVzdHN1aXRlLzE3X2ludHJvL2hl YWRlcnMvYysrMjAxNy9wYXJhbGxlbF9tb2RlLmNjIGIvbGlic3RkYysrLXYz L3Rlc3RzdWl0ZS8xN19pbnRyby9oZWFkZXJzL2MrKzIwMTcvcGFyYWxsZWxf bW9kZS5jYwppbmRleCAwZmE3ZmFlOGQyNy4uN2M4MjkyNDk2NDUgMTAwNjQ0 Ci0tLSBhL2xpYnN0ZGMrKy12My90ZXN0c3VpdGUvMTdfaW50cm8vaGVhZGVy cy9jKysyMDE3L3BhcmFsbGVsX21vZGUuY2MKKysrIGIvbGlic3RkYysrLXYz L3Rlc3RzdWl0ZS8xN19pbnRyby9oZWFkZXJzL2MrKzIwMTcvcGFyYWxsZWxf bW9kZS5jYwpAQCAtMTcsNiArMTcsNyBAQAogCiAvLyB7IGRnLWRvIGNvbXBp bGUgeyB0YXJnZXQgYysrMTcgfSB9CiAvLyB7IGRnLXJlcXVpcmUtbm9ybWFs LW1vZGUgIiIgfQorLy8geyBkZy1yZXF1aXJlLWVmZmVjdGl2ZS10YXJnZXQg b21wIH0KIAogI2lmIF9faGFzX2luY2x1ZGUoPG9tcC5oPikKICMgZGVmaW5l IF9HTElCQ1hYX1BBUkFMTEVMIDEKZGlmZiAtLWdpdCBhL2xpYnN0ZGMrKy12 My90ZXN0c3VpdGUvbGliL2xpYnN0ZGMrKy5leHAgYi9saWJzdGRjKystdjMv dGVzdHN1aXRlL2xpYi9saWJzdGRjKysuZXhwCmluZGV4IGM4MzE0N2NlOTlh Li4wMjA3YTE1YzU3ZSAxMDA2NDQKLS0tIGEvbGlic3RkYysrLXYzL3Rlc3Rz dWl0ZS9saWIvbGlic3RkYysrLmV4cAorKysgYi9saWJzdGRjKystdjMvdGVz dHN1aXRlL2xpYi9saWJzdGRjKysuZXhwCkBAIC0xNDIxLDYgKzE0MjEsMTQg QEAgcHJvYyBjaGVja19lZmZlY3RpdmVfdGFyZ2V0X3R6ZGIgeyB9IHsKICAg ICB9XQogfQogCisjIFJldHVybiAxIGlmIE9NUCBpcyBhdmFpbGFibGUuCitw cm9jIGNoZWNrX2VmZmVjdGl2ZV90YXJnZXRfb21wIHsgfSB7CisgICAgcmV0 dXJuIFtjaGVja192M190YXJnZXRfcHJvcF9jYWNoZWQgZXRfb21wIHsKKwlz ZXQgY29uZCAiX19oYXNfaW5jbHVkZSg8b21wLmg+KSIKKwlyZXR1cm4gW3Yz X2NoZWNrX3ByZXByb2Nlc3Nvcl9jb25kaXRpb24gb21wICRjb25kXQorICAg IH1dCit9CisKIHNldCBhZGRpdGlvbmFsX3BydW5lcyAiIgogCiBpZiB7IFtp bmZvIGV4aXN0cyBlbnYoR0NDX1JVTlRFU1RfUEFSQUxMRUxJWkVfRElSKV0g XAo= --------------8cCdZ01emMLakHvmxI3aPcwD--