public inbox for
 help / color / mirror / Atom feed
From: Georg Johann Lay <>
To: Richard Biener <>
Subject: Re: [patch, avr] Fix PR target/99184: Wrong cast from double to 16-bit and 32-bit ints.
Date: Mon, 19 Sep 2022 10:57:03 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Am 19.09.22 um 09:51 schrieb Richard Biener:
> On Sun, Sep 18, 2022 at 7:40 PM Georg Johann Lay <> wrote:
>> Hello,
>> this patch fixed PR target/99184 which incorrectly rounded during 64-bit
>> (long) double to 16-bit and 32-bit integers.
>> The patch just removes the respective roundings from
>> and ::to_unsigned.  Luckily, LibF7 does nowhere
>> use respective functions internally, the only user is in libf7.c::f7_exp
>> which reads
>>     f7_round (qq, qq);
>>     int16_t q = f7_get_s16 (qq);
>> so that f7_get_s16() operates on an already rounded value, and therefore
>> this code works unaltered with or without rounding in to_integer.
>> The patch applies to directory
>> ./libgcc/config/avr/libf7/
>> and is the same for all GCC versions v10+.
>> Please someone with write permissions commit it to trunk and backport to
>> v12, v11, and v10 as it is a wrong-code issue.
>> The patch will fit without problems (except for ChangeLog) because there
>> is no traffic on that folder.
> Thanks, I've pushed the change.  Please in future try to send patches
> that can be applied with git am, thus use git format-patch
> Richard.

Thanks you so much.  The patch I generated with "git diff > file.diff", 
so that is not correct? The only change is that I defined extra hunks 
for asm so that one can see the function like in

  @@ -601,9 +601,6 @@ DEFUN to_integer

So git is not prepared to such hunks? Would you point me to some 
documentation on how to do it properly?



  reply	other threads:[~2022-09-19  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 17:39 [patch,avr] " Georg Johann Lay
2022-09-19  7:51 ` [patch, avr] " Richard Biener
2022-09-19  8:57   ` Georg Johann Lay [this message]
2022-09-19  9:06     ` Richard Biener
2022-09-19 14:58       ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).