From: "Kewen.Lin" <linkw@linux.ibm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Bill Schmidt <wschmidt@linux.ibm.com>,
Richard Guenther <rguenther@suse.de>,
Segher Boessenkool <segher@kernel.crashing.org>,
dje.gcc@gmail.com, Richard Sandiford <richard.sandiford@arm.com>
Subject: [PATCH 1/7 V2] ifn/optabs: Support vector load/store with length
Date: Wed, 10 Jun 2020 14:41:48 +0800 [thread overview]
Message-ID: <8f64b58b-050c-2e1c-36c6-049a07eceee7@linux.ibm.com> (raw)
In-Reply-To: <93f9e4cf-351d-5f89-65b5-7dbc97ce13b9@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
V2: Convert the length to targetm.vectorize.length_mode in
related IFN expand functions.
btw, since it depends on this hook now, it should be
committed after the hook patch if accepted in future.
gcc/ChangeLog:
2020-MM-DD Kewen Lin <linkw@gcc.gnu.org>
* doc/md.texi (lenload@var{m}@var{n}): Document.
(lenstore@var{m}@var{n}): Likewise.
* internal-fn.c (len_load_direct): New macro.
(len_store_direct): Likewise.
(expand_len_load_optab_fn): Likewise.
(expand_len_store_optab_fn): Likewise.
(direct_len_load_optab_supported_p): Likewise.
(direct_len_store_optab_supported_p): Likewise.
(expand_mask_load_optab_fn): Add handlings for lenload_optab.
(expand_mask_store_optab_fn): Add handlings for lenstore_optab.
(internal_load_fn_p): Handle IFN_LEN_LOAD.
(internal_store_fn_p): Handle IFN_LEN_STORE.
(internal_fn_stored_value_index): Handle IFN_LEN_STORE.
* internal-fn.def (LEN_LOAD): New internal function.
(LEN_STORE): Likewise.
* optabs.def (lenload_optab, lenstore_optab): New optab.
---
[-- Attachment #2: lenload_ifn_v2.patch --]
[-- Type: text/plain, Size: 8726 bytes --]
---
gcc/doc/md.texi | 16 ++++++++++++++++
gcc/internal-fn.c | 31 +++++++++++++++++++++++++++----
gcc/internal-fn.def | 6 ++++++
gcc/optabs.def | 2 ++
4 files changed, 51 insertions(+), 4 deletions(-)
diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi
index 2c67c818da5..b0c19cd3b81 100644
--- a/gcc/doc/md.texi
+++ b/gcc/doc/md.texi
@@ -5167,6 +5167,22 @@ mode @var{n}.
This pattern is not allowed to @code{FAIL}.
+@cindex @code{lenload@var{m}@var{n}} instruction pattern
+@item @samp{lenload@var{m}@var{n}}
+Perform a vector load with length from memory operand 1 of mode @var{m}
+into register operand 0. Length is provided in register operand 2 of
+mode @var{n}.
+
+This pattern is not allowed to @code{FAIL}.
+
+@cindex @code{lenstore@var{m}@var{n}} instruction pattern
+@item @samp{lenstore@var{m}@var{n}}
+Perform a vector store with length from register operand 1 of mode @var{m}
+into memory operand 0. Length is provided in register operand 2 of
+mode @var{n}.
+
+This pattern is not allowed to @code{FAIL}.
+
@cindex @code{vec_perm@var{m}} instruction pattern
@item @samp{vec_perm@var{m}}
Output a (variable) vector permutation. Operand 0 is the destination
diff --git a/gcc/internal-fn.c b/gcc/internal-fn.c
index 5e9aa60721e..f896666796e 100644
--- a/gcc/internal-fn.c
+++ b/gcc/internal-fn.c
@@ -104,10 +104,12 @@ init_internal_fns ()
#define load_lanes_direct { -1, -1, false }
#define mask_load_lanes_direct { -1, -1, false }
#define gather_load_direct { 3, 1, false }
+#define len_load_direct { -1, 2, false }
#define mask_store_direct { 3, 2, false }
#define store_lanes_direct { 0, 0, false }
#define mask_store_lanes_direct { 0, 0, false }
#define scatter_store_direct { 3, 1, false }
+#define len_store_direct { 3, 2, false }
#define unary_direct { 0, 0, true }
#define binary_direct { 0, 0, true }
#define ternary_direct { 0, 0, true }
@@ -2478,7 +2480,7 @@ expand_call_mem_ref (tree type, gcall *stmt, int index)
return fold_build2 (MEM_REF, type, addr, build_int_cst (alias_ptr_type, 0));
}
-/* Expand MASK_LOAD{,_LANES} call STMT using optab OPTAB. */
+/* Expand MASK_LOAD{,_LANES} and LEN_LOAD call STMT using optab OPTAB. */
static void
expand_mask_load_optab_fn (internal_fn, gcall *stmt, convert_optab optab)
@@ -2497,6 +2499,9 @@ expand_mask_load_optab_fn (internal_fn, gcall *stmt, convert_optab optab)
if (optab == vec_mask_load_lanes_optab)
icode = get_multi_vector_move (type, optab);
+ else if (optab == lenload_optab)
+ icode = convert_optab_handler (optab, TYPE_MODE (type),
+ targetm.vectorize.length_mode);
else
icode = convert_optab_handler (optab, TYPE_MODE (type),
TYPE_MODE (TREE_TYPE (maskt)));
@@ -2507,15 +2512,20 @@ expand_mask_load_optab_fn (internal_fn, gcall *stmt, convert_optab optab)
target = expand_expr (lhs, NULL_RTX, VOIDmode, EXPAND_WRITE);
create_output_operand (&ops[0], target, TYPE_MODE (type));
create_fixed_operand (&ops[1], mem);
- create_input_operand (&ops[2], mask, TYPE_MODE (TREE_TYPE (maskt)));
+ if (optab == lenload_optab)
+ create_convert_operand_from (&ops[2], mask, targetm.vectorize.length_mode,
+ TYPE_UNSIGNED (TREE_TYPE (maskt)));
+ else
+ create_input_operand (&ops[2], mask, TYPE_MODE (TREE_TYPE (maskt)));
expand_insn (icode, 3, ops);
if (!rtx_equal_p (target, ops[0].value))
emit_move_insn (target, ops[0].value);
}
#define expand_mask_load_lanes_optab_fn expand_mask_load_optab_fn
+#define expand_len_load_optab_fn expand_mask_load_optab_fn
-/* Expand MASK_STORE{,_LANES} call STMT using optab OPTAB. */
+/* Expand MASK_STORE{,_LANES} and LEN_STORE call STMT using optab OPTAB. */
static void
expand_mask_store_optab_fn (internal_fn, gcall *stmt, convert_optab optab)
@@ -2532,6 +2542,9 @@ expand_mask_store_optab_fn (internal_fn, gcall *stmt, convert_optab optab)
if (optab == vec_mask_store_lanes_optab)
icode = get_multi_vector_move (type, optab);
+ else if (optab == lenstore_optab)
+ icode = convert_optab_handler (optab, TYPE_MODE (type),
+ targetm.vectorize.length_mode);
else
icode = convert_optab_handler (optab, TYPE_MODE (type),
TYPE_MODE (TREE_TYPE (maskt)));
@@ -2542,11 +2555,16 @@ expand_mask_store_optab_fn (internal_fn, gcall *stmt, convert_optab optab)
reg = expand_normal (rhs);
create_fixed_operand (&ops[0], mem);
create_input_operand (&ops[1], reg, TYPE_MODE (type));
- create_input_operand (&ops[2], mask, TYPE_MODE (TREE_TYPE (maskt)));
+ if (optab == lenstore_optab)
+ create_convert_operand_from (&ops[2], mask, targetm.vectorize.length_mode,
+ TYPE_UNSIGNED (TREE_TYPE (maskt)));
+ else
+ create_input_operand (&ops[2], mask, TYPE_MODE (TREE_TYPE (maskt)));
expand_insn (icode, 3, ops);
}
#define expand_mask_store_lanes_optab_fn expand_mask_store_optab_fn
+#define expand_len_store_optab_fn expand_mask_store_optab_fn
static void
expand_ABNORMAL_DISPATCHER (internal_fn, gcall *)
@@ -3128,10 +3146,12 @@ multi_vector_optab_supported_p (convert_optab optab, tree_pair types,
#define direct_load_lanes_optab_supported_p multi_vector_optab_supported_p
#define direct_mask_load_lanes_optab_supported_p multi_vector_optab_supported_p
#define direct_gather_load_optab_supported_p convert_optab_supported_p
+#define direct_len_load_optab_supported_p direct_optab_supported_p
#define direct_mask_store_optab_supported_p direct_optab_supported_p
#define direct_store_lanes_optab_supported_p multi_vector_optab_supported_p
#define direct_mask_store_lanes_optab_supported_p multi_vector_optab_supported_p
#define direct_scatter_store_optab_supported_p convert_optab_supported_p
+#define direct_len_store_optab_supported_p direct_optab_supported_p
#define direct_while_optab_supported_p convert_optab_supported_p
#define direct_fold_extract_optab_supported_p direct_optab_supported_p
#define direct_fold_left_optab_supported_p direct_optab_supported_p
@@ -3498,6 +3518,7 @@ internal_load_fn_p (internal_fn fn)
case IFN_MASK_LOAD_LANES:
case IFN_GATHER_LOAD:
case IFN_MASK_GATHER_LOAD:
+ case IFN_LEN_LOAD:
return true;
default:
@@ -3517,6 +3538,7 @@ internal_store_fn_p (internal_fn fn)
case IFN_MASK_STORE_LANES:
case IFN_SCATTER_STORE:
case IFN_MASK_SCATTER_STORE:
+ case IFN_LEN_STORE:
return true;
default:
@@ -3577,6 +3599,7 @@ internal_fn_stored_value_index (internal_fn fn)
case IFN_MASK_STORE:
case IFN_SCATTER_STORE:
case IFN_MASK_SCATTER_STORE:
+ case IFN_LEN_STORE:
return 3;
default:
diff --git a/gcc/internal-fn.def b/gcc/internal-fn.def
index 1d190d492ff..ed6561f296a 100644
--- a/gcc/internal-fn.def
+++ b/gcc/internal-fn.def
@@ -49,11 +49,13 @@ along with GCC; see the file COPYING3. If not see
- load_lanes: currently just vec_load_lanes
- mask_load_lanes: currently just vec_mask_load_lanes
- gather_load: used for {mask_,}gather_load
+ - len_load: currently just lenload
- mask_store: currently just maskstore
- store_lanes: currently just vec_store_lanes
- mask_store_lanes: currently just vec_mask_store_lanes
- scatter_store: used for {mask_,}scatter_store
+ - len_store: currently just lenstore
- unary: a normal unary optab, such as vec_reverse_<mode>
- binary: a normal binary optab, such as vec_interleave_lo_<mode>
@@ -127,6 +129,8 @@ DEF_INTERNAL_OPTAB_FN (GATHER_LOAD, ECF_PURE, gather_load, gather_load)
DEF_INTERNAL_OPTAB_FN (MASK_GATHER_LOAD, ECF_PURE,
mask_gather_load, gather_load)
+DEF_INTERNAL_OPTAB_FN (LEN_LOAD, ECF_PURE, lenload, len_load)
+
DEF_INTERNAL_OPTAB_FN (SCATTER_STORE, 0, scatter_store, scatter_store)
DEF_INTERNAL_OPTAB_FN (MASK_SCATTER_STORE, 0,
mask_scatter_store, scatter_store)
@@ -136,6 +140,8 @@ DEF_INTERNAL_OPTAB_FN (STORE_LANES, ECF_CONST, vec_store_lanes, store_lanes)
DEF_INTERNAL_OPTAB_FN (MASK_STORE_LANES, 0,
vec_mask_store_lanes, mask_store_lanes)
+DEF_INTERNAL_OPTAB_FN (LEN_STORE, 0, lenstore, len_store)
+
DEF_INTERNAL_OPTAB_FN (WHILE_ULT, ECF_CONST | ECF_NOTHROW, while_ult, while)
DEF_INTERNAL_OPTAB_FN (CHECK_RAW_PTRS, ECF_CONST | ECF_NOTHROW,
check_raw_ptrs, check_ptrs)
diff --git a/gcc/optabs.def b/gcc/optabs.def
index 0c64eb52a8d..0551a191ad0 100644
--- a/gcc/optabs.def
+++ b/gcc/optabs.def
@@ -97,6 +97,8 @@ OPTAB_CD(scatter_store_optab, "scatter_store$a$b")
OPTAB_CD(mask_scatter_store_optab, "mask_scatter_store$a$b")
OPTAB_CD(vec_extract_optab, "vec_extract$a$b")
OPTAB_CD(vec_init_optab, "vec_init$a$b")
+OPTAB_CD(lenload_optab, "lenload$a$b")
+OPTAB_CD(lenstore_optab, "lenstore$a$b")
OPTAB_CD (while_ult_optab, "while_ult$a$b")
--
next prev parent reply other threads:[~2020-06-10 6:41 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 5:49 [PATCH 0/7] " Kewen.Lin
2020-05-26 5:51 ` [PATCH 1/7] ifn/optabs: " Kewen.Lin
2020-06-10 6:41 ` Kewen.Lin [this message]
2020-06-10 9:22 ` [PATCH 1/7 V2] " Richard Sandiford
2020-06-10 12:36 ` [PATCH 1/7 V3] " Kewen.Lin
2020-06-22 8:51 ` [PATCH 1/7 V4] " Kewen.Lin
2020-06-22 19:59 ` Richard Sandiford
2020-06-22 22:19 ` Segher Boessenkool
2020-06-23 3:54 ` [PATCH 1/7 v5] " Kewen.Lin
2020-06-23 9:52 ` Richard Sandiford
2020-06-23 11:25 ` Richard Biener
2020-06-23 12:20 ` Richard Sandiford
2020-06-24 2:40 ` Jim Wilson
2020-06-24 7:34 ` Richard Sandiford
2020-06-29 6:32 ` [PATCH 1/7 v6] " Kewen.Lin
2020-06-29 10:07 ` Richard Sandiford
2020-06-29 10:39 ` [PATCH 1/7 v7] " Kewen.Lin
2020-06-30 15:32 ` Richard Sandiford
2020-07-01 13:35 ` [PATCH 1/7 v8] " Kewen.Lin
2020-07-07 9:24 ` Richard Sandiford
2020-06-24 23:56 ` [PATCH 1/7 v5] " Segher Boessenkool
2020-06-23 6:47 ` [PATCH 1/7 V4] " Richard Biener
2020-05-26 5:53 ` [PATCH 2/7] rs6000: lenload/lenstore optab support Kewen.Lin
2020-06-10 6:43 ` [PATCH 2/7 V2] " Kewen.Lin
2020-06-10 12:39 ` [PATCH 2/7 V3] " Kewen.Lin
2020-06-11 22:55 ` Segher Boessenkool
2020-06-12 3:02 ` Kewen.Lin
2020-06-23 3:58 ` [PATCH 2/7 v4] " Kewen.Lin
2020-06-29 6:32 ` [PATCH 2/7 v5] " Kewen.Lin
2020-06-29 17:57 ` Segher Boessenkool
2020-05-26 5:54 ` [PATCH 3/7] vect: Factor out codes for niters smaller than vf check Kewen.Lin
2020-05-26 5:55 ` [PATCH 4/7] hook/rs6000: Add vectorize length mode for vector with length Kewen.Lin
2020-06-10 6:44 ` [PATCH 4/7 V2] " Kewen.Lin
2020-05-26 5:57 ` [PATCH 5/7] vect: Support vector load/store with length in vectorizer Kewen.Lin
2020-05-26 12:49 ` Richard Sandiford
2020-05-26 12:52 ` Richard Sandiford
2020-05-27 8:25 ` Kewen.Lin
2020-05-27 10:02 ` Richard Sandiford
2020-05-28 1:21 ` Kewen.Lin
2020-05-29 8:32 ` Richard Sandiford
2020-05-29 12:38 ` Segher Boessenkool
2020-06-02 9:03 ` [PATCH 5/7 v3] " Kewen.Lin
2020-06-02 11:50 ` Richard Sandiford
2020-06-02 17:01 ` Segher Boessenkool
2020-06-03 6:33 ` Kewen.Lin
2020-06-10 9:19 ` [PATCH 5/7 v4] " Kewen.Lin
2020-06-22 8:33 ` [PATCH 5/7 v5] " Kewen.Lin
2020-06-29 6:33 ` [PATCH 5/7 v6] " Kewen.Lin
2020-06-30 19:53 ` Richard Sandiford
2020-07-01 13:23 ` Kewen.Lin
2020-07-01 15:17 ` Richard Sandiford
2020-07-02 5:20 ` Kewen.Lin
2020-07-07 9:26 ` Kewen.Lin
2020-07-07 10:44 ` Richard Sandiford
2020-07-08 6:52 ` Kewen.Lin
2020-07-08 12:50 ` Richard Sandiford
2020-07-10 7:40 ` Kewen.Lin
2020-07-07 10:15 ` Richard Sandiford
2020-07-08 7:01 ` Kewen.Lin
2020-07-10 9:55 ` [PATCH 5/7 v7] " Kewen.Lin
2020-07-17 9:54 ` Richard Sandiford
2020-07-20 2:25 ` Kewen.Lin
2020-05-26 5:58 ` [PATCH 6/7] ivopts: Add handlings for vector with length IFNs Kewen.Lin
2020-07-22 12:51 ` Richard Sandiford
2020-05-26 5:59 ` [PATCH 7/7] rs6000/testsuite: Vector with length test cases Kewen.Lin
2020-07-10 10:07 ` [PATCH 7/7 v2] " Kewen.Lin
2020-07-20 16:58 ` Segher Boessenkool
2020-07-21 2:53 ` Kewen.Lin
2020-05-26 7:12 ` [PATCH 0/7] Support vector load/store with length Richard Biener
2020-05-26 8:51 ` Kewen.Lin
2020-05-26 9:44 ` Richard Biener
2020-05-26 10:10 ` Kewen.Lin
2020-05-26 12:29 ` Richard Sandiford
2020-05-27 0:09 ` Segher Boessenkool
2020-05-27 7:25 ` Richard Biener
2020-05-27 8:50 ` Kewen.Lin
2020-05-27 14:08 ` Segher Boessenkool
2020-05-26 22:34 ` Jim Wilson
2020-05-27 7:21 ` Richard Biener
2020-05-27 7:46 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f64b58b-050c-2e1c-36c6-049a07eceee7@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).