public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Trivial C++ PATCH to remove commented code
@ 2019-02-11 19:27 Marek Polacek
  2019-02-11 19:43 ` Jason Merrill
  0 siblings, 1 reply; 2+ messages in thread
From: Marek Polacek @ 2019-02-11 19:27 UTC (permalink / raw)
  To: Jason Merrill, GCC Patches

This I don't like.

Obvious, but ok?

2019-02-11  Marek Polacek  <polacek@redhat.com>

	* typeck2.c (digest_init_r): Remove commented code.

--- gcc/cp/typeck2.c
+++ gcc/cp/typeck2.c
@@ -1099,7 +1099,6 @@ digest_init_r (tree type, tree init, int nested, int flags,
 
       tree typ1 = TYPE_MAIN_VARIANT (TREE_TYPE (type));
       if (char_type_p (typ1)
-	  /*&& init */
 	  && TREE_CODE (stripped_init) == STRING_CST)
 	{
 	  tree char_type = TYPE_MAIN_VARIANT (TREE_TYPE (TREE_TYPE (init)));

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Trivial C++ PATCH to remove commented code
  2019-02-11 19:27 Trivial C++ PATCH to remove commented code Marek Polacek
@ 2019-02-11 19:43 ` Jason Merrill
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Merrill @ 2019-02-11 19:43 UTC (permalink / raw)
  To: Marek Polacek, GCC Patches

OK.

On 2/11/19 2:27 PM, Marek Polacek wrote:
> This I don't like.
> 
> Obvious, but ok?
> 
> 2019-02-11  Marek Polacek  <polacek@redhat.com>
> 
> 	* typeck2.c (digest_init_r): Remove commented code.
> 
> --- gcc/cp/typeck2.c
> +++ gcc/cp/typeck2.c
> @@ -1099,7 +1099,6 @@ digest_init_r (tree type, tree init, int nested, int flags,
>   
>         tree typ1 = TYPE_MAIN_VARIANT (TREE_TYPE (type));
>         if (char_type_p (typ1)
> -	  /*&& init */
>   	  && TREE_CODE (stripped_init) == STRING_CST)
>   	{
>   	  tree char_type = TYPE_MAIN_VARIANT (TREE_TYPE (TREE_TYPE (init)));
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-11 19:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 19:27 Trivial C++ PATCH to remove commented code Marek Polacek
2019-02-11 19:43 ` Jason Merrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).