From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 7BB9D3858D3C for ; Wed, 4 Oct 2023 21:35:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BB9D3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-691c05bc5aaso227787b3a.2 for ; Wed, 04 Oct 2023 14:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1696455358; x=1697060158; darn=gcc.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=oQOugrwpXy5t5F+13rT9eaV+KthwqyyN4p8lKZS03nM=; b=LKNd60MDyGc+5Z75yzeydF/zacGoL3bKG/uIiiNMmwkDAOV53uL5xAnKDaawQyCBDS ARArGQVVrGCLaf/pY2cOPfJe4DNu5xqHBHVPau3u6tv9Ocsr7Y4c1+jz6nc/AqwDocAI cYjL3oQ+eFBcGrkXqTlFowU/14O5GtMH+38d1jdC13715PoTUfoYz42i0i1yOw1cEuhy oA1dn7FRajyq/uvZifuF1LP9MO7x0w4LqwpmyjybpPLG/kmFaMynFAvKUBtBMHa/MNxg hKMaqK+xaa5N82Dbk/61zrKlIULNlhT5MN6HISmJ/C7ufJy22X5BdmaEFLLo2PBWpsuh 2L7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696455358; x=1697060158; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=oQOugrwpXy5t5F+13rT9eaV+KthwqyyN4p8lKZS03nM=; b=TzX7Ayze+Wzw1nawJF8Dp/wD6ZM/cG7XSD6L0Cf9U45nSjnj6kGbJxoU45iEcM/Wgz tS56bufzi/dcq7XkkGwQxD6iz2ZYzXm+2s9CNVvl78sCUk6iEPr4jcRIJzdMl44T9nhl 8N0LNFEGrmnlFcKDScDQ1PZPnMdf29jkt9ExSfgz6aZ1p9oA6WtJDAZN9LrDyRFMZCdR EwTQjUoYpGD5tU6h6O/RWAh2We68JAsSPzMuwwcEL5OZ0bKxasI3NZBluuOPOJSEnfyr eEXvBsRm04hnRh/KGFML/ff7ac57IFSPlW4GrM08p5DNm1NEDpIZ0coQYjHJla9t/AGP mSMA== X-Gm-Message-State: AOJu0Ywb3peZfx1kGY/xlxhrLjRASQplSdUbwQXDzs9StksLm1q8EWiu TkGLrortwBir+MiAZiiI/kTTzg== X-Google-Smtp-Source: AGHT+IFEanSsTQmTmfi83tH4+CcNyDtScIgT1N5M949QrpZN1Q/DDba/mXjoC3l0ns7xik0Z1WF/dQ== X-Received: by 2002:a05:6a20:841b:b0:13e:1945:8873 with SMTP id c27-20020a056a20841b00b0013e19458873mr4004336pzd.37.1696455358163; Wed, 04 Oct 2023 14:35:58 -0700 (PDT) Received: from ?IPV6:2601:647:5700:6860:5d01:b505:51d5:3b5e? ([2601:647:5700:6860:5d01:b505:51d5:3b5e]) by smtp.gmail.com with ESMTPSA id l4-20020a170902eb0400b001b9d7c8f44dsm13764plb.182.2023.10.04.14.35.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 14:35:57 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------HoYi8GM2oSnBDukHMJzIFHPS" Message-ID: <8fb497f5-04a9-dbd2-ced3-366f912ef174@rivosinc.com> Date: Wed, 4 Oct 2023 14:35:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RISC-V]: Re: cpymem for RISCV with v extension Content-Language: en-US To: Joern Rennecke Cc: GCC Patches , "juzhe.zhong@rivai.ai" , "kito.cheng" , "Kito.cheng" , Robin Dapp , Jeff Law References: <1525C65921357A3C+2023080507101006323211@rivai.ai> <5814e96a-9d86-d428-cf48-ec1ab80eb2d9@gmail.com> <960B8F718A41FF46+2023080507344044042924@rivai.ai> <91d19edb-6e56-b538-a0c3-3a322dba80ad@gmail.com> <1c7393c8-e17d-cf12-d051-acc9599d3669@rivosinc.com> From: Patrick O'Neill In-Reply-To: X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------HoYi8GM2oSnBDukHMJzIFHPS Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/4/23 12:19, Joern Rennecke wrote: > On Wed, 4 Oct 2023 at 18:38, Patrick O'Neill wrote: >> Hi Joern, >> >> I'm seeing new failures introduced by this patch >> (9464e72bcc9123b619215af8cfef491772a3ebd9). >> >> On rv64gcv: >> FAIL: gcc.dg/pr90263.c scan-assembler memcpy > My testing didn't flag this because I used elf targets. The > expected behaviour now is to use vector instructions for rvv. > so we shouldn't expect memcpy to appear there. I think the > rvv case is suitably covered by the new tests, so we just > have to avoid the failure here. Does the attached patch work for you? Thanks for the quick response. I'm glad to hear the behavior is expected :) The attached patch works, just needed some syntax changes: ERROR: gcc.dg/pr90263.c: error executing dg-final: syntax error in target selector "target i?86-*-* x86_64-*-* riscv_v" Diff w/ syntax changes: diff --git a/gcc/testsuite/gcc.dg/pr90263.c b/gcc/testsuite/gcc.dg/pr90263.c index 3222a5331c1..4044e6b1544 100644 --- a/gcc/testsuite/gcc.dg/pr90263.c +++ b/gcc/testsuite/gcc.dg/pr90263.c @@ -9,4 +9,4 @@ int *f (int *p, int *q, long n) } /* { dg-final { scan-assembler "mempcpy" { target { i?86-*-* x86_64-*-* } } } } */ -/* { dg-final { scan-assembler "memcpy" { target { ! { i?86-*-* x86_64-*-* } } } } } */ +/* { dg-final { scan-assembler "memcpy" { target { ! { { i?86-*-* x86_64-*-* } || { riscv_v } } } } } } */ I'll send it as a patch shortly. Patrick >> FAIL: gfortran.fortran-torture/execute/intrinsic_count.f90 execution, >> -O2 -fomit-frame-pointer -finline-functions -funroll-loops > There seems to be an issue with my test setup regarding fortran, I'll > have to investigate. --------------HoYi8GM2oSnBDukHMJzIFHPS--