From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19132 invoked by alias); 7 Oct 2018 00:11:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19106 invoked by uid 89); 7 Oct 2018 00:11:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=(unknown), HX-Received:64d5, HX-HELO:sk:mail-pg, H*r:sk:mail-pg X-HELO: mail-pg1-f169.google.com Received: from mail-pg1-f169.google.com (HELO mail-pg1-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 07 Oct 2018 00:10:59 +0000 Received: by mail-pg1-f169.google.com with SMTP id g2-v6so6255235pgu.11 for ; Sat, 06 Oct 2018 17:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to; bh=JPBNPA5lwwvcV1MM1wqdHEbW+YhJjoLodAq2vg/CwfY=; b=u4/N2yPhUUyt7wPZzrEE2bcdWyZV5ZMSrLCmwN/+6C9ewA6nFzorGapMdsj2yxYcLt +lxwpAPFXVUrvxU0Z0E56U1cq+IjTdwJHeywpuReo5nKOUoTbqadhehrfYGheG5zJd50 3VQ8MprRfcSUoQxfzj1oyVgYLgdQwAfOA12Eorb5vBv0njyjSTGmJkCLsO/c4D+DRMgK DXE5t3jXhENVBwmbD+iznvCmTfRN4xlfzwKN+GowB3MGPLnl9HC9o8bcwR57qKxM7WkC DWrv3Czp56NEc11K2PiryndPzZHSIzosanj+iP//wqBzFRfme7GoYn60WQZiZf6jsdoZ 924A== Return-Path: <10walls@gmail.com> Received: from ?IPv6:2001:e68:4075:9f8:f64d:30ff:fe63:5a5a? ([2001:e68:4075:9f8:f64d:30ff:fe63:5a5a]) by smtp.gmail.com with ESMTPSA id z22-v6sm12928388pgk.21.2018.10.06.17.10.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Oct 2018 17:10:56 -0700 (PDT) Subject: Re: introduce --enable-mingw-full32 to default to --large-address-aware To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org References: From: JonY <10walls@gmail.com> Openpgp: preference=signencrypt Message-ID: <90219030-29ad-815c-22e2-5e03398e414e@gmail.com> Date: Sun, 07 Oct 2018 08:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JzfvaWbjQQZBIgXQwV9dY1XtdSCDepHLN" X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00382.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JzfvaWbjQQZBIgXQwV9dY1XtdSCDepHLN Content-Type: multipart/mixed; boundary="d6NXmGq6U3bG4tW4YtNpyiZHiWoT8c5Sn"; protected-headers="v1" From: JonY <10walls@gmail.com> To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org Message-ID: <90219030-29ad-815c-22e2-5e03398e414e@gmail.com> Subject: Re: introduce --enable-mingw-full32 to default to --large-address-aware References: In-Reply-To: --d6NXmGq6U3bG4tW4YtNpyiZHiWoT8c5Sn Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1963 On 10/05/2018 02:18 AM, Alexandre Oliva wrote: > Add a configure knob for mingw32 and 64 toolchains to default passing > --large-address-aware to the linker, when creating 32-bit binaries. > -Wl,--disable-large-address-aware can still reverse its effects. >=20 > I've tested this with cross i686-pc-mingw32-gcc and > x86_64-w64-mingw64-gcc (is this the usual triplet name?), observing the > flags passed by gcc to the linker when asked to create an executable > program or a dynamic library, in 32- or, with the latter compiler, in > 64-bit mode. >=20 >=20 > I wonder if it makes any sense to extend/rename the configure flag to > apply to cygwin as well, though it should default to enabled for that > platform. >=20 > I also wonder if it makes sense, at this point, for mingw to default to > --large-address-aware (I guess not, but it doesn't hurt to ask, does it? > :-) >=20 > Yet another idea that comes to mind is to introduce gcc flags, say > -m32full and -m31, to imply -m32 and also pass either > --large-address-aware or --disable-large-address-aware, respectively, to > the linker. >=20 > I suppose it might also make sense to approach this issue from the > linker, rather than from GCC, enabling its default to be configured. > Would that be preferred? I thought tweaking GCC would be better, for > the flag would be visible with -v, both the one passed to the linker and > the one passed to GCC configure. It wouldn't be quite as visible as a > linker configuration knob. >=20 >=20 > Given all this, is this patch below ok to install, or should I make > changes. I've included the configure and config.in changes because > they're small enough. >=20 > Below this first patch, I enclose another patch for cygming.h. >=20 They're both OK as far as I can see. I just don't like the configure name implying all 32bit pointers are used by userspace. Perhaps just --enable-large-address-aware? Be sure to also update the documentation as Joseph says. --d6NXmGq6U3bG4tW4YtNpyiZHiWoT8c5Sn-- --JzfvaWbjQQZBIgXQwV9dY1XtdSCDepHLN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5QrdnbBX9Ppk4bbPcTtf4pwUXUUFAlu5TwcACgkQcTtf4pwU XUUzvg//aU1URr/viHqoVOGg+j+6ZiS4Wnb6DlgEBjKZErbqtnPmyIOxgRTp/mCX f87+E/nDylDoRb7Bhqrrwjxyj1OGFMvZCvTdk6E8DmOo/nAsLzucb42FKdKcvOZE 2VooccdRywUgpA8vDd105Fc9NMvlp2ppEsT8ch8ZcefVInk6xwY796Cd/6YA5CWf 67+K7Qo8p85szJKkBg1o5CPfdCzWFBOXBU4fiISHpWTqxEf1+bDgSdb0A6KtRrwy iYbLZ2sbTD3Kv1r9iMpHUSb2mjzOgr3giQhqg6GEiHQzhKQLag5tlgIU0CT+rGFC nCgosQkEWOAupoklJtJN8KwNX/bmDHmHUYHwbC3UIaz3lumL+o0pwJXyKXg3qrdV spgKCNKMQDJDLQFFPEVBTiM8z+6EphcQzZoLp2YRr5xMHcajTKOIc8t6D3HDg4Oj jlRXBeMcqy7zFn/W/smZndJCJARQQ9d6EzuobP6oLXdQqYc2udsO+Y0Y22xAB6bB jK9kZ3b4KSKSg80O2T2Dm9eprFaLj+gWZwvB2ul5Hi4AVXI4VdeYT0gP8y7saxzu 61/6AuB7A9XQmER11PsMnqB0goHWLujexz1/La5DHXL9W/2XCTh1WRfx52M5Hwz5 6ljqO3DcuaOdR5C0xSmG26Zmu4dky8S9+jZdzFPFlcmI5CJJmyc= =z1R1 -----END PGP SIGNATURE----- --JzfvaWbjQQZBIgXQwV9dY1XtdSCDepHLN--