From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C70813850427 for ; Tue, 5 Jan 2021 23:36:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C70813850427 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-05qDEokePy6FjEiO2ZAeVQ-1; Tue, 05 Jan 2021 18:36:26 -0500 X-MC-Unique: 05qDEokePy6FjEiO2ZAeVQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 78BDCE743; Tue, 5 Jan 2021 23:36:25 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-95.phx2.redhat.com [10.3.114.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3DE6471CA1; Tue, 5 Jan 2021 23:36:25 +0000 (UTC) Subject: Re: [PATCH] Add pytest for a GCOV test-case To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , David Malcolm , gcc-patches@gcc.gnu.org References: <05b7e58dc023fbea33a051a7800a214c838feeb4.camel@redhat.com> From: Jeff Law Message-ID: <9021ed74-22d4-5f2a-c60f-4e0bc63e48b6@redhat.com> Date: Tue, 5 Jan 2021 16:36:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2021 23:36:30 -0000 On 12/23/20 6:03 AM, Martin Liška wrote: > At a high level, this patch calls out to Python 3, allowing for test >> logic to be written in Python, rather than Tcl.  Are we doing this >> anywhere else in our test suite? > > No. I'm surprised.  I thought we did this for some of David's work at some point.  Clearly I'm mis-remembering. >> >> The test implicitly requires python3, and the 3rd party pytest module >> installed within it.  What happens if these aren't installed?  (ideally >> an UNSUPPORTED at the DejaGnu level, I think). > > Right now, one will see the following in the .log file: > > /usr/bin/python3: No module named pytest > > > I must confess that I don't know how to properly mark that as UNRESOLVED > in DejaGNU. I think it's just something like unresolved "could not find python interpreter $testcase" in run-gcov-pytest if you find the right magic in the output of your spawn. Jeff