From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48230 invoked by alias); 25 Oct 2016 15:18:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 47636 invoked by uid 89); 25 Oct 2016 15:18:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 15:18:24 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 801267F6D0; Tue, 25 Oct 2016 15:18:22 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-87.phx2.redhat.com [10.3.116.87]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9PFILPF020794; Tue, 25 Oct 2016 11:18:21 -0400 Subject: Re: Verify package integrity of downloaded prerequisites (partially fixes 61439) To: Moritz Klammler , Richard Biener References: <87shrle10c.fsf@klammler.eu> Cc: GCC Patches From: Jeff Law Message-ID: <9062226e-8c3a-e1cb-143d-366d7d796af8@redhat.com> Date: Tue, 25 Oct 2016 15:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <87shrle10c.fsf@klammler.eu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg02033.txt.bz2 On 10/24/2016 06:16 PM, Moritz Klammler wrote: > Jeff Law writes: > >> On 10/24/2016 02:44 AM, Richard Biener wrote: >>> On Fri, Oct 7, 2016 at 3:10 PM, Moritz Klammler wrote: >>>> I would like to bump my patch that makes the >>>> `contrib/download_prerequisites` script verify the checksums of the >>>> downloaded packages and augments it with a few additional options. >>>> All feedback I have received has been incorporated. Is it okay like >>>> this? >>>> >>>> Below is again the latest iteration of the patch. >>> >>> Looks generally ok. Can you remove -eu from the /bin/sh command and >>> leave the copyright in place? >>> >>> The patch is ok with that change. Do you have commit privileges? >> I'm pretty sure Moritz doesn't have commit privs. So I reverted the >> gratutious changes to the copyright notice and cobbled together a >> changlog and committed the result. >> >> jeff >> > > Thank you very much both of you. > > Indeed, I do not have commit privileges. In fact, this was my very > first patch to be accepted. I did went through the copyright assignment > process already, though. > > Now that the patch is applied, can this bug be closed? > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61439 Done. And ChangeLog updated to include appropriate tags. jeff