[PATCH] select isl-0.15 in download_prerequisites

[PATCH] select isl-0.15 in download_prerequisites

[VandeVondele Joost]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

For the recent fix of PR53852, isl-0.15 is needed, which is already available at ftp://gcc.gnu.org/pub/gcc/infrastructure/ . Thus, it seems to make sense to update the download_prerequisites script, as done with the attached patch.

OK for trunk ?

Joost

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch-prereq-isl.diff --]
[-- Type: text/x-patch; name="patch-prereq-isl.diff", Size: 504 bytes --]

Index: contrib/download_prerequisites
===================================================================
--- contrib/download_prerequisites	(revision 227480)
+++ contrib/download_prerequisites	(working copy)
@@ -43,7 +43,7 @@ ln -sf $MPC mpc || exit 1
 
 # Necessary to build GCC with the Graphite loop optimizations.
 if [ "$GRAPHITE_LOOP_OPT" = "yes" ] ; then
-  ISL=isl-0.14
+  ISL=isl-0.15
 
   wget ftp://gcc.gnu.org/pub/gcc/infrastructure/$ISL.tar.bz2 || exit 1
   tar xjf $ISL.tar.bz2  || exit 1

[-- Attachment #3: patch-prereq-isl-CL.txt --]
[-- Type: text/plain, Size: 123 bytes --]

contrib/ChangeLog:

2015-09-04  Joost VandeVondele  <vondele@gnu.gcc.org>

	* download_prerequisites: update to isl-0.15.

Re: [PATCH] select isl-0.15 in download_prerequisites

[Sebastian Pop]

On Fri, Sep 4, 2015 at 12:42 AM, VandeVondele  Joost
<joost.vandevondele@mat.ethz.ch> wrote:
> For the recent fix of PR53852, isl-0.15 is needed,

I just went to the documentation of isl-0.14 and I see that it also
provides the functionality to count the number of isl operations:
isl_ctx_get_max_operations().

isl-0.12.2 does not provide this functionality.

> which is already available at ftp://gcc.gnu.org/pub/gcc/infrastructure/ . Thus, it seems to make sense to update the download_prerequisites script, as done with the attached patch.
>
> OK for trunk ?

I think it is fine to bump the default version of isl to be downloaded
by default.
Are there other reviewers who would oppose committing this patch?

Thanks,
Sebastian

Re: [PATCH] select isl-0.15 in download_prerequisites

[Matthias Klose]

On 09/05/2015 02:36 PM, Sebastian Pop wrote:
> I think it is fine to bump the default version of isl to be downloaded
> by default.
> Are there other reviewers who would oppose committing this patch?

can 4.8 and 4.9 be built with isl-0.15?

RE: [PATCH] select isl-0.15 in download_prerequisites

[VandeVondele Joost]

> can 4.8 and 4.9 be built with isl-0.15?

The patch only influences an in-tree build of isl for trunk, so does it matter ?

RE: [PATCH] select isl-0.15 in download_prerequisites

[VandeVondele Joost]

> I think it is fine to bump the default version of isl to be downloaded by default.
> Are there other reviewers who would oppose committing this patch?

So, OK for trunk ? 

Re: [PATCH] select isl-0.15 in download_prerequisites

[Szabolcs Nagy]

On 05/09/15 17:46, VandeVondele Joost wrote:
>> can 4.8 and 4.9 be built with isl-0.15?
>
> The patch only influences an in-tree build of isl for trunk, so does it matter ?
>

can isl-0.15 be built with 4.8 and 4.9? ..with an old libc?

(i remember seeing isl-0.14 fail because max_align_t or something
was missing on a slightly older host toolchain..)

RE: [PATCH] select isl-0.15 in download_prerequisites

[VandeVondele Joost]

> can isl-0.15 be built with 4.8 and 4.9? ..with an old libc?

isl-0.15 builds for me with gcc 4.6.4, 4.7.4, 4.8.3, 4.9.2, not sure about older libc.

I can't find any reference to max_align_t in the isl-0.15 source.
(for me actually also isl-0.14 builds fine down to gcc 4.6).

Maybe somebody with an older toolchain could test ?