From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 809AA3858D33 for ; Wed, 22 Feb 2023 10:28:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 809AA3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31M9vx2m024106; Wed, 22 Feb 2023 10:28:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=a887muJSfcwaEY+r7ArwVgp0kC6EuoSs3PcoJwphxdY=; b=RCd3DJ7yKhxuoI8K3MJROKWENTV9ukJC6Q+NiON05GBAYp3jikiru3HNcB95IF4Un5p5 NJK/ihPMNxLR4HCtDTaETEXcn1LOI7Uqlrlt+ZRrky9Vab5eJPK48Qoh18+h9LJf6tgS jc1kYjACkN1teMla7CMshcqpsuz1i3/9OCeh72dNzSNR7Isw/iGAtwv0r2pN1UAheKjI ChawoVYe7T5OMznEnh+JKJ7IFZt2A27pbWc7lXGeJ8l5r8bGDVKvM+oBdNDamGfQD2US Rfk4Ab615ZHAS8EqECV0XKPlbOduu1HVp2oN0b13TSe9gF7S4KXcXL0lpqzRHUNw6uXd ng== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nwgvqgtsh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 10:28:23 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31MAJs5V005269; Wed, 22 Feb 2023 10:28:23 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([9.208.130.101]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3ntpa75j8g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Feb 2023 10:28:23 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31MASLl445285820 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Feb 2023 10:28:21 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 61FA458063; Wed, 22 Feb 2023 10:28:21 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CBFDE5804B; Wed, 22 Feb 2023 10:28:19 +0000 (GMT) Received: from [9.43.14.69] (unknown [9.43.14.69]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Feb 2023 10:28:19 +0000 (GMT) Message-ID: <9099872d-8cd3-c610-5ae0-2484df6572e7@linux.ibm.com> Date: Wed, 22 Feb 2023 15:58:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] rs6000: fmr gets used instead of faster xxlor [PR93571] Content-Language: en-US To: Segher Boessenkool Cc: gcc-patches , bergner@linux.ibm.com References: <16fa34b8-ad8a-20f2-b285-3b3f5bf5d5b2@linux.ibm.com> <20230217172319.GL25951@gate.crashing.org> <5f800afe-f162-0d56-3c78-6ee93610e201@linux.ibm.com> <20230221110448.GP25951@gate.crashing.org> <46ec2582-b3a8-52c9-584a-9d282d26fb79@linux.ibm.com> <20230221140927.GQ25951@gate.crashing.org> From: Ajit Agarwal In-Reply-To: <20230221140927.GQ25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: akDfH0FFuDVqNfLLnKTkwJnwp14nLrLO X-Proofpoint-ORIG-GUID: akDfH0FFuDVqNfLLnKTkwJnwp14nLrLO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-22_05,2023-02-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=343 lowpriorityscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302220088 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 21/02/23 7:39 pm, Segher Boessenkool wrote: > On Tue, Feb 21, 2023 at 06:00:52PM +0530, Ajit Agarwal wrote: >> On 21/02/23 4:34 pm, Segher Boessenkool wrote: >>> Please domn't use a switch, it isn't needed. Instead use the "isa" >>> attribute (with p7v here), and put the preferred alternative first. >> >> I am not sure how this is possible without switch and using only "isa". > > You have the "p7v" "xxlor" alternative earlier than the "*" "fmr" > alternative. You can have an "xxlor" for contraints "d", but probably > the best (and certainly the easiest) is to just move the existing > xxlor to before fmr. > > Oh, the existing xxlor alternative is implicitly isa p7v, the "wa" > constraint causes that. It may be nicer to mark it explicitly p7v as > well, nicer for the reader. > If I do the above, for power9 it selects xxlor instead of fmr. > Btw, please update the other similar patterns at the same time? There > are eight patterns with fmr in rs6000.md (the four in dfp.md should > probably not be touched); not all are similar so should be in separate > patches, if changed at all, but a bunch are completely analogous so > should not diverge. > > (It is fine to first do this one pattern only, until we have worked out > all kinks, but all should be committed at the same time). > > Thanks, > > > Segher