From: Tristan Gingold <gingold@adacore.com>
To: Iain Sandoe <developer@sandoe-acoustics.co.uk>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Arnaud Charlet <charlet@adacore.com>
Subject: Re: [Patch Darwin/PR49992 2/2] remove ranlib special-casing from the darwin port.
Date: Thu, 10 Nov 2011 14:29:00 -0000 [thread overview]
Message-ID: <90F112D2-4215-4AAB-AB63-1E56DE0CFCFE@adacore.com> (raw)
Hi Iain,
Late reply from gcc-patches archive.
You can simplify further m-lib-tgt-specific-darwin.adb as the default indexer options is nothing:
Index: mlib-tgt-specific-darwin.adb
===================================================================
--- mlib-tgt-specific-darwin.adb (revision 180458)
+++ mlib-tgt-specific-darwin.adb (working copy)
@@ -36,8 +36,6 @@
-- Non default subprograms
- function Archive_Indexer_Options return String_List_Access;
-
procedure Build_Dynamic_Library
(Ofiles : Argument_List;
Options : Argument_List;
@@ -62,15 +60,6 @@
Shared_Options : constant Argument_List :=
(1 => Shared_Libgcc'Access);
- -----------------------------
- -- Archive_Indexer_Options --
- -----------------------------
-
- function Archive_Indexer_Options return String_List_Access is
- begin
- return new String_List'(1 => new String'("-c"));
- end Archive_Indexer_Options;
-
---------------------------
-- Build_Dynamic_Library --
---------------------------
@@ -175,7 +164,6 @@
end Is_Archive_Ext;
begin
- Archive_Indexer_Options_Ptr := Archive_Indexer_Options'Access;
Build_Dynamic_Library_Ptr := Build_Dynamic_Library'Access;
DLL_Ext_Ptr := DLL_Ext'Access;
Dynamic_Option_Ptr := Dynamic_Option'Access;
I have tested this chunk together with the one you provided for Makefile.in:
Index: gcc/ada/gcc-interface/Makefile.in
===================================================================
--- gcc/ada/gcc-interface/Makefile.in (revision 179962)
+++ gcc/ada/gcc-interface/Makefile.in (working copy)
@@ -2179,7 +2179,6 @@ ifeq ($(strip $(filter-out darwin%,$(osys))),)
EH_MECHANISM=-gcc
GNATLIB_SHARED = gnatlib-shared-darwin
- RANLIB = ranlib -c
GMEM_LIB = gmemlib
LIBRARY_VERSION := $(LIB_VERSION)
soext = .dylib
and I didn't find regressions in our test suite (on x86_64-darwin).
I think you just need to rewrite the ChangeLog entry to get the OK from an Ada maintainer.
Tristan.
next reply other threads:[~2011-11-10 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 14:29 Tristan Gingold [this message]
2011-11-13 14:31 ` Iain Sandoe
2011-11-13 15:19 ` Iain Sandoe
-- strict thread matches above, loose matches on Subject: below --
2011-10-14 10:19 Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90F112D2-4215-4AAB-AB63-1E56DE0CFCFE@adacore.com \
--to=gingold@adacore.com \
--cc=charlet@adacore.com \
--cc=developer@sandoe-acoustics.co.uk \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).