[patch]: Fix argv[0] for dos based filesystem

[patch]: Fix argv[0] for dos based filesystem

[Kai Tietz]

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

Hi,

this patch is a work-a-round for the problem in spec-file parsing for
dos based file system in gcc.c (and additionally fix this for
cc1,cc1plus,...). The spec-file parser eats backslashes, because it
assumes, that they are escape sequences. For environment variables the
pre-escape by back-slashes is done, but for the relative targets on
dos based file systems the argv[0] isn't escaped.

ChangeLog

2008-05-18  Kai Tietz  <kai.tietz@onevision.com>

	* gcc.c (main): Replace backslashes by slashes
	for dos based file systems.
	* main.c (main): Likewise.

Is this patch ok for apply?

Cheers,
  Kai

-- 
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

[-- Attachment #2: dosbase.txt --]
[-- Type: text/plain, Size: 593 bytes --]

Index: gcc/gcc/gcc.c
===================================================================
--- gcc.orig/gcc/gcc.c
+++ gcc/gcc/gcc.c
@@ -6207,6 +6207,16 @@ main (int argc, char **argv)
   struct user_specs *uptr;
   char **old_argv = argv;
 
+#if HAVE_DOS_BASED_FILE_SYSTEM
+   if (argc > 0)
+     {
+	   char *pp;
+	   argv[0]=xstrdup (argv[0]);
+	   while ((pp = strchr (argv[0], '\\')) != NULL)
+		 *pp = '/';
+     }
+#endif
+
   /* Initialize here, not in definition.  The IRIX 6 O32 cc sometimes chokes
      on ?: in file-scope variable initializations.  */
   asm_debug = ASM_DEBUG_SPEC;

Re: [patch]: Fix argv[0] for dos based filesystem

[Kai Tietz]

2008/5/18 Kai Tietz <ktietz70@googlemail.com>:
> Hi,
>
> this patch is a work-a-round for the problem in spec-file parsing for
> dos based file system in gcc.c (and additionally fix this for
> cc1,cc1plus,...). The spec-file parser eats backslashes, because it
> assumes, that they are escape sequences. For environment variables the
> pre-escape by back-slashes is done, but for the relative targets on
> dos based file systems the argv[0] isn't escaped.
>
> ChangeLog
>
> 2008-05-18  Kai Tietz  <kai.tietz@onevision.com>
>
>        * gcc.c (main): Replace backslashes by slashes
>        for dos based file systems.
>        * main.c (main): Likewise.
>
> Is this patch ok for apply?
>
> Cheers,
>  Kai
>
> --
> | (\_/) This is Bunny. Copy and paste
> | (='.'=) Bunny into your signature to help
> | (")_(") him gain world domination
>

As note:

This change of behaviourwas introduced on revision 128051+ (IIUC),
while the port to use const types in gcc.

Cheers,
  Kai

-- 
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

[ping patch]: Fix argv[0] for dos based filesystem

[Kai Tietz]

> 2008/5/18 Kai Tietz <ktietz70@googlemail.com>:
> > Hi,
> >
> > this patch is a work-a-round for the problem in spec-file parsing for
> > dos based file system in gcc.c (and additionally fix this for
> > cc1,cc1plus,...). The spec-file parser eats backslashes, because it
> > assumes, that they are escape sequences. For environment variables the
> > pre-escape by back-slashes is done, but for the relative targets on
> > dos based file systems the argv[0] isn't escaped.
> >
> > ChangeLog
> >
> > 2008-05-18  Kai Tietz  <kai.tietz@onevision.com>
> >
> >        * gcc.c (main): Replace backslashes by slashes
> >        for dos based file systems.
> >        * main.c (main): Likewise.
> >
> > Is this patch ok for apply?
> 
> As note:
> 
> This change of behaviourwas introduced on revision 128051+ (IIUC),
> while the port to use const types in gcc.

Cheers,
  Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Re: [patch]: Fix argv[0] for dos based filesystem

[Tom Tromey]

>>>>> "Kai" == Kai Tietz <ktietz70@googlemail.com> writes:

Kai> 2008-05-18  Kai Tietz  <kai.tietz@onevision.com>
Kai> 	* gcc.c (main): Replace backslashes by slashes
Kai> 	for dos based file systems.
Kai> 	* main.c (main): Likewise.
Kai> Is this patch ok for apply?

This is not ok as-is.  There are some coding standards violations.

Kai> +#if HAVE_DOS_BASED_FILE_SYSTEM
Kai> +   if (argc > 0)
Kai> +     {
Kai> +	   char *pp;
Kai> +	   argv[0]=xstrdup (argv[0]);

Spaces around '='.
Also, why make a copy of argv[0] here?

Kai> +	   while ((pp = strchr (argv[0], '\\')) != NULL)
Kai> +		 *pp = '/';

Usually GNU style doesn't allow assignments in conditions.

Kai> This change of behaviourwas introduced on revision 128051+
Kai> (IIUC), while the port to use const types in gcc.

I looked at that diff to gcc.c but I don't see how it could cause a
problem.

Actually I don't really understand the bug this patch is fixing.
Could you explain more?

Tom

Re: [patch]: Fix argv[0] for dos based filesystem

[Kai Tietz]

2008/5/22 Tom Tromey <tromey@redhat.com>:
>>>>>> "Kai" == Kai Tietz <ktietz70@googlemail.com> writes:
>
> Kai> 2008-05-18  Kai Tietz  <kai.tietz@onevision.com>
> Kai>    * gcc.c (main): Replace backslashes by slashes
> Kai>    for dos based file systems.
> Kai>    * main.c (main): Likewise.
> Kai> Is this patch ok for apply?
>
> This is not ok as-is.  There are some coding standards violations.
>
> Kai> +#if HAVE_DOS_BASED_FILE_SYSTEM
> Kai> +   if (argc > 0)
> Kai> +     {
> Kai> +     char *pp;
> Kai> +     argv[0]=xstrdup (argv[0]);
>
> Spaces around '='.
> Also, why make a copy of argv[0] here?
>
> Kai> +     while ((pp = strchr (argv[0], '\\')) != NULL)
> Kai> +           *pp = '/';
>
> Usually GNU style doesn't allow assignments in conditions.
>
> Kai> This change of behaviourwas introduced on revision 128051+
> Kai> (IIUC), while the port to use const types in gcc.
>
> I looked at that diff to gcc.c but I don't see how it could cause a
> problem.
>
> Actually I don't really understand the bug this patch is fixing.
> Could you explain more?
>
> Tom
>

The problem fixed here is related to the backslashes in argv[0] on dos
based file systems. If you build gcc with option --prefix and
--with-sysroot, gcc uses argv[0] to find the location of the exec_dir.
This path is used within spec parser to relocate the tools, but it
additional eats the backslashes from the path, because they are not
quoted.

I hope I could explain the problem,

Cheers,
  Kai

-- 
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Re: [patch]: Fix argv[0] for dos based filesystem

[Mark Mitchell]

Kai Tietz wrote:

> The problem fixed here is related to the backslashes in argv[0] on dos
> based file systems. If you build gcc with option --prefix and
> --with-sysroot, gcc uses argv[0] to find the location of the exec_dir.
> This path is used within spec parser to relocate the tools, but it
> additional eats the backslashes from the path, because they are not
> quoted.
> 
> I hope I could explain the problem,

In that case, it sounds like the fix is to escape the backslashes in 
argv[0] -- probably on *all* systems -- before passing it to the specs 
system.  A directory named "x\y" (that's a literal backslash!) is 
perfectly valid on a UNIX system, and we need to escape that string 
there too.

IIRC, changing backslashes to forward slashes on Windows is not in 
general safe; at least on some older versions of the OS, some system 
functions don't work correctly.  And, you certainly confuse users; if I 
use "C:\foo\bar" as the name of a file, that's what I expect an 
application to call it too.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713