* [PATCH] Add missing parens
@ 2009-10-18 19:19 Pascal Obry
2009-10-20 17:40 ` Pascal Obry
0 siblings, 1 reply; 12+ messages in thread
From: Pascal Obry @ 2009-10-18 19:19 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
This fixes the unwinding on Win64.
ChangeLog:
2009-10-15 Pascal Obry <obry@adacore.com>
Eric Botcazou <ebotcazou@adacore.com>
* config/i386/cygming.h (DWARF_FRAME_REGNUM): Add enclosing parens.
Patch as attachement.
--
Pascal Obry
--
gpg --keyserver keys.gnupg.net --recv-key F949BD3B
[-- Attachment #2: add-missing-parens.dif --]
[-- Type: video/x-dv, Size: 945 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add missing parens
2009-10-18 19:19 [PATCH] Add missing parens Pascal Obry
@ 2009-10-20 17:40 ` Pascal Obry
2009-10-20 17:49 ` Dave Korn
0 siblings, 1 reply; 12+ messages in thread
From: Pascal Obry @ 2009-10-20 17:40 UTC (permalink / raw)
To: gcc-patches
Le 18/10/2009 21:06, Pascal Obry a écrit :
> This fixes the unwinding on Win64.
>
> ChangeLog:
>
> 2009-10-15 Pascal Obry <obry@adacore.com>
> Eric Botcazou <ebotcazou@adacore.com>
>
> * config/i386/cygming.h (DWARF_FRAME_REGNUM): Add enclosing parens.
>
> Patch as attachement.
Ping! OK to commit?
--
Pascal Obry
--
gpg --keyserver keys.gnupg.net --recv-key F949BD3B
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add missing parens
2009-10-20 17:40 ` Pascal Obry
@ 2009-10-20 17:49 ` Dave Korn
2009-10-20 17:50 ` Kai Tietz
2009-10-20 18:27 ` Pascal Obry
0 siblings, 2 replies; 12+ messages in thread
From: Dave Korn @ 2009-10-20 17:49 UTC (permalink / raw)
To: obry; +Cc: gcc-patches
Pascal Obry wrote:
> Le 18/10/2009 21:06, Pascal Obry a écrit :
>> This fixes the unwinding on Win64.
>>
>> ChangeLog:
>>
>> 2009-10-15 Pascal Obry <obry@adacore.com>
>> Eric Botcazou <ebotcazou@adacore.com>
>>
>> * config/i386/cygming.h (DWARF_FRAME_REGNUM): Add enclosing parens.
>>
>> Patch as attachement.
>
> Ping! OK to commit?
I can't approve it so I'll just observe that this patch is blatantly
obviously correct and the right thing to do even if there wasn't a bug.
cheers,
DaveK
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add missing parens
2009-10-20 17:49 ` Dave Korn
@ 2009-10-20 17:50 ` Kai Tietz
2009-10-20 18:27 ` Pascal Obry
1 sibling, 0 replies; 12+ messages in thread
From: Kai Tietz @ 2009-10-20 17:50 UTC (permalink / raw)
To: Dave Korn; +Cc: obry, gcc-patches
2009/10/20 Dave Korn <dave.korn.cygwin@googlemail.com>:
> Pascal Obry wrote:
>> Le 18/10/2009 21:06, Pascal Obry a écrit :
>>> This fixes the unwinding on Win64.
>>>
>>> ChangeLog:
>>>
>>> 2009-10-15 Pascal Obry <obry@adacore.com>
>>> Eric Botcazou <ebotcazou@adacore.com>
>>>
>>> * config/i386/cygming.h (DWARF_FRAME_REGNUM): Add enclosing parens.
>>>
>>> Patch as attachement.
>>
>> Ping! OK to commit?
>
> I can't approve it so I'll just observe that this patch is blatantly
> obviously correct and the right thing to do even if there wasn't a bug.
>
> cheers,
> DaveK
>
>
Sorry for answering that late. Ok for apply.
Thanks,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add missing parens
2009-10-20 17:49 ` Dave Korn
2009-10-20 17:50 ` Kai Tietz
@ 2009-10-20 18:27 ` Pascal Obry
2009-10-20 18:53 ` Kai Tietz
2009-10-20 21:07 ` Dave Korn
1 sibling, 2 replies; 12+ messages in thread
From: Pascal Obry @ 2009-10-20 18:27 UTC (permalink / raw)
To: Dave Korn; +Cc: gcc-patches
Dave,
> I can't approve it so I'll just observe that this patch is blatantly
> obviously correct and the right thing to do even if there wasn't a bug.
There was a bug! The dwarf2 unwinding on x86-64 Windows was broken by this.
--
Pascal Obry
--
gpg --keyserver keys.gnupg.net --recv-key F949BD3B
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add missing parens
2009-10-20 18:27 ` Pascal Obry
@ 2009-10-20 18:53 ` Kai Tietz
2009-10-20 19:16 ` Pascal Obry
2009-10-20 19:27 ` Eric Botcazou
2009-10-20 21:07 ` Dave Korn
1 sibling, 2 replies; 12+ messages in thread
From: Kai Tietz @ 2009-10-20 18:53 UTC (permalink / raw)
To: obry; +Cc: Dave Korn, gcc-patches
2009/10/20 Pascal Obry <obry@adacore.com>:
> Dave,
>
>> I can't approve it so I'll just observe that this patch is blatantly
>> obviously correct and the right thing to do even if there wasn't a bug.
>
> There was a bug! The dwarf2 unwinding on x86-64 Windows was broken by this.
>
> --
> Pascal Obry
> --
> gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>
>
>
Ok, applied to trunk with some minor changes to line-length at revision 153033.
Thanks,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add missing parens
2009-10-20 18:53 ` Kai Tietz
@ 2009-10-20 19:16 ` Pascal Obry
2009-10-20 19:27 ` Eric Botcazou
1 sibling, 0 replies; 12+ messages in thread
From: Pascal Obry @ 2009-10-20 19:16 UTC (permalink / raw)
To: Kai Tietz; +Cc: Dave Korn, gcc-patches
Kai,
> Ok, applied to trunk with some minor changes to line-length at revision 153033.
Thanks.
--
Pascal Obry
--
gpg --keyserver keys.gnupg.net --recv-key F949BD3B
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add missing parens
2009-10-20 18:53 ` Kai Tietz
2009-10-20 19:16 ` Pascal Obry
@ 2009-10-20 19:27 ` Eric Botcazou
2009-10-20 19:30 ` Kai Tietz
1 sibling, 1 reply; 12+ messages in thread
From: Eric Botcazou @ 2009-10-20 19:27 UTC (permalink / raw)
To: Kai Tietz; +Cc: gcc-patches, obry, Dave Korn
> Ok, applied to trunk with some minor changes to line-length at revision
> 153033.
Not clear why; morever they are not correct, the indentation is 2 spaces.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add missing parens
2009-10-20 19:27 ` Eric Botcazou
@ 2009-10-20 19:30 ` Kai Tietz
2009-10-21 12:00 ` Eric Botcazou
0 siblings, 1 reply; 12+ messages in thread
From: Kai Tietz @ 2009-10-20 19:30 UTC (permalink / raw)
To: Eric Botcazou; +Cc: gcc-patches, obry, Dave Korn
2009/10/20 Eric Botcazou <ebotcazou@adacore.com>:
>> Ok, applied to trunk with some minor changes to line-length at revision
>> 153033.
>
> Not clear why; morever they are not correct, the indentation is 2 spaces.
The indentation I kept, if you want you can correct it. The issue is,
that using macro DWARF_FRAME_REGNUM in case of example in dwarf2out.c
' if (DWARF_FRAME_REGNUM (i) == DWARF_FRAME_RETURN_COLUMN)' could
leads to wrong code. As there is a semantic difference between
'if ((TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i])
== DWARF_FRAME_RETURN_COLUMN)
and
if (TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i] ==
DWARF_FRAME_RETURN_COLUMN)
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] Add missing parens
2009-10-20 19:30 ` Kai Tietz
@ 2009-10-21 12:00 ` Eric Botcazou
2009-10-27 10:00 ` Kai Tietz
0 siblings, 1 reply; 12+ messages in thread
From: Eric Botcazou @ 2009-10-21 12:00 UTC (permalink / raw)
To: Kai Tietz; +Cc: gcc-patches, obry, Dave Korn
> The indentation I kept, if you want you can correct it.
No, you didn't, you replaced a correct 2-space indentation with a wrong TAB.
> The issue is,
> that using macro DWARF_FRAME_REGNUM in case of example in dwarf2out.c
> ' if (DWARF_FRAME_REGNUM (i) == DWARF_FRAME_RETURN_COLUMN)' could
> leads to wrong code. As there is a semantic difference between
> 'if ((TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i])
> == DWARF_FRAME_RETURN_COLUMN)
> and
> if (TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i] ==
> DWARF_FRAME_RETURN_COLUMN)
That's precisely the bug the patch fixed so I'm not sure what you mean...
--
Eric Botcazou
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add missing parens
2009-10-21 12:00 ` Eric Botcazou
@ 2009-10-27 10:00 ` Kai Tietz
0 siblings, 0 replies; 12+ messages in thread
From: Kai Tietz @ 2009-10-27 10:00 UTC (permalink / raw)
To: Eric Botcazou; +Cc: gcc-patches, obry, Dave Korn
2009/10/21 Eric Botcazou <ebotcazou@adacore.com>:
>> The indentation I kept, if you want you can correct it.
>
> No, you didn't, you replaced a correct 2-space indentation with a wrong TAB.
I corrected this already. Thanks for pointing it out.
>> The issue is,
>> that using macro DWARF_FRAME_REGNUM in case of example in dwarf2out.c
>> ' if (DWARF_FRAME_REGNUM (i) == DWARF_FRAME_RETURN_COLUMN)' could
>> leads to wrong code. As there is a semantic difference between
>> 'if ((TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i])
>> == DWARF_FRAME_RETURN_COLUMN)
>> and
>> if (TARGET_64BIT ? dbx64_register_map[i] : svr4_dbx_register_map[i] ==
>> DWARF_FRAME_RETURN_COLUMN)
>
> That's precisely the bug the patch fixed so I'm not sure what you mean...
>
> --
> Eric Botcazou
>
Merged to 4.4 branch at revision 153585
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] Add missing parens
2009-10-20 18:27 ` Pascal Obry
2009-10-20 18:53 ` Kai Tietz
@ 2009-10-20 21:07 ` Dave Korn
1 sibling, 0 replies; 12+ messages in thread
From: Dave Korn @ 2009-10-20 21:07 UTC (permalink / raw)
To: obry; +Cc: Dave Korn, gcc-patches
Pascal Obry wrote:
> Dave,
>
>> I can't approve it so I'll just observe that this patch is blatantly
>> obviously correct and the right thing to do even if there wasn't a bug.
>
> There was a bug! The dwarf2 unwinding on x86-64 Windows was broken by this.
>
Slightly unclear language on my part I guess; by saying that it was the
right thing to do "even if" there wasn't a bug, I was not saying that there
was not a bug, but was in fact implying that there was one!
cheers,
DaveK
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2009-10-27 9:49 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-18 19:19 [PATCH] Add missing parens Pascal Obry
2009-10-20 17:40 ` Pascal Obry
2009-10-20 17:49 ` Dave Korn
2009-10-20 17:50 ` Kai Tietz
2009-10-20 18:27 ` Pascal Obry
2009-10-20 18:53 ` Kai Tietz
2009-10-20 19:16 ` Pascal Obry
2009-10-20 19:27 ` Eric Botcazou
2009-10-20 19:30 ` Kai Tietz
2009-10-21 12:00 ` Eric Botcazou
2009-10-27 10:00 ` Kai Tietz
2009-10-20 21:07 ` Dave Korn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).