From: dnovillo@google.com
To: crowl@google.com
Cc: gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com
Subject: Re: [pph] Enable nested namespaces (issue4431071)
Date: Fri, 29 Apr 2011 23:16:00 -0000 [thread overview]
Message-ID: <90e6ba6e820a2ee33704a2161e0d@google.com> (raw)
Looks OK. Some comments below.
http://codereview.appspot.com/4431071/diff/1/gcc/c-family/c.opt
File gcc/c-family/c.opt (right):
http://codereview.appspot.com/4431071/diff/1/gcc/c-family/c.opt#newcode943
gcc/c-family/c.opt:943:
+fpph-dump-tree
+C++ Var(flag_pph_dump_tree)
+-fpph-dump-tree Dump global namespace tree around PPH reads/writes.
+
We should just add to the existing -fdump-translation-unit. Maybe not
so important now.
http://codereview.appspot.com/4431071/diff/1/gcc/cp/name-lookup.c
File gcc/cp/name-lookup.c (right):
http://codereview.appspot.com/4431071/diff/1/gcc/cp/name-lookup.c#newcode1186
gcc/cp/name-lookup.c:1186: {
+tree
+pushdecl_into_namespace (tree dcl, tree nsp)
+{
Needs comment.
http://codereview.appspot.com/4431071/
next reply other threads:[~2011-04-29 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 23:16 dnovillo [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-27 18:19 Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e6ba6e820a2ee33704a2161e0d@google.com \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).