Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047)

Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047)

[davidxl]

LGTM


http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c
File gcc/libgcov.c (right):

http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155
gcc/libgcov.c:155: filename? filename : "", e, v);
Better split it into two different printfs as the format is different --
otherwise double : will be printed.

http://codereview.appspot.com/4446047/

Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047)

[Richard Guenther]

On Mon, Apr 18, 2011 at 9:59 PM,  <davidxl@google.com> wrote:
> LGTM
>
>
> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c
> File gcc/libgcov.c (right):
>
> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155
> gcc/libgcov.c:155: filename? filename : "", e, v);
> Better split it into two different printfs as the format is different --
> otherwise double : will be printed.
>
> http://codereview.appspot.com/4446047/

I'm confused.  Can we please avoid this kind of mails?

Thanks,
Richard.

Re: [google] Avoid reading struct member from structure generated by different gcc version (issue4446047)

[Diego Novillo]

On Mon, Apr 18, 2011 at 17:24, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Mon, Apr 18, 2011 at 9:59 PM,  <davidxl@google.com> wrote:
>> LGTM
>>
>>
>> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c
>> File gcc/libgcov.c (right):
>>
>> http://codereview.appspot.com/4446047/diff/1/gcc/libgcov.c#newcode155
>> gcc/libgcov.c:155: filename? filename : "", e, v);
>> Better split it into two different printfs as the format is different --
>> otherwise double : will be printed.
>>
>> http://codereview.appspot.com/4446047/
>
> I'm confused.  Can we please avoid this kind of mails?

It's not altogether easy.  I filed an enhancement request for
Rietveld, but I'm not sure how eager they will be to implement this.
http://code.google.com/p/rietveld/issues/detail?id=291&sort=-id

Two workarounds:

- Reply to the patch using the Reply button in the web interface.
- Reply using to the initial e-mail generated by Rietveld.
- Cut and paste context from the window when replying via the web interface.

Medium/long term, we could probably install our own Rietveld instance
in gcc.gnu.org and modify it to our taste.  Either that or look for
another patch review tool.

If anyone has any other suggestions, please let me know.



Diego.