From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 88A413858C52 for ; Fri, 12 May 2023 19:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88A413858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-966287b0f72so1463125766b.0 for ; Fri, 12 May 2023 12:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683919308; x=1686511308; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=aIr2d1hNBd2YsiadeLJcdUZOlBgvqhkM9+KLATqyzf4=; b=aiAIjhGE5HGfeif9vYCDuD2PXCw5dyjwf/aFrayZ3jOu7W+tgKur8oq+SkGi1cTtne ifVUDlxuSg+VE++XeNpsLYnsVKW62YsUO/ANpDfmrx+8tfY31EsWrlx32mV9QPoJQqXD q4l5Csic/zdJMuMe2a5glTATNOtQO1uQJnVtMoTZcqrNirirL0N3/Jvn8szFpn1Vvpie ITHUYJhX3c4zfVX3iVRv1Lbaw4YgVMoqJI18/3PP8FbYEYhtCV81jh0zf637bF+TDbTI LmFiNxmY69IVi6WZ31Zo+f+XrUsRXFqm/l7BIEpCSjgSUrAFOcWG3QV9VaGMlm67Cg6I zhEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683919308; x=1686511308; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aIr2d1hNBd2YsiadeLJcdUZOlBgvqhkM9+KLATqyzf4=; b=PxFVh9MpBfWViKqsnO3H6qt84fOf9bX9rOXWh/Dxo3X3TR4EdoAxB0GH48EjLj93U0 IzyAvcQ5g/GEAVOpAdSKkZGDAunEHHcKtkzdHDa3OW969ZpnmnUyHxW1Aq0UqVSQRPOf YCe5v3Bg/X2blH+R3NNHhAaugI5HFIU25WcaJ/fZi81i2y0hgj6xlF5eQpq50YRKcdio 15O+4GnMkWj/86wkNkr4miyeHRAdshgL2cB/U0HqMX9S7KhjA1IMQkxRGwhid//t/8Ti B7ot8ksUsQL0RqQOfFlTRzGDr7fj7Bs4lepdjtemKQYMX3PdLP2AH5vShswfScbe6h5h TQqA== X-Gm-Message-State: AC+VfDxLsU0sgW1gO1L1ob2D/3V6oV4Tl3XVYMBcBftR+ddr4GHvQFfy RqSkIpmP6rt+WVED3Y/erkJvUUOYh34= X-Google-Smtp-Source: ACHHUZ4B62CoPSXOUek1a+XSCAtyXRNrkDD63HVS5u5o/t1K/C2lc/aLrrLcy5BFITiltMkMpkFfXw== X-Received: by 2002:a17:906:58c9:b0:94f:6218:191d with SMTP id e9-20020a17090658c900b0094f6218191dmr26200106ejs.32.1683919307726; Fri, 12 May 2023 12:21:47 -0700 (PDT) Received: from ?IPv6:::1? ([2001:871:227:ce8b:39de:e3d6:ecfc:f9a7]) by smtp.gmail.com with ESMTPSA id h22-20020a1709070b1600b0094f07545d40sm5811245ejl.220.2023.05.12.12.21.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 May 2023 12:21:47 -0700 (PDT) Date: Fri, 12 May 2023 21:21:44 +0200 From: Bernhard Reutner-Fischer To: gcc-patches@gcc.gnu.org, Martin Jambor , GCC Patches CC: Jan Hubicka Subject: Re: [PATCH] ipa: Self-DCE of uses of removed call LHSs (PR 108007) In-Reply-To: References: Message-ID: <9115858A-7830-4184-B16D-90314DF9A60F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12 May 2023 14:45:14 CEST, Martin Jambor wrote: >gcc/ChangeLog: > >2023-05-11 Martin Jambor > > PR ipa/108007 > * cgraph=2Eh (cgraph_edge): Add a parameter to > redirect_call_stmt_to_callee=2E > * ipa-param-manipulation=2Eh (ipa_param_adjustments): Added a > parameter to modify_call=2E > * cgraph=2Ecc (cgraph_edge::redirect_call_stmt_to_callee): New > parameter killed_ssas, pass it to padjs->modify_call=2E > * ipa-param-manipulation=2Ecc (purge_transitive_uses): New function=2E > (ipa_param_adjustments::modify_call): New parameter killed_ssas=2E > Instead of substitutin uses, invoke purge_transitive_uses=2E If > hash of killed SSAs has not been provided, create a temporary one > and release SSAs that have been added to it=2E > * tree-inline=2Ecc (redirect_all_calls): Create > id->killed_new_ssa_names earlier, pass it to edge redirection, > adjust a comment=2E > (copy_body): Release SSAs in id->killed_new_ssa_names=2E Nit: Please use present tense in the ChangeLog=2E s/Added/Add/ And there is a trailing 'g' missing in substitutin thanks,