From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 1DF20385782F for ; Wed, 14 Sep 2022 13:20:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DF20385782F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5A5BD33951; Wed, 14 Sep 2022 13:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663161614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/nR8zQ4XeluOfU2U0j1cvs9PrKh3Rg7QURvSL2Xw6c=; b=1UfAX4eRl2SOLYoumMZZkOypEfAtV//nahpkQSnSSo4ZLTtsacG1AZmn8DV5yXSzv7TIYx ngLu/uPoNHbZyS0eDpXnc3Tch9wOYMxGAAJY8b/jvcN4cYZKMD4UIIGTKxplXN2yL06pyH 8pnvlkK4TgG0wrwmtn/6b7/4BSZrRp0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663161614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/nR8zQ4XeluOfU2U0j1cvs9PrKh3Rg7QURvSL2Xw6c=; b=+dztgpx3eaDVBNsNd0bfcZCu8LZ58yrVJ6Q1N1EYl/swkTJrXakidd6eb2xidr1OKk3zBV J+9vMx7f3ZuFDxDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 41B3813494; Wed, 14 Sep 2022 13:20:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cj3sDg7VIWNRFgAAMHmgww (envelope-from ); Wed, 14 Sep 2022 13:20:14 +0000 Message-ID: <91171522-5b99-c0dd-da1c-47280be5302c@suse.cz> Date: Wed, 14 Sep 2022 15:20:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [COMMITTED] Fix unused variable warning (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality) Content-Language: en-US To: Jan-Benedict Glaw Cc: gcc-patches@gcc.gnu.org References: <10a94ccc-e01b-b98a-0fcb-cd661c10c315@suse.cz> <20220914121921.j46kmn2btdwmj3sc@lug-owl.de> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20220914121921.j46kmn2btdwmj3sc@lug-owl.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/14/22 14:19, Jan-Benedict Glaw wrote: > On Thu, 2022-09-01 12:05:23 +0200, Martin Liška wrote: >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> I've also built all cross compilers. >> >> Ready to be installed? >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >> * Makefile.in: Remove -gstabs option support, DBX-related >> macros and DBX debugging info support. > [...] >> * config/mips/mips.cc (mips_output_filename): Likewise. >> (mips_option_override): Likewise. > [...] >> diff --git a/gcc/config/mips/mips.cc b/gcc/config/mips/mips.cc >> index e81a245dcf4..47724950c3e 100644 >> --- a/gcc/config/mips/mips.cc >> +++ b/gcc/config/mips/mips.cc > [...] >> @@ -20505,24 +20500,13 @@ mips_option_override (void) >> >> for (i = 0; i < FIRST_PSEUDO_REGISTER; i++) >> { >> - mips_dbx_regno[i] = IGNORED_DWARF_REGNUM; >> if (GP_REG_P (i) || FP_REG_P (i) || ALL_COP_REG_P (i)) >> mips_dwarf_regno[i] = i; >> else >> mips_dwarf_regno[i] = INVALID_REGNUM; >> } >> >> - start = GP_DBX_FIRST - GP_REG_FIRST; >> - for (i = GP_REG_FIRST; i <= GP_REG_LAST; i++) >> - mips_dbx_regno[i] = i + start; >> - >> - start = FP_DBX_FIRST - FP_REG_FIRST; >> - for (i = FP_REG_FIRST; i <= FP_REG_LAST; i++) >> - mips_dbx_regno[i] = i + start; >> - >> /* Accumulator debug registers use big-endian ordering. */ >> - mips_dbx_regno[HI_REGNUM] = MD_DBX_FIRST + 0; >> - mips_dbx_regno[LO_REGNUM] = MD_DBX_FIRST + 1; >> mips_dwarf_regno[HI_REGNUM] = MD_REG_FIRST + 0; >> mips_dwarf_regno[LO_REGNUM] = MD_REG_FIRST + 1; >> for (i = DSP_ACC_REG_FIRST; i <= DSP_ACC_REG_LAST; i += 2) > > This leaves the `start` variable unused, resulting in a new warning. > Fixed (committed as obvious) by this: > > /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o mips.o -MT mips.o -MMD -MP -MF ./.deps/mips.TPo ../../gcc/gcc/config/mips/mips.cc > ../../gcc/gcc/config/mips/mips.cc: In function 'void mips_option_override()': > ../../gcc/gcc/config/mips/mips.cc:20021:10: error: unused variable 'start' [-Werror=unused-variable] > 20021 | int i, start, regno, mode; > | ^~~~~ > > 2022-09-14 Jan-Benedict Glaw > > gcc/ > * config/mips/mips.cc (mips_option_override): Drop unused variable. > > diff --git a/gcc/config/mips/mips.cc b/gcc/config/mips/mips.cc > index 47724950c3e..387376b3df8 100644 > --- a/gcc/config/mips/mips.cc > +++ b/gcc/config/mips/mips.cc > @@ -20018,7 +20018,7 @@ mips_set_tune (const struct mips_cpu_info *info) > static void > mips_option_override (void) > { > - int i, start, regno, mode; > + int i, regno, mode; > > if (OPTION_SET_P (mips_isa_option)) > mips_isa_option_info = &mips_cpu_info_table[mips_isa_option]; > > > Committed as obvious. > > MfG, JBG > Thanks for the commit! Cheers, Martin