From: "Lehua Ding" <lehua.ding@rivai.ai>
To: "Palmer Dabbelt" <palmer@rivosinc.com>,
"rdapp.gcc" <rdapp.gcc@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"rdapp.gcc" <rdapp.gcc@gmail.com>,
"juzhe.zhong" <juzhe.zhong@rivai.ai>,
"Kito Cheng" <kito.cheng@gmail.com>,
jeffreyalaw <jeffreyalaw@gmail.com>
Subject: Re: [PATCH V2] RISC-V: Add the missed half floating-point mode patterns of local_pic_load/store when only use zfhmin or zhinxmin
Date: Fri, 18 Aug 2023 10:40:53 +0800 [thread overview]
Message-ID: <91442F41249C722A+tencent_C9918FEA7376793887ED3C3FA0AE13668C09@qq.com> (raw)
In-Reply-To: <mhng-22780984-7889-42cd-900b-14987c7e007d@palmer-ri-x1c9a>
[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]
Committed, thanks Robin and Palmer.
------------------ Original ------------------
From: "Palmer Dabbelt" <palmer@rivosinc.com>;
Date: Fri, Aug 18, 2023 01:51 AM
To: "rdapp.gcc"<rdapp.gcc@gmail.com>;
Cc: "lehua.ding"<lehua.ding@rivai.ai>;"gcc-patches"<gcc-patches@gcc.gnu.org>;"rdapp.gcc"<rdapp.gcc@gmail.com>;"juzhe.zhong"<juzhe.zhong@rivai.ai>;"Kito Cheng"<kito.cheng@gmail.com>;"jeffreyalaw"<jeffreyalaw@gmail.com>;
Subject: Re: [PATCH V2] RISC-V: Add the missed half floating-point mode patterns of local_pic_load/store when only use zfhmin or zhinxmin
On Thu, 17 Aug 2023 10:03:04 PDT (-0700), rdapp.gcc@gmail.com wrote:
> Indeed all ANYLSF patterns have TARGET_HARD_FLOAT (==f extension) which
> is incompatible with ZHINX or ZHINXMIN anyway. That should really be fixed
> separately or at least clarified, maybe I'm missing something.
We've also got the broader issue where these PIC patterns are likely not
the way to go long term, they're just papering around some other issues
(and are likely why we flip the implicit-relocs behavior implicitly).
We should probably fix that at some point, but I don't see any reason to
block a fix on a cleanup.
That said, given that folks are poking around in here it's probably
worth putting together test cases for the other patterns in there.
> Still we can go forward with the patch itself as it improves things
> independently, so LGTM.
Ya, IMO it's fine to add these given they fix the issue.
> Regards
> Robin
prev parent reply other threads:[~2023-08-18 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 12:43 Lehua Ding
2023-08-17 17:03 ` Robin Dapp
2023-08-17 17:51 ` Palmer Dabbelt
2023-08-18 2:40 ` Lehua Ding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91442F41249C722A+tencent_C9918FEA7376793887ED3C3FA0AE13668C09@qq.com \
--to=lehua.ding@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=palmer@rivosinc.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).