From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 847C73857B98 for ; Sun, 4 Sep 2022 16:57:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 847C73857B98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 284APbnC017447 for ; Sun, 4 Sep 2022 16:57:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=JmRuz+FDCprdu1d15sJQUMarwwfpSMzZ4czQEOuWU5g=; b=AvG8hVlc54Ho+BKKyBomtgORhSXVu1yZ4tVv4O9siQ4h17d0bCW0zFXrszy860EGOLHk XNHqpN1Fq6yeE/hCqvKXCHUldrBV/AAxpYxQ5fY4WeSxhsXCw5iinUJCKHzn8AE1aLVF ljpC781R1WKaM28NMqT05SLjI+R/U9gTCda3Xr0AJvkTO0yPb07FAQb8Ri80p+e7eMOq j6doAeNzGL4Udjdz3xAQDI2hQILa2R8MgegsKUU7QCiGgVS99oOTVLyBZQWVD4OQQLRC FNw5jccxy6T1L4QPCJfZinM4CVl1cUWuN9ukF/tMkGhHjosohFqJ3ooQH5JvfTsddR0O ZA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jbwq2a04y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 04 Sep 2022 16:57:16 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 284DLNTV028074 for ; Sun, 4 Sep 2022 16:57:15 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jbwc7b4vn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 04 Sep 2022 16:57:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jwzYQnM2gB+6HYnSfiJ4DHgNl0A/HjC7+sNV7G0fg9pMLX9WfEbOMmI5NQJDXoMSkkognMe5Uan/c31BMccpD1I7aF5L4GfHTRTiBS+w2uWrQAJYCQGCTKVbbGCtl0GPs5JmWjqcsJaKHuGjfhwNbtGAP9p67vbYfbPT8he2ACg4nj6rDtAnuebuYyzlLVYeEyrkaeKYIYquMYIIL+MOXlQy2b+3rw1O+OiINKbiH0uXvTwSfAQXFPqFO4zpMbr8nFuognJg9CI8oUbHgIvb1iaVYh/fXtyb2Geakgw/eRySJ7rsoNdCXUBAh8NwUbTpyxgt2NgW2jIygHWIH+OkXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JmRuz+FDCprdu1d15sJQUMarwwfpSMzZ4czQEOuWU5g=; b=YEP0pOxOuOMS4GF0aKHiIAUln0eN406mTX3G/ASvV75OfYpygmszEB/pa4TRe6gw5u5jeTMIgc4lfLPBnyp4PgYzekAnMQ+HQ6RbQx/i3pIK4KdjB4YujssT8ky5iso5QycCxvd1qzmQ/Wx3dIQ2mDTll2f1LRh/RcVQE6TQBlgeRfsNfW7jJ/PAKNzdYhWv7h230XaWDyY2hriSFu1UApmfDxwDRck+TrX6gfQashj0tverU/WjM2Pca+kw6MW+me96IiuvIxs2KmcSe4JaU+oq2CcdS66eHei+XtDdwNdrxViUJ/NStWOl0Ppfr2qqYByWukzYEX1OmiGNStuaog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JmRuz+FDCprdu1d15sJQUMarwwfpSMzZ4czQEOuWU5g=; b=aSQiThmMjzlKPqu9K1rZtslU3/MH9qQyXU3BYoqtFBtbljcQqHAoG5tYDAdbkPViGZhvsFsu20F8ITccfHFYEw0IuZHZZGohKdsvR9/5X+3u8/w6wssvcZ68IJUzr4aFuxomZOIFypI36wVQhc0JtLDmzumS1wG9nuZ7HpkMhGE= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SA2PR10MB4442.namprd10.prod.outlook.com (2603:10b6:806:11a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Sun, 4 Sep 2022 16:57:12 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::e830:545a:2bf1:28ef]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::e830:545a:2bf1:28ef%7]) with mapi id 15.20.5588.010; Sun, 4 Sep 2022 16:57:12 +0000 Message-ID: <917330c3-2fae-cb20-4078-b68deedc0da6@oracle.com> Date: Sun, 4 Sep 2022 09:57:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] btf: do not skip emitting void variables [PR106773] Content-Language: en-US To: David Faust , gcc-patches@gcc.gnu.org References: <20220901195340.10653-1-david.faust@oracle.com> From: Indu Bhagat In-Reply-To: <20220901195340.10653-1-david.faust@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P220CA0013.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::18) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6b65f830-9870-409e-3a27-08da8e968345 X-MS-TrafficTypeDiagnostic: SA2PR10MB4442:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ip4e04wT5Cb2Jv6JgVjqNkrSlqL4oDfq59I1Wjb7a8kVRsd/G9Bsk7Ql7K2x9BrNfovOa0nY+E9rNPNciDUvPubK+l9XJUMLA9TbBnyW7NAaoPrELl18nbcwVD5lZHmM8cSM03+7yEs/PtxyJIJiHkRYgNMV7qwNvs74W9BK4nPaAzhtcqFvml2gf761c/TyYLDKjY6j3k+VTQeF5SM6IMZv5c8ovEWtDl6sKY1XI0igBKmHmRgVY2G1ncnVCwklDThHq72uJ78ZyPt/ab+aeFk2kqAaGan20SMNpFdYMvZiPvb5gC+nwdAVwxmWnaWjlYtJmRtsGIQbE+fqd7LFl3VI1ZgundUeCJvOsxbTui1Bhd/pibvPk7nS3RNmWcHwpcnCzTHK5NGhtAsm07LDn2WVNctKjAK/o87gSFO/kxTH0vYtEtsAkKXmJT6xp/lAWn6Zj8BDwkCSShRIeXEQcY9EEslL1MHnmh2VjMuERjVEIClV4K0QWr4OPRkmFaAXuK+O29lmvGQZCVF7S8VJsiVQBlJ+xWmCeMHwSZAkybTW0cJc0mwr7rJV5pk5pMapYKYqrdsm9XyrlUMbJoGnZgYK0UppHNZysLWRWYvftJ8pHDQ7KyrGp29lkMSwppLY8ic8JvBbwb/cSGXzdTkCaN/Q7rCBOPtmuiCYH6c81l+I07aIAoK4x44HRhO/PO3imEbkDDpHU+HXmgRAQHdRirNubIdg8F9ZAK1rNt+g0bOR/fUMmKYqXM2GWX5xmcerpXJmYFaEkmmczbXWxQyCZg9+yW/DJjfp+Ksvn2lc7p1sb6JyQnpZq1AZTeERdHuiZAiw4kN+0+VTqYjE2IduGg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(39860400002)(346002)(376002)(396003)(478600001)(2906002)(31696002)(6512007)(5660300002)(53546011)(86362001)(26005)(44832011)(41300700001)(6506007)(8936002)(38100700002)(2616005)(186003)(83380400001)(84970400001)(6486002)(8676002)(66946007)(66556008)(66476007)(316002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2dac2NmaWtiSFoxYW13WEJNUkYvUExxb3VjWVlsSDZVb1pOUFJXMUFnVm5D?= =?utf-8?B?RGZhQS96WERlTzZnM2lnRFpvUHh6Q3NBNmNtTGJZaG9oNGFzbkovUytJZmNm?= =?utf-8?B?RnRPT1JybklTeWlxMVp1K3JXSnZicVI5YVBncmZQUFhCNE9EWUZ4bEkyZGRv?= =?utf-8?B?ZXc3VmNiZEhQUUhPWGtYdSswSFNvTHhUV1BhbTRSRjBWWGg1T0ZwaVB4Tmt5?= =?utf-8?B?RzhMZEdFSnhSUEJmQkNReGNUbm5BMFhKT2pTRy9vOXdKa0VzZnRGZTB3cFlz?= =?utf-8?B?VVpVUzV5K1NteGZFbGpTMlcrMVR3amMvYjUyUFlZQ1Jjdm5lN0ErWHAxQUZ6?= =?utf-8?B?bHhsRWEvdzZNVmVYQ1FOM3RUczk0ZG9ZcjhkVXFYWldHcVA4NmQrT3pKOWZs?= =?utf-8?B?cmhKUHJRSDNpT1NDUTkzaEsyZUgzejY2MG5ubHE0S0p5NkFDTm5oeDE4ZFBx?= =?utf-8?B?cEhOVVhscnJybSthY2NKSG1BQnM5SENUdlI0MmFHeU1QdStHZjN1TnhzY3JG?= =?utf-8?B?MnV0YzF1N1VqN0ZycUlTSVhnUlBwY0pRZzZCMmlvUjcyb0lKNHZIMUM5REQ4?= =?utf-8?B?QTgxMTA0aWxTbExmZWtmaytjYzFkNlltN1ZiMHlUcGZxRnVVd091RFgvZ1Fq?= =?utf-8?B?c1RIeW1adFpNR3VWWUJxYi9LL2E0eGZLd01JdVhYeGFqYzY2UEkxMkZ5UG9u?= =?utf-8?B?SmNpL3p6TVU1S1BGQ0Y3eVptRGxEY3dXN1NMSkp2dWVWcDduUTRCNW9iT283?= =?utf-8?B?WURRRmdHRWxXSTdCZ2tLcjJ5RzN1SkZ6QTdGN3JyMjloU050MjVLTWczb2s3?= =?utf-8?B?UEFLM0R4dUdyMUQ3aEdVak9jdk81a2lSbEpBUnJDRS9lS3Z5cFNURC9CRmFw?= =?utf-8?B?VVZXNHRXM2N1blVHWjBwTW9KMTRhWldKN01xMFJHREFqYWh3U2tJZHB1alJV?= =?utf-8?B?U0lZVmpyaUFucVAwWUVwQllrMFI1bVdIRnYxUncxSFpYQTBod0cxR3hXT1M3?= =?utf-8?B?andaTS9CbXdKMDVpQjRzaElHTFUyU1ZlMFFtSmNmejRTRm5RQU1icjlqMENx?= =?utf-8?B?aHo1VENwTS9RSFN2Z3h1aEd0bGZPcGhHdnAxZFR0eXZjZlVqSXZtdkNNV3d0?= =?utf-8?B?ajFKM1hoVTJWRnVuNzJyZFR0UnVzMXAyU09jcWNpQVRHVHdzSlFVOWNoV0NZ?= =?utf-8?B?VzZTbVUwekZPSk1wTXF0dXY2akJFSEF0SnBPM1R0bGg4ZmlSVWJGNk55RXlt?= =?utf-8?B?eEtBT25MNDlIeittWTIrWmFGVzRHTXY4TUtmdVAwWE5LMmVLU0FENEFvR2s2?= =?utf-8?B?OFNWbW9iWWJWVzlNZlcxcEliRmEyRWxQa2Zzc1l2SmhSeDJFakdZdGk0YUtW?= =?utf-8?B?WUtMRTlIRU50ai9lazV5YUlPc1c4cDFzREhBcU0rdGNhYWpZQ004b0FuUCtp?= =?utf-8?B?Wm9KNG9aY0xodXBrNFlKWWYvZ25LcFNoL3VnUS9Zc3NCWVRYWmNPZTNlbkpK?= =?utf-8?B?Uk8vUC9oLzdWQ0RvZDNDa3llR0UvMU10SWRKcWVsdDRpRklRcjdNeW1xMVNW?= =?utf-8?B?dHdHTVdxeHhwb0F1c3h3bWpOM2FFb3hzRjJkZDlXOU5kdVNkSDJNS29mTDh0?= =?utf-8?B?SGpQSGdPU25RNDRQRjJRSUl4K0pUTmtMSmFLMU5ZSjRBR2hBMHhnTWR6NGpW?= =?utf-8?B?c3FMeS9Nbnd5cTJlYmV2RWttWDlrSkx2cFhDczYzeUE0QlNnSXgrSDRVTEM4?= =?utf-8?B?aHNDOHhrU2JVai9vOEl0eW5OWWlxZmgwUjltdGlQNHZXZEtSV1VHNnp4dUp4?= =?utf-8?B?M2ZXbDIzMUIvUVI4SU93Ykdac2tBREhyZWViZFdNNnljZHRnVkhIaC9leU85?= =?utf-8?B?UWVPTHpFL2pxNU9vSE84dGE5M0Fhd1ZjZUpSd0JrRHNpY1pSL1duR1VrWHZH?= =?utf-8?B?SStGd2EwU1pscGFQNUtXWENxcmRTZlZSV1ZmbFZmZjNxT3BIS09LdnR2UlF5?= =?utf-8?B?Nlo3MmlyUEdoYzU0TjY1UDBYNHRiS0xuNUNvMHQzWkplZlV3VUJibnMzdExB?= =?utf-8?B?RmhrTFY0TTlPcEJaSmtpQjU5RFhzdUR5QVZVTjBhT2crekF5WGZVNDhnTjdL?= =?utf-8?Q?Ea0lzNoiCKJgdADapOzF6FJKz?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b65f830-9870-409e-3a27-08da8e968345 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2022 16:57:12.6343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gasVIesSWSS+ARteMzoDO+X6sSlmf1KZLs7/1TpuRczAPJ1GddhxKOww5JyB9ghO9uY3fsmQmlhGK35ysaS9qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4442 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-09-04_03,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209040086 X-Proofpoint-GUID: aMi7mWARE0y6Dk5dBcsobI2BDuOlZjBD X-Proofpoint-ORIG-GUID: aMi7mWARE0y6Dk5dBcsobI2BDuOlZjBD X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/1/22 12:53, David Faust wrote: > The eBPF loader expects to find BTF_KIND_VAR records for references to > extern const void symbols. We were mistakenly identifing these as > unsupported types, and as a result skipping emitting VAR records for > them. > > Tested on bpf-unknown-none and x86_64, no known regressions. > OK? Hi David, LGTM. Thanks, > > Thanks. > > gcc/ChangeLog: > > PR target/106773 > * btfout.cc (btf_dvd_emit_preprocess_cb): Do not skip emitting > variables which refer to void types. > > gcc/testsuite/ChangeLog: > > PR target/106773 > * gcc.dg/debug/btf/btf-pr106773.c: New test. > --- > gcc/btfout.cc | 2 +- > gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c | 21 +++++++++++++++++++ > 2 files changed, 22 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c > > diff --git a/gcc/btfout.cc b/gcc/btfout.cc > index 997a33fa089..37ec662c190 100644 > --- a/gcc/btfout.cc > +++ b/gcc/btfout.cc > @@ -430,7 +430,7 @@ btf_dvd_emit_preprocess_cb (ctf_dvdef_ref *slot, ctf_container_ref arg_ctfc) > ctf_dvdef_ref var = (ctf_dvdef_ref) * slot; > > /* Do not add variables which refer to unsupported types. */ > - if (btf_removed_type_p (var->dvd_type)) > + if (!voids.contains (var->dvd_type) && btf_removed_type_p (var->dvd_type)) > return 1; > > arg_ctfc->ctfc_vars_list[num_vars_added] = var; > diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c b/gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c > new file mode 100644 > index 00000000000..4de15f76546 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-pr106773.c > @@ -0,0 +1,21 @@ > +/* Test BTF generation for extern const void symbols. > + BTF_KIND_VAR records should be emitted for such symbols if they are used. */ > + > +/* { dg-do compile } */ > +/* { dg-options "-O0 -gbtf -dA" } */ > + > +/* Expect 1 variable record only for foo. */ > +/* { dg-final { scan-assembler-times "\[\t \]0xe000000\[\t \]+\[^\n\]*btv_info" 1 } } */ > +/* { dg-final { scan-assembler-times "\[\t \]0x1\[\t \]+\[^\n\]*btv_linkage" 1 } } */ > + > +/* { dg-final { scan-assembler-times "ascii \"foo.0\"\[\t \]+\[^\n\]*btf_string" 1 } } */ > + > +extern const void foo; > +extern const void bar; > + > +unsigned long func () { > + unsigned long x = (unsigned long) &foo; > + > + return x; > +} > +