From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28392 invoked by alias); 11 Sep 2017 10:06:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28364 invoked by uid 89); 11 Sep 2017 10:06:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=HX-HELO:sk:mailout, H*r:2014, H*r:May, H*r:ip*7.0.5.31 X-HELO: mailout1.w1.samsung.com Received: from mailout1.w1.samsung.com (HELO mailout1.w1.samsung.com) (210.118.77.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Sep 2017 10:06:09 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20170911100604euoutp01e265e36ed17f68789e45e22ad4c275cd~jRqJ6s_fK3237732377euoutp01m; Mon, 11 Sep 2017 10:06:04 +0000 (GMT) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170911100603eucas1p2b789ca1436ea890d430c4c6f367758ac~jRqJUy_330357603576eucas1p2o; Mon, 11 Sep 2017 10:06:03 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1.samsung.com (EUCPMTA) with SMTP id A4.8E.12576.A0066B95; Mon, 11 Sep 2017 11:06:03 +0100 (BST) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170911100602eucas1p2f0019fe5778212fb5beec143f2d899c0~jRqIiHJs50359003590eucas1p2y; Mon, 11 Sep 2017 10:06:02 +0000 (GMT) Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 95.D6.18832.A0066B95; Mon, 11 Sep 2017 11:06:02 +0100 (BST) Received: from [106.109.129.179] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OW4007LJ1E2EI90@eusync1.samsung.com>; Mon, 11 Sep 2017 11:06:02 +0100 (BST) Subject: Re: [PATCH][PR sanitizer/77631] Support separate debug info in libbacktrace To: Ian Lance Taylor Cc: GCC Patches From: Denis Khalikov Message-id: <9173486c-bb02-139e-30c6-d67879502df5@partner.samsung.com> Date: Mon, 11 Sep 2017 10:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset="windows-1252"; format="flowed" Content-transfer-encoding: 7bit X-CMS-MailID: 20170911100602eucas1p2f0019fe5778212fb5beec143f2d899c0 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?RGVuaXMgS2hhbGlrb3YbU1JSLVNXIFRvb2xzIExhYhvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG0VuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?RGVuaXMgS2hhbGlrb3YbU1JSLVNXIFRvb2xzIExhYhtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG0VuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1Nw==?= CMS-TYPE: 201P X-CMS-RootMailID: 20170616153942eucas1p1945271f893265484bbb3991a368bcd92 X-RootMTR: 20170616153942eucas1p1945271f893265484bbb3991a368bcd92 References: <2b505c8c-a836-6079-f744-3e9f8acf9356@partner.samsung.com> <9396366a-47ab-899c-cbcb-e79af1338869@partner.samsung.com> X-SW-Source: 2017-09/txt/msg00563.txt.bz2 Thanks for answer. I understood all points which you mentioned, but can't find last one > It seems to work > out the file name a second time, even though the file name must > already be known. Can you please show me where I've missed that, if you have a time for that. Anyway, your patch works for me. Thanks. On 09/11/2017 12:11 AM, Ian Lance Taylor wrote: > On Sat, Jul 29, 2017 at 1:42 PM, Denis Khalikov > wrote: >> >> Hello Ian, >> thanks for review. >> I've updated the patch, can you please take a look. > > Apologies again for the length of time it took to reply. I've had a > hard time understanding the patch. It's quite likely that I don't > understand how it works, but it seems to pass the same file descriptor > to process_elf_header twice. It seems to look for debug files with > the buildid in places where they will not be found. It seems to work > out the file name a second time, even though the file name must > already be known. I eventually just wrote my own implementation. > > Could you try this patch and see if it works for your cases? The > patch is against current mainline. Thanks. > > Ian >