From: Jeff Law <jeffreyalaw@gmail.com>
To: Andrew Pinski <apinski@marvell.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/3] Improve ssa_name_has_boolean_range slightly
Date: Tue, 5 Sep 2023 00:58:15 -0600 [thread overview]
Message-ID: <918c9574-1376-4766-b142-850e101c0080@gmail.com> (raw)
In-Reply-To: <20230902150957.845269-1-apinski@marvell.com>
On 9/2/23 09:09, Andrew Pinski via Gcc-patches wrote:
> Right now ssa_name_has_boolean_range compares the range to
> range_true_and_false but instead we would get the nonzero bits and
> compare that to 1 instead (<=u 1).
> The nonzerobits comparison can be done in similar fashion.
> Note I think get_nonzero_bits is redundant as the range queury will
> return a more accurate version or the same value.
>
> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
>
> gcc/ChangeLog:
>
> * tree-ssanames.cc (ssa_name_has_boolean_range): Improve
> using range's get_nonzero_bits and use `<=u 1`.
OK
jeff
prev parent reply other threads:[~2023-09-05 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 15:09 Andrew Pinski
2023-09-02 15:09 ` [PATCH 2/3] MATCH: Improve zero_one_valued_p by using ssa_name_has_boolean_range Andrew Pinski
2023-09-05 6:59 ` Jeff Law
2023-09-02 15:09 ` [PATCH 3/3] MATCH: Replace all uses of ssa_name_has_boolean_range with zero_one_valued_p Andrew Pinski
2023-09-05 7:02 ` Jeff Law
2023-09-05 6:58 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918c9574-1376-4766-b142-850e101c0080@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).