From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 3A4B13858D32 for ; Tue, 5 Sep 2023 06:58:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A4B13858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1c0ecb9a075so9342465ad.2 for ; Mon, 04 Sep 2023 23:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693897100; x=1694501900; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jJxkyiCfXQApfI9F9/j67E9qM/m8XjneyMcNGnInVI8=; b=qPjakBB/886JontqJ7S9Znaclz5Saj9U6v8vJkVCkGNbgf3WO9CvSAmLQdH25HnzfD Ueaozqfaaev22JanD5TZ7sA1NK7Z6B/NlZmLFTx4veCbFFAG55QUTGQt65JjmcD4Lwoy fRHDxM7U0ps0nYukTRUHnwI/CQcmbAmM7m0RySXZwceuSZ7brFSHMxX9mkpqH51cpGbu ENuhg+hBaYgT9nOd59ZqW9vPuKqj12pFosu7ewV+yk/ARINONn3ghd+XW96is+xbSKSc 0dWBoqOsA65jUT47SJeyNY4U+YJB+qlCpORM9xIgoqX3jPKke/GjAVvrt+G+zwv8YwgW KidA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693897100; x=1694501900; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jJxkyiCfXQApfI9F9/j67E9qM/m8XjneyMcNGnInVI8=; b=Ont4klVMF8dJdeF7KxHAktIM73tBrOX6GxuyUcgb+uK8tiw0XJOCoB2aA7L7pBaYua y42+tOtfJOe1xWmFvbmnj0pB+hIiiLLzCVcp4SLOLCImrmfpWgWw7ggfHdifO7LEQN28 eKSjpfhQsdtw2NXRv/+AuuWH4fLVacOWm6tJB7I8izP3QDMIWSMCZTdC/eYh03pmqZRO lBFlVTELxZRIagTRqq10dJX/HeRRaRJNGxsHJRVxRXimGl6my9ERIFlyHWuS1WS2X1xn zYO2yNe1ZSHjeBain9b20W2oSGTkpgY8xMzs4PMapZ11WoWrjxl0mFkWsmBPEPv9I+AJ lGFg== X-Gm-Message-State: AOJu0YxZsHL8PmeE/2S4BZNF5MIkGyHEUY0tNCNxC+PZ6d/+G6e6AZch 6bq6tNkEqhDBN7xvZuo39WM= X-Google-Smtp-Source: AGHT+IEo/m6gAT2CP52b7NtXLGV339UiDscbSSBm8w+ms/hdnPvQbOslxznVg7bxHIJvjLcl0nVQ4Q== X-Received: by 2002:a17:902:c449:b0:1bf:34fb:3085 with SMTP id m9-20020a170902c44900b001bf34fb3085mr8387530plm.14.1693897099980; Mon, 04 Sep 2023 23:58:19 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id b19-20020a170902ed1300b001bc68602e54sm8528634pld.142.2023.09.04.23.58.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 23:58:19 -0700 (PDT) Message-ID: <918c9574-1376-4766-b142-850e101c0080@gmail.com> Date: Tue, 5 Sep 2023 00:58:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] Improve ssa_name_has_boolean_range slightly Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230902150957.845269-1-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230902150957.845269-1-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/2/23 09:09, Andrew Pinski via Gcc-patches wrote: > Right now ssa_name_has_boolean_range compares the range to > range_true_and_false but instead we would get the nonzero bits and > compare that to 1 instead (<=u 1). > The nonzerobits comparison can be done in similar fashion. > Note I think get_nonzero_bits is redundant as the range queury will > return a more accurate version or the same value. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > gcc/ChangeLog: > > * tree-ssanames.cc (ssa_name_has_boolean_range): Improve > using range's get_nonzero_bits and use `<=u 1`. OK jeff