From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id DFA7B3858413 for ; Tue, 1 Aug 2023 21:55:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DFA7B3858413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-686ba97e4feso5996879b3a.0 for ; Tue, 01 Aug 2023 14:55:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690926918; x=1691531718; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xsXQk9uqBuRkyTubUG8B/w1JTZTZEVcqCCHVzaeZEuw=; b=S0EPK9hVhTVLdjIPK7B1Kl4kF4/IawxWl8H4O57ebcBBzAlsqbstoV9w2gBju1WYny nOdD32R3N/MUOtK51pWVi82jzjcEbBqaTtNXnsL5pCFp4Jk5njQMjmVXl4ICfZfDFJ3Q veVKCQILwZtbfxHAUmBw+7krsdkbiRqjvJqvLdR3DO/VWvbQBSWvnplyNg/WrNVdMbKf uP2ZrrScbGyVeF0IFaWvUiHlc0TCc+9T/HOO8Y34PkXLshM2sHh4Ky1O4Y+ghROcWQXO 7dFfHriltiEsUYIfwY55WDWKBb7FTaOSz03V0RY+qG5y/Fix3Ke2SxVgbEn7TMw1CIfw dg2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690926918; x=1691531718; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xsXQk9uqBuRkyTubUG8B/w1JTZTZEVcqCCHVzaeZEuw=; b=cAeeGw6BErBlgPjiINxxi4JWqXxIlkInQuYu0vgBKe+f72/qASJbc+8pbzBJSaxUxd Hcjr18QZriGGAQr63AwzdBQc7hm7iWNY4MtUkF3YZGhGfPcpKuj/kO0VKG8sy+/L6zYR 4VLHBz7D4TTcNuc2nWx87ZrzUs341JqRdBQdILicYdH9QAbkMf8N0NiJjAgEADEiTAi5 GklRrgCCqjKCObDTEr3TK3R4kg9uTi7pS6Q+UYnPO+W696Xsquf1qLIR1pRCS2m/FuJe zRgLaxqP59uKWFSFw/y9ZtYSx1uklPA6xRMViYsai1n7kktNiuAClEwhVCNnacDOJtFP dGhQ== X-Gm-Message-State: ABy/qLYMouN8uFCHGnTX3aZVYk94huUZSpWpGH+20k617//T9R9QX8Lj jezWWzlDZfHjftzec+CwGFg= X-Google-Smtp-Source: APBJJlFgAe8HEaG46MZWs7qIxIJUOSYx6K5zgfA7BHWoPS8XTMCYIFmDKIGTqjhfPLkXpIhbFkijnw== X-Received: by 2002:a05:6a20:5530:b0:137:a9d7:d8cc with SMTP id ko48-20020a056a20553000b00137a9d7d8ccmr12897856pzb.24.1690926917645; Tue, 01 Aug 2023 14:55:17 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id 16-20020aa79210000000b00682af82a9desm9974580pfo.98.2023.08.01.14.55.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Aug 2023 14:55:17 -0700 (PDT) Message-ID: <91c12503-c288-5b81-8941-cc62bab2ee98@gmail.com> Date: Tue, 1 Aug 2023 15:55:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: RISC-V: Folding memory for FP + constant case Content-Language: en-US To: Vineet Gupta , Jivan Hakobyan Cc: gcc-patches@gcc.gnu.org References: <3c1f0f8a-34ed-abb2-8a49-3083a2cc55d2@gmail.com> <61c9b9c2-f52e-2b4e-6d02-62c991603c39@gmail.com> <64233838-fe5e-458d-1eaf-3025b5448d85@rivosinc.com> From: Jeff Law In-Reply-To: <64233838-fe5e-458d-1eaf-3025b5448d85@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/1/23 13:14, Vineet Gupta wrote: > > I have some numbers for f-m-o v3 vs this. Attached here (vs. inline to > avoid the Thunderbird mangling the test formatting) Thanks. Of particular importance is the leela change. My recollection was that the f-m-o work also picked up that case. But if my memory is faulty (always a possibility), then that shows a clear case where Jivan's work picks up a case not handled by Manolis's work. And on the other direction we can see that deepsjeng isn't helped by Jivan's work, but is helped by Manolis's new pass. I'd always hoped/expected we'd have cases where one patch clearly helped over the other. While the .25% to .37% improvements for the three most impacted benchmarks doesn't move the needle much across the whole suite they do add up over time. Jeff