From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 32BBA3858408 for ; Tue, 28 Nov 2023 05:03:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32BBA3858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32BBA3858408 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701147805; cv=none; b=Tc5R/luDPI1lePZPP3jzdyi4iXUJYygY9z4a8ExJ1Pb2cc3XQQAWDmTiJ6aoi6zHc0BLtoCFyhdxO9qr0biTO8YNebiK+SkAf4bA8/t9sCDGyhFWdOqlj6b2BovSj22BCu5omwWv3Ar70wj0IOi32ORPTRhuwWmVAJkPRXZTZy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701147805; c=relaxed/simple; bh=wdKpqfBc45gQ4HSbp1Nez5SbWXHUm/W/60REkFRYzyk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nXdYjz7wEP71rwdqVR+Wc+Qno/Y3p0Xpq36PVruzmSsI3Empo6EW9sHZCzbLlRV4IPX4PRJThiL1FYjm/HS3njdhTVI8sG5dNWTTVILK1zdRMetHx1ypqPGAhiRfKgDTQl+exCFgApXcqToWZb1eJN55QHgyP5m0HSkKNRWOHI0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x129.google.com with SMTP id e9e14a558f8ab-35c18e55633so17165675ab.2 for ; Mon, 27 Nov 2023 21:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701147803; x=1701752603; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4BvnYHWYfPFlVEA+j2PPvI/p4mF9HE1aQK9fTgrN2WI=; b=nJOmiuOMzz5eOQl947gcoOVY8Glpiq9aaJRluOtL309C59OzKcoQPAVRx12CbhthHb Abg6ZY7KUnuy7s9GM8a0xbv1EOOOBjvvzfgDw6oTpZPtJPcrXgCLPO/2MCTfloPiqlEP wr/FpElf2cYhJdd1R+QwvlwiN6xdLiLYKlFikC3jqMTwKQrCg+XPg/dGZuEzEQzFFcN7 X3vy21nwQDAc68ByNJdZ59KkEPTWq1cjLDvhOOxVUkofcIhDHw+13ACSySO0bce0O9dh ZxqPCzr0Tlx6HTKnzHKq3dLCM1FirK/gbE2Q+PrNScMuo4jDI7+CN8SYor5B9HkgM9J/ vSkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701147803; x=1701752603; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4BvnYHWYfPFlVEA+j2PPvI/p4mF9HE1aQK9fTgrN2WI=; b=ihZHzXL8PnQ/7qUFcIK03hNoGS2nkDgEJiYfkeKs0EG1ngeYVYARWUM3nMPbrD/7o7 xAhPMUVFHpPCCi4I2VMw5HRE3PS39Ji4WadKNUYsTRop19WYfHfjac7J2tPo1BQAvM2d UDBvaDKL6YnJb49FwfLxJE3rM+1gTD0Fnv/Y6NQ3rkCBeLhG3RXE3cZw2tj/AXgb6J7y a+LgIwc/995AqP6zSky7/rleOibjVhClWxHKE1cJBmyyBHwR4swW8oA6Dfoo9t+vE+BJ Rrx9kISzCb+nXiEBgAIQGqERlcA1ui65pkqszU7aWVKrHxndWjoBnuq3amQ/GpMLM5RF 2OSw== X-Gm-Message-State: AOJu0YwF/a1hTr+ORyflcnZ+wUfj8AP5C+V0AlD1FIgpbmStzZszDjc/ Affh5cQvo9fFOA+g0j9MZB8= X-Google-Smtp-Source: AGHT+IEwGeMcscIo0xqZiFSVQ1yv/kDUx4YnC45UMai1YsbWDGWtGCwSuX0caVWUAksQmJ6a9H7agQ== X-Received: by 2002:a05:6e02:970:b0:35c:ca7c:ebb2 with SMTP id q16-20020a056e02097000b0035cca7cebb2mr7222799ilt.20.1701147803120; Mon, 27 Nov 2023 21:03:23 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id hy13-20020a056a006a0d00b006cbb71186f7sm8129488pfb.29.2023.11.27.21.03.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 21:03:22 -0800 (PST) Message-ID: <91d11f82-485e-458a-ab23-17ce70bb40d5@gmail.com> Date: Mon, 27 Nov 2023 22:03:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] [RISC-V] prefer Zicond primitive semantics to SFB Content-Language: en-US To: Kito Cheng , Fei Gao Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, zengxiao@eswincomputing.com References: <20231128023227.36200-1-gaofei@eswincomputing.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/23 20:09, Kito Cheng wrote: > Personally I don't like to play with the pattern order to tweak the > code gen since it kinda introduces implicit relation/rule here, but I > guess the only way to prevent that is to duplicate the pattern for SFB > again, which is not an ideal solution... I won't object to this patch, but I don't really like it either. This patch highlights that the SFB code is not well integrated with the rest of the conditional move support. Jeff