From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 6F1583858D35 for ; Mon, 8 Jan 2024 02:35:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F1583858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6F1583858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704681329; cv=none; b=Z9DICJnSJe0err19/gqxAPuepfXf7TXzY3KCOWOE8w3Ulz5u5apI8u000E73XPGLU38eIdeMuJNY26CNm4Z4MAMEa4yK8rlBm3AWkFljqRKKnvVi/Kr1TGm8fS14igkFT+nTucMOhpCia9ZCtSAqOf3sNZRtAkVnGZnnESsoZL0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704681329; c=relaxed/simple; bh=29hpQknreNvZoXDp/5ad7h8sNyPwGyU3/c8BaasBf+k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=T9klQ6aMhaidfwkxUmTsvsJehlehU1zMLMop0RfIlxAtUCiVHn+d/E62QKx0UHSh4679ixQNTM4FAIy3Y5O042FHDhTzHGSlw+vtkVKKav7O+4OfydE0TrHpdFnnh/E9aD+lN10drpUzVGEie7fjInMOnEDXYYDOj//eI0zsQZY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 407KY7ks031174; Mon, 8 Jan 2024 02:35:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : from : subject : to : cc : content-type : content-transfer-encoding; s=pp1; bh=MUwJ1vBCQh8Gavz6mPgSN+ZIEpyvcmUCHAz4hYIGvMI=; b=G8KG5TznnZ2bt9EX4zzoJ/Ig76cxexpartN19UppA3TSebTyFgA0yBTUwYOkSJiIiNTe ugKPOYa9fVwc8NIAjOw57a3GTYvH3d+LYbq4oxdYKg78pB4LrgY5xgPoPjeIqiNXX1Ov Ravw2TCI+NOWQwIRCvDwZBk2eAYU3ulJpcMLy23xAqrEsXQoX7qILs9D0D7MLeN1p7Ac D3zyChE71RcxQKHG7IBpetJ6EmM8ZvJ7PNUXjAwl3bwyInhXTQNMAJUiCq9EFEBMesXx FZu1rlM2dzFHU6MEdq9NGtBU6WyTipHZvb7j6g0Oi+jvQnWjkRsbNJIaOCcVNfNkjnuW 4Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vf1qehx1u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jan 2024 02:35:16 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 4081x6Fj013057; Mon, 8 Jan 2024 02:35:16 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vf1qehx1h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jan 2024 02:35:15 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 4082BrCH004395; Mon, 8 Jan 2024 02:35:14 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vfjpkdc3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jan 2024 02:35:14 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4082ZCXL14942622 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 8 Jan 2024 02:35:12 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2DF4F20040; Mon, 8 Jan 2024 02:35:12 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53F9F20043; Mon, 8 Jan 2024 02:35:09 +0000 (GMT) Received: from [9.197.233.114] (unknown [9.197.233.114]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 8 Jan 2024 02:35:08 +0000 (GMT) Message-ID: <91d2c107-0168-791b-b5fa-de21c2345f84@linux.ibm.com> Date: Mon, 8 Jan 2024 10:35:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US From: "Kewen.Lin" Subject: [PATCH] strub: Only unbias stack point for SPARC_STACK_BOUNDARY_HACK [PR113100] To: GCC Patches Cc: Alexandre Oliva , Richard Biener , Jakub Jelinek , Peter Bergner , Segher Boessenkool , Jeff Law , Richard Sandiford Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: p4GLrG7PTCeAiKyNApyYevSyGayWwH18 X-Proofpoint-ORIG-GUID: CEufGd2XIXr13SWgMECN6m4Ftr7zyAxG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-07_15,2024-01-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401080016 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, As PR113100 shows, the unbiasing introduced by r14-6737 can cause the scrubbing to overrun and screw some critical data on stack like saved toc base consequently cause segfault on Power. By checking PR112917, IMHO we should keep this unbiasing guarded under SPARC_STACK_BOUNDARY_HACK (TARGET_ARCH64 && TARGET_STACK_BIAS), similar to some existing code special treating SPARC stack bias. Bootstrapped and regtested on x86_64-redhat-linux and powerpc64{,le}-linux-gnu. All reported failures in PR113100 are gone. I also expect the culprit commit can affect those ports with nonzero STACK_POINTER_OFFSET. Is it ok for trunk? BR, Kewen ----- PR middle-end/113100 gcc/ChangeLog: * builtins.cc (expand_builtin_stack_address): Guard stack point adjustment with SPARC_STACK_BOUNDARY_HACK. --- gcc/builtins.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/builtins.cc b/gcc/builtins.cc index 125ea158ebf..9bad1e962b4 100644 --- a/gcc/builtins.cc +++ b/gcc/builtins.cc @@ -5450,6 +5450,7 @@ expand_builtin_stack_address () rtx ret = convert_to_mode (ptr_mode, copy_to_reg (stack_pointer_rtx), STACK_UNSIGNED); +#ifdef SPARC_STACK_BOUNDARY_HACK /* Unbias the stack pointer, bringing it to the boundary between the stack area claimed by the active function calling this builtin, and stack ranges that could get clobbered if it called another @@ -5476,7 +5477,9 @@ expand_builtin_stack_address () (caller) function's active area as well, whereas those pushed or allocated temporarily for a call are regarded as part of the callee's stack range, rather than the caller's. */ - ret = plus_constant (ptr_mode, ret, STACK_POINTER_OFFSET); + if (SPARC_STACK_BOUNDARY_HACK) + ret = plus_constant (ptr_mode, ret, STACK_POINTER_OFFSET); +#endif return force_reg (ptr_mode, ret); } -- 2.39.3