From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Disable -fipa-ra for naked functions (PR target/85593)
Date: Thu, 06 Dec 2018 23:36:00 -0000 [thread overview]
Message-ID: <91f641ef-5a7c-0163-7d6c-3961d502e1f0@redhat.com> (raw)
In-Reply-To: <20181206233433.GB12380@tucnak>
On 12/6/18 4:34 PM, Jakub Jelinek wrote:
> Hi!
>
> The only documented supported content of naked functions is basic asm
> statement(s). Those don't have clobbers though, so we should ignore
> naked functions for IPA-RA; if they are written the only supported way,
> they will appear not to clobber any registers at all and IPA-RA will then
> assume they don't clobber any registers.
> While naked is a target attribute supported only on a subset of targets,
> the generic code already handles it in multiple spots, so I think we can add
> another spot rather than introducing a target hook for it.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2018-12-07 Jakub Jelinek <jakub@redhat.com>
>
> PR target/85593
> * final.c (rest_of_handle_final): Don't call collect_fn_hard_reg_usage
> for functions with naked attribute.
>
> * gcc.target/i386/pr85593.c: New test.
OK
jeff
prev parent reply other threads:[~2018-12-06 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 23:34 Jakub Jelinek
2018-12-06 23:36 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f641ef-5a7c-0163-7d6c-3961d502e1f0@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).