From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71611 invoked by alias); 6 Dec 2018 23:36:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71562 invoked by uid 89); 6 Dec 2018 23:36:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:970 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Dec 2018 23:36:11 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 646A9C057E3A; Thu, 6 Dec 2018 23:36:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-17.rdu2.redhat.com [10.10.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5156F1001F5B; Thu, 6 Dec 2018 23:36:08 +0000 (UTC) Subject: Re: [PATCH] Disable -fipa-ra for naked functions (PR target/85593) To: Jakub Jelinek , Richard Biener Cc: gcc-patches@gcc.gnu.org References: <20181206233433.GB12380@tucnak> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <91f641ef-5a7c-0163-7d6c-3961d502e1f0@redhat.com> Date: Thu, 06 Dec 2018 23:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181206233433.GB12380@tucnak> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00419.txt.bz2 On 12/6/18 4:34 PM, Jakub Jelinek wrote: > Hi! > > The only documented supported content of naked functions is basic asm > statement(s). Those don't have clobbers though, so we should ignore > naked functions for IPA-RA; if they are written the only supported way, > they will appear not to clobber any registers at all and IPA-RA will then > assume they don't clobber any registers. > While naked is a target attribute supported only on a subset of targets, > the generic code already handles it in multiple spots, so I think we can add > another spot rather than introducing a target hook for it. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2018-12-07 Jakub Jelinek > > PR target/85593 > * final.c (rest_of_handle_final): Don't call collect_fn_hard_reg_usage > for functions with naked attribute. > > * gcc.target/i386/pr85593.c: New test. OK jeff