From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A5DDE3858CDA for ; Tue, 24 Oct 2023 21:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5DDE3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A5DDE3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698182915; cv=none; b=UwYYRP/321OCD3f9RCo5Ks0G78g2bO4oypHY3F/k3P+8hSsgnhh801/5AynMZoMyFB6E5KJ6Acl4wUMkEFao8076XcCCMSC85jcdlMy63pxACXk5rZyOFQ7Q0IlANtA89PAqBdzxxv+vXlTKrz5BSuLsyP/jMaJIcbBiw5OJ1H8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698182915; c=relaxed/simple; bh=wTNaPcyzHC9QFoYuuoxblM+/D9RoHpJ4mRUozH0OmiI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Q72aiPo1aiVozltmRacs/QPKou8aJ6Mtnx9xtHoN15GXQfNA8WV7CyVMs5bOyjIVxwONtO2ApcHiiJzN0NqhCtcvTgWdiM0WSobmB3vVfiy3CE9sI3Wo04waTFjGFfskkXGLr8rAZj5FCxm1R3gtdUb7is/7y08tkS7cz96XPeE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698182914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f/I/BDdPQu5iKRkpH2jHOAZ+Qe91ctu/k5JVNJ2Bowg=; b=HTRfY3dCLyrN7pKtM+wchA8kTkAzwcl5DTVWdy6Q42Qrh+lLvjI+bU2V2y/SZBR6kqedn/ OtasnFjPeLSUevNR6NGGHBBf3+GJ1N6dCZZ1HWGpt1EcsXYtOP4yXRoL+hbKcESqD7i4Vi JRmV71j3HIqj6AV1SfKd7HXOR50NHJc= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-247-NrebwXcJPA6c48YCRoBsJg-1; Tue, 24 Oct 2023 17:28:33 -0400 X-MC-Unique: NrebwXcJPA6c48YCRoBsJg-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-779d5e4e3d1so362536685a.2 for ; Tue, 24 Oct 2023 14:28:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698182912; x=1698787712; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f/I/BDdPQu5iKRkpH2jHOAZ+Qe91ctu/k5JVNJ2Bowg=; b=J2WSR/R3ppMvFlQ5p2BpUiLU7Mrn2x/JBcHFb66HoLGBMNb41vRIuqQedXPqXGZ1Kn SSqqsj8lQcB9SDGwqUV4+0iwWzwh93Fs3OFkhOZ0Qa75ypQ1GRS7pSOffbr7BRBTTMXN hekv3bCRbiI97T5CKW+gzY8Pcix5razkUD7qMiVyJugqQmfd1Y7Te/cr2AlX01fC+En1 536g3XGX/WD37P+gjVe+HGS5998h9fbB6m2kTUNbe+CHVwyQtjY7BG8fCRZyzLdrnhD+ laUjeB6hA2FqGeP5AVmeWHTkA5cIOGW8JNJaUbnsrSq6Oe8IuvJduseYt16rbk6a2Pl/ jTPA== X-Gm-Message-State: AOJu0YyHRe29O+9QcUQUgelyNOOZlZ8fFcMIOWuvNTv/0POboP8uvZHC LspJD+dnmNk8ETS2c0AAAQ8NN8nTMqxlUDZFc4nS+pMefQC7JU/3PE4Yt5Xpe1mFaF67OeaFfP/ O7MxcVbYE3utUWfnLXg== X-Received: by 2002:a05:620a:4112:b0:779:ecd3:7413 with SMTP id j18-20020a05620a411200b00779ecd37413mr2712597qko.8.1698182912496; Tue, 24 Oct 2023 14:28:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgdjqZ/9vV880YBa+ITEgoH8whSFpK1HsNvB9TixexNjfqL0FCnXaBW5peKn8cWiS6wIUOcw== X-Received: by 2002:a05:620a:4112:b0:779:ecd3:7413 with SMTP id j18-20020a05620a411200b00779ecd37413mr2712586qko.8.1698182912168; Tue, 24 Oct 2023 14:28:32 -0700 (PDT) Received: from [192.168.1.108] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id d11-20020a05620a140b00b00767d4a3f4d9sm3726958qkj.29.2023.10.24.14.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Oct 2023 14:28:31 -0700 (PDT) Message-ID: <924c1ea5-c789-4820-85f3-2ce8c73188bf@redhat.com> Date: Tue, 24 Oct 2023 17:28:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] c++: sort candidates according to viability To: Patrick Palka , gcc-patches@gcc.gnu.org References: <20231023235154.2971561-1-ppalka@redhat.com> From: Jason Merrill In-Reply-To: <20231023235154.2971561-1-ppalka@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/23/23 19:51, Patrick Palka wrote: > The second patch in this series is new and ensures that the candidates > list isn't mysteriously missing some candidates when noting other > candidates due to deletedness. > > -- >8 -- > > This patch: > > * changes splice_viable to move the non-viable candidates to the end > of the list instead of removing them outright Please consistently spell this "non-viable" rather than "unviable". > +tourney (struct z_candidate *&candidates, tsubst_flags_t complain) > { > struct z_candidate *champ = candidates, *challenger; > int fate; > struct z_candidate *champ_compared_to_predecessor = nullptr; > + struct z_candidate *champ_predecessor = nullptr; > + struct z_candidate *challenger_predecessor = champ; Rather than adding two more variables to keep synchronized, maybe we want champ and challenger to be **, like the tail variables in splice_viable? Jason