From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 96D173858D3C for ; Tue, 25 Oct 2022 04:38:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 96D173858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 695991FD74; Tue, 25 Oct 2022 04:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1666672695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i39xqddFs5F4lbsfHatf/l4ae/KcjvBjZ1hKc1XVj7Y=; b=NTGdvah6L6yGNAVJAocWLlc4lbcgSzVvMfGtHSlFgplkkcQ9q+5CYY+p0aKHurtdTnK8nO owTmIPcTO9nzmiU+Px9MWX2UttwP9ykJcg2TMfmgjavbweClq0LD85l0UkZ2JyWA7+BRFs o3XIWe4bTMk+pXpMTdtNITvtcWjmDFk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1666672695; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i39xqddFs5F4lbsfHatf/l4ae/KcjvBjZ1hKc1XVj7Y=; b=jqNYJ3HLp5tbHhi2CJfg+2Qid30gNwDp25ohgMOqB5ODJ3S/xUieC/0/MNCo0LNfCBq3IS ssX7L3RHvkxYksAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3517C134CA; Tue, 25 Oct 2022 04:38:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xfjvCzdoV2ODNAAAMHmgww (envelope-from ); Tue, 25 Oct 2022 04:38:15 +0000 Content-Type: multipart/mixed; boundary="------------xxSeeIaeICzGqe56SxFpqyKt" Message-ID: <9263704e-b2f1-f21d-f888-a884547a0cf5@suse.cz> Date: Tue, 25 Oct 2022 06:38:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH] [x86_64] Zhaoxin lujiazui enablement Content-Language: en-US To: Mayshao-oc , Uros Bizjak Cc: "Silvia Zhao(BJ-RD)" , TimHu-oc , "Cobe Chen(BJ-RD)" , "gcc-patches@gcc.gnu.org" , "Hawk Wang(BJ-RD)" , "Louis Qi(BJ-RD)" , Jan Hubicka References: <20220325020815.16674-1-MayShao-oc@zhaoxin.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------xxSeeIaeICzGqe56SxFpqyKt Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello. I noticed this patch set which is kind of related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107364. And I have a couple of questions: 1) I noticed you drop AVX and F16C features for the newly added "lujiazui". Why do you need it? I would expect these features would be properly detected by cpuid? 2) If you really need it, can you please test for me the attached patch? It should come up with a new function. 3) Have question about: else if (vendor == signature_CENTAUR_ebx && family < 0x07) cpu_model->__cpu_vendor = VENDOR_CENTAUR; else if (vendor == signature_SHANGHAI_ebx || vendor == signature_CENTAUR_ebx) Are there any signature_CENTAUR_ebx models with family == 0x7 ? Similarly, are there any signature_SHANGHAI_ebx modes with family < 0x7 ? Thanks, Martin --------------xxSeeIaeICzGqe56SxFpqyKt Content-Type: text/x-patch; charset=UTF-8; name="0001-i386-add-reset_cpu_feature.patch" Content-Disposition: attachment; filename="0001-i386-add-reset_cpu_feature.patch" Content-Transfer-Encoding: base64 RnJvbSBmYTBiZDk5ZGE4ZmQ5MmIxNWEyY2VlNTU3MzdhNTk2MjY1N2RhMjEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUdWUsIDI1IE9jdCAyMDIyIDA2OjI4OjQ0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g aTM4NjogYWRkIHJlc2V0X2NwdV9mZWF0dXJlCgpnY2MvQ2hhbmdlTG9nOgoKCSogY29tbW9u L2NvbmZpZy9pMzg2L2NwdWluZm8uaCAoaGFzX2NwdV9mZWF0dXJlKTogQWRkIGNvbW1lbnQu CgkocmVzZXRfY3B1X2ZlYXR1cmUpOiBOZXcuCgkoZ2V0X3poYW94aW5fY3B1KTogVXNlIHJl c2V0X2NwdV9mZWF0dXJlLgotLS0KIGdjYy9jb21tb24vY29uZmlnL2kzODYvY3B1aW5mby5o IHwgMzggKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAzMyBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2djYy9j b21tb24vY29uZmlnL2kzODYvY3B1aW5mby5oIGIvZ2NjL2NvbW1vbi9jb25maWcvaTM4Ni9j cHVpbmZvLmgKaW5kZXggZDQ1NDUxYzU3MDQuLjE5ZWE3MTMyZmQ1IDEwMDY0NAotLS0gYS9n Y2MvY29tbW9uL2NvbmZpZy9pMzg2L2NwdWluZm8uaAorKysgYi9nY2MvY29tbW9uL2NvbmZp Zy9pMzg2L2NwdWluZm8uaApAQCAtNzYsNiArNzYsOCBAQCBoYXNfY3B1X2ZlYXR1cmUgKHN0 cnVjdCBfX3Byb2Nlc3Nvcl9tb2RlbCAqY3B1X21vZGVsLAogICAgIH0KIH0KIAorLyogU2F2 ZSBGRUFUVVJFIHRvIGVpdGhlciBDUFVfTU9ERUwgb3IgQ1BVX0ZFQVRVUkVTMi4gICovCisK IHN0YXRpYyBpbmxpbmUgdm9pZAogc2V0X2NwdV9mZWF0dXJlIChzdHJ1Y3QgX19wcm9jZXNz b3JfbW9kZWwgKmNwdV9tb2RlbCwKIAkJIHVuc2lnbmVkIGludCAqY3B1X2ZlYXR1cmVzMiwK QEAgLTEwMCw2ICsxMDIsMzIgQEAgc2V0X2NwdV9mZWF0dXJlIChzdHJ1Y3QgX19wcm9jZXNz b3JfbW9kZWwgKmNwdV9tb2RlbCwKICAgICB9CiB9CiAKKy8qIERyb3AgRkVBVFVSRSBmcm9t IGVpdGhlciBDUFVfTU9ERUwgb3IgQ1BVX0ZFQVRVUkVTMi4gICovCisKK3N0YXRpYyBpbmxp bmUgdm9pZAorcmVzZXRfY3B1X2ZlYXR1cmUgKHN0cnVjdCBfX3Byb2Nlc3Nvcl9tb2RlbCAq Y3B1X21vZGVsLAorCQkgICB1bnNpZ25lZCBpbnQgKmNwdV9mZWF0dXJlczIsCisJCSAgIGVu dW0gcHJvY2Vzc29yX2ZlYXR1cmVzIGZlYXR1cmUpCit7CisgIHVuc2lnbmVkIGluZGV4LCBv ZmZzZXQ7CisgIHVuc2lnbmVkIGYgPSBmZWF0dXJlOworCisgIGlmIChmIDwgMzIpCisgICAg eworICAgICAgLyogVGhlIGZpcnN0IDMyIGZlYXR1cmVzLiAgKi8KKyAgICAgIGNwdV9tb2Rl bC0+X19jcHVfZmVhdHVyZXNbMF0gJj0gfigxVSA8PCBmKTsKKyAgICB9CisgIGVsc2UKKyAg ICB7CisgICAgICAvKiBUaGUgcmVzdCBvZiBmZWF0dXJlcy4gIGNwdV9mZWF0dXJlczJbaV0g Y29udGFpbnMgZmVhdHVyZXMgZnJvbQorCSAoMzIgKyBpICogMzIpIHRvICgzMSArIDMyICsg aSAqIDMyKSwgaW5jbHVzaXZlbHkuICAqLworICAgICAgZiAtPSAzMjsKKyAgICAgIGluZGV4 ID0gZiAvIDMyOworICAgICAgb2Zmc2V0ID0gZiAlIDMyOworICAgICAgY3B1X2ZlYXR1cmVz MltpbmRleF0gJj0gfigxVSA8PCBvZmZzZXQpOworICAgIH0KK30KKwogLyogR2V0IHRoZSBz cGVjaWZpYyB0eXBlIG9mIEFNRCBDUFUgYW5kIHJldHVybiBBTUQgQ1BVIG5hbWUuICBSZXR1 cm4KICAgIE5VTEwgZm9yIHVua25vd24gQU1EIENQVS4gICovCiAKQEAgLTU2NSwxMSArNTkz LDExIEBAIGdldF96aGFveGluX2NwdSAoc3RydWN0IF9fcHJvY2Vzc29yX21vZGVsICpjcHVf bW9kZWwsCiAgICAgICBjcHVfbW9kZWwtPl9fY3B1X3R5cGUgPSBaSEFPWElOX0ZBTTdIOwog ICAgICAgaWYgKG1vZGVsID09IDB4M2IpCiAJewotCWNwdSA9ICJsdWppYXp1aSI7Ci0JQ0hF Q0tfX19idWlsdGluX2NwdV9pcyAoImx1amlhenVpIik7Ci0JY3B1X21vZGVsLT5fX2NwdV9m ZWF0dXJlc1swXSAmPSB+KDFVIDw8KEZFQVRVUkVfQVZYICYgMzEpKTsKLQljcHVfZmVhdHVy ZXMyWzBdICY9IH4oMVUgPDwoKEZFQVRVUkVfRjE2QyAtIDMyKSAmIDMxKSk7Ci0JY3B1X21v ZGVsLT5fX2NwdV9zdWJ0eXBlID0gWkhBT1hJTl9GQU03SF9MVUpJQVpVSTsKKwkgIGNwdSA9 ICJsdWppYXp1aSI7CisJICBDSEVDS19fX2J1aWx0aW5fY3B1X2lzICgibHVqaWF6dWkiKTsK KwkgIHJlc2V0X2NwdV9mZWF0dXJlIChjcHVfbW9kZWwsIGNwdV9mZWF0dXJlczIsIEZFQVRV UkVfQVZYKTsKKwkgIHJlc2V0X2NwdV9mZWF0dXJlIChjcHVfbW9kZWwsIGNwdV9mZWF0dXJl czIsIEZFQVRVUkVfRjE2Qyk7CisJICBjcHVfbW9kZWwtPl9fY3B1X3N1YnR5cGUgPSBaSEFP WElOX0ZBTTdIX0xVSklBWlVJOwogCX0KICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6Ci0t IAoyLjM4LjAKCg== --------------xxSeeIaeICzGqe56SxFpqyKt--